From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oCAuJeJqAGV66hQAWB0awg (envelope-from ) for ; Tue, 12 Sep 2023 09:42:58 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=G6y4MxBK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 943A21E0C3; Tue, 12 Sep 2023 09:42:58 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 878371E028 for ; Tue, 12 Sep 2023 09:42:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 34EF3385828D for ; Tue, 12 Sep 2023 13:42:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34EF3385828D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694526176; bh=3HK+YdiwCdu7ev28roOGzZEE8BO1KlErcbHGyNuHSEg=; h=To:Cc:Subject:In-Reply-To:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=G6y4MxBKrNs4fcM2Mt99nj0P+TH3aL6enn6ZZOjALGTYGiri8IcELWcnfqLtHnNG7 C1qTKKIMjqdx1mPYDbxobyBKH6OFg9JHkCQmJU6lfgMJC8ftUW7wDiUTa432t6CUW5 7G1p9VelBPOa5K6GxPx+93FfZSOhtvE8KK7vkWtQ= Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2026.outbound.protection.outlook.com [40.92.99.26]) by sourceware.org (Postfix) with ESMTPS id E2DA63858D3C for ; Tue, 12 Sep 2023 13:42:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2DA63858D3C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QYv3vWSmkH6rTWnmVKJtNNb+wo4gnyVH/uaRwsL279X9yshgm5nG6PhXR2hqIk/sQcJPY+7sRpBplkG3te5rDHdipayCrjJJt6fjH1kXjHJyqfMu9Qf1k7kK7+etDK/5/KY4k5bDkhsz+o/BjjrVbVOPCl38uMzcvdS7VW/J7jNcsYiEWzHTYzeHsWskZ6bH00DjylUA+KRG5uhFm6A/IIITEOjFGZ2s+vrgVdJmLFdA25OaANZv0f6SrKj7boplEh/T0HE8hADxKyJ995zLuZ2SDip61xcW93VASOWcBGDhtb39kKcXjn2ssJAmRESPeCG0ade2FM+Jp6ZU3alzfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3HK+YdiwCdu7ev28roOGzZEE8BO1KlErcbHGyNuHSEg=; b=UljkMia+BN0MxpkOp9vITTKemUBACAYA6MOkSJPC+/286NKrzk2Qa6OPNHPk+8KRsEB1Y+ajZqTHa6vKNrxGEQfL4jSeAETPmN/CJOwj7gSPKBYxTnQhIov+EiBL55VF/gwl7md3CqwAmcUNtVxfOJ3JnDdUCOO9BnBs9rqJc/ta0+J9MU1wau6goprKOyWM9FVw5akZ0X+HHgYC9ZOCR84mwZvbuCi2EZUnuhFmtd1Niu/DLv43IgCPPIaihUzgH61gZbbkwbU2vrgezepySCnvPsZ21J2cI1R5RJGnXSQLrb7ZVUhQT5oUwiC0iA/9JBNURH0dfabORsy83uaMbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:15d::14) by TYWP286MB3856.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:43f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.16; Tue, 12 Sep 2023 13:42:31 +0000 Received: from TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM ([fe80::b012:385c:66ed:67bd]) by TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM ([fe80::b012:385c:66ed:67bd%6]) with mapi id 15.20.6792.015; Tue, 12 Sep 2023 13:42:31 +0000 To: Tom de Vries Cc: gdb-patches@sourceware.org, enze.li@gmx.com Subject: Re: [PATCH] gdb: Fix -Wuninitialied issue In-Reply-To: (Tom de Vries's message of "Tue, 12 Sep 2023 11:11:05 +0200") References: <423cffbf-7fa4-4c08-8cd3-15bf4ae72c9f@suse.de> Date: Tue, 12 Sep 2023 21:42:26 +0800 Message-ID: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TMN: [3Z+i7BoSAF6sjiVTd9qOFFOtlTq6LNeLYW8IPoc1DW0=] X-ClientProxiedBy: SL2P216CA0202.KORP216.PROD.OUTLOOK.COM (2603:1096:101:19::17) To TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:15d::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCP286MB2163:EE_|TYWP286MB3856:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d47b3d7-94c8-4443-41d2-08dbb3961c69 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Qzy+y4cVF+cjEactjpNsF13KKt2ppnPjk8BV6Gz0pL+8gk7AiIBhBFAuEsC5pzomPefs5T8miCB9h0GconcHX8205YTMwdD0Rl8wIl+aUkTlknIpwfqJOsZB9GhHqrLPPVi+w/NC1gP5AD1wlVkjI/egmkd87H422RTL9+gcjDww4McNHQ4XinQ3cB9Po/uAaJsnwwVlbKtIRIT74F/R43QETe8hTWBYMo0BNvpj+/+zlVAu0uHWUbvlqkO2rq41eyvj+QbQh4BymvfdVYo2FImKyGVYhj2wF7wGA9IESa22hUN4CQ/kV8Xgpkv85PBNQKISfWXKc3WtoW0Ku+UzyRmrm94MYtOu7zZYdS5vrQ8NJbf1o2VWLKPkdSnVxqFmLdpOrH1sB3HUPgu+k+K/UHhq/Jos8LBQCbU7B5YxVEKWvNxjXdJVcIETLe6J+fx8tKE2PUVh78BsVNK+3RngmGZvY4pUSE01cUNC9nqV9xLNfj0C4cOzFeBMVc+Z+ubjWogpUCt0WCvJgrC8jv6ilXGVfBnACa2bv4QAVObyh5foNiYB5PwlrbRho25vbV1a X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWV1RXBRWFFYN2JESmI5dGgwOTYvVXBrKzJUS01EZnh4QS9HRTVLQjZOdFpY?= =?utf-8?B?a2szclh6WVFPWnJyYW1jYVB6SGVmTjNjS2FZelZMTzE5YndjSE1LMUswRm5R?= =?utf-8?B?eW41NTdIM2tOQjdtOUgyU0daS2ZvNEc3RU92UnE2dHZ1QlE1Z1R6VjdkOFVC?= =?utf-8?B?b2J0OVA0NjBrOGV6QUpTaWxVa013WXNxcXVWVml2RzRRMmJlMjFKeUU4ejIr?= =?utf-8?B?a0d4QU54ckovTVJUTDZiSGg1SklyNUEwVFFib3g2QjJGY2QwdlB6cTdoNUJC?= =?utf-8?B?bEJ3blpJMSsrMTlpWXN6d09TYjBXUnFxUEk0VzFTaktNR1Iwa1lySHZ3RWMy?= =?utf-8?B?TjBQNE5paWhPendpRmpucWhiRzdGbU5lVVdlMjdKNGFkYmxPcjQ2T01XWlNh?= =?utf-8?B?amJqb1YrdTVzblVyQlVHSjczSU9HYWY3Sk1aK2EyempwelpTcnJWempBYWV0?= =?utf-8?B?NE0ybnYrTnJLUkhWd1V4TXNQYlg2WUkrdFNTVXZPWVFJM0V3bTlDWlV4K0Mz?= =?utf-8?B?NXpNVkV4dkk2d3pZMjlYa3Yvc1REL1N6clNuVmtsRDc1NEk2WVl6NFdPdVNI?= =?utf-8?B?OHZFUlM5S05aU0ZHVk5QY3Y3R0VsWTFkVFVKOVljeno2cDFwdWZNRUtqVHJD?= =?utf-8?B?ZDBTaHhLK1lHbDBhM1hWRmFubGZxVnZSSnlhYTFXZTg5STZDd0lUZ3pKd2xk?= =?utf-8?B?ajdzcmxMczNkU3RRd1UzWDBDWllnMDV0bkZZMzZ2aVNMclNMN1lrbmN5Wkw4?= =?utf-8?B?WWE5bXJDUldmc3Z5Z29oTlhKaGNmc2R5R3dNZVNrSWlWMlpOSlMrbEFncysv?= =?utf-8?B?a3R1SVVENUIwU25VTHJrR3FtNHBsNi9oQ1lwMUdsOHBENWNjT3I4ZktQU0hM?= =?utf-8?B?OE5QeldHbzJHL0FlUFVOenRIMjl3YWdZd2dLZy8vNTg4T3hqaU9uMFFaaGNX?= =?utf-8?B?bFJyNlhLbk1MSGVhZ25kc2E5UFBZTjZiblJhZWRDRWJEWDJYVjBHejRacEJG?= =?utf-8?B?bitLT0NlWE1BdHcweTIzVGNMendWSEhERWUxUm5FZkVjdUdxSzJLemlGTmUr?= =?utf-8?B?am9UT3JRQnJrdW9ZTi9qYkM5anVpWUF0bU5zSGMwdmxrWkF4aTZDQ20yMlF0?= =?utf-8?B?Z2V3M0srdUdxMEFmenhXd21Oc2U3SFZoNjhlSWxSQXNOY2JORFl2TE5YVzNk?= =?utf-8?B?SFpZTUlBUS9NWDIzR25UNUh4VStrS21mZ3lGZ3NFWEJzODV1SmZNRGpiQjJq?= =?utf-8?B?OXB3MTI2ZjlPdTMxYzZNVnUzcnJIUE5aTk05M2ZRM3h1ODVNNTdBeGV0T08z?= =?utf-8?B?cVppSWZNdVRsK0Fqc2NNd0ZrYTRPK3V1VmJ4aGRtNHU3eDV3UE9VekpTMkdP?= =?utf-8?B?amNyK0NZWGo5ZnpDbGVTclBZSGtaZ2RSb0tSVFEyUFZ5S0cvOUVIVE82Y3ho?= =?utf-8?B?bVY5bXN2U2xVbmgzbzNpcXZUZS9LN3hUMG5iTFh6ZDFLclEzbEtiZFhJUDd5?= =?utf-8?B?Y0tOV0MwTnIzNnJDYWRtQTQxV3kzVkJaMzNKRWg5N0RSVnI4UnNUM1p5RFZT?= =?utf-8?B?NjRZZERBWEFJV3I0SE5CM21TNUU0WXRZVkVDc01tYW5jVXBDK3cyaEZvT1Zo?= =?utf-8?B?RGkzdGIyVkJBZkl1RS9jOSsyV3hwYWc9PQ==?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5d47b3d7-94c8-4443-41d2-08dbb3961c69 X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 13:42:31.0907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWP286MB3856 X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Enze Li via Gdb-patches Reply-To: Enze Li Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, Sep 12 2023 at 11:11:05 AM +0200, Tom de Vries wrote: > On 9/12/23 11:09, Tom de Vries via Gdb-patches wrote: >> On 9/12/23 10:22, Enze Li wrote: >>> I see the following warning when building GDB on FreeBSD/amd64 with >>> Clang 14, >>> >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> =C2=A0=C2=A0 CXX=C2=A0=C2=A0=C2=A0 mdebugread.o >>> mdebugread.c:1069:3: error: variable 'f' is uninitialized when used >>> here [-Werror,-Wuninitialized] >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 f->set_loc_enumval (tsym.value); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ >>> mdebugread.c:836:17: note: initialize the variable 'f' to silence >>> this warning >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct field *f; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^ >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =3D nullptr >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> >>> after digging a little, I realized that we can not simply do what >>> Clang 14 says. >>> >>> The root cause of this issue is that we lost the initialization of >>> the variable 'f' in this commit, >>> >>> =C2=A0=C2=A0 commit 2774f2dad5f05e68771c07df6ab0fb23baa2118e >>> =C2=A0=C2=A0 Date:=C2=A0=C2=A0 Thu Aug 31 09:37:44 2023 +0200 >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 [gdb/symtab] Factor out type::{all= oc_fields,copy_fields} >>> >> Hi, >> thanks for fixing this.=C2=A0 I've reviewed my commit once more, and onl= y >> found the instance that this patch fixes. >> LGTM. >> Approved-By: Tom de Vries >>=20 > > Forgot to mention: before pushing, please fix the typo in $subject: > > Wuninitialied -> Wuninitialized. > Okey, fixed. I'm checking this in now. Best Regards, Enze > Thanks, > - Tom > >>> we have made these modifications, >>> >>> ---------------------------------------------------------------------- >>> --- a/gdb/mdebugread.c >>> +++ b/gdb/mdebugread.c >>> @@ -1034,9 +1034,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, >>> char *ext_sh, int bigend, >>> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t->set_code (type_code= ); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t->set_length (sh->val= ue); >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t->set_num_fields (nfields); >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 f =3D ((struct field *) TYPE_ALLO= C (t, nfields * sizeof >>> (struct field))); >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t->set_fields (f); >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t->alloc_fields (nfields, false); >>> ---------------------------------------------------------------------- >>> >>> The problem is that the variable 'f' is used in the second half of >>> parse_symbol, that's why Clang complained. >>> >>> To fix this issue we need to ensure that the varibale 'f' is >>> initialized.=C2=A0 Calling the fields method is an obvious way to fix t= his >>> issue. >>> >>> Tested on FreeBSD/amd64 by rebuilding. >>> --- >>> =C2=A0 gdb/mdebugread.c | 1 + >>> =C2=A0 1 file changed, 1 insertion(+) >>> >>> diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c >>> index ea3e15be53b2..9cb30ce0acd0 100644 >>> --- a/gdb/mdebugread.c >>> +++ b/gdb/mdebugread.c >>> @@ -1035,6 +1035,7 @@ parse_symbol (SYMR *sh, union aux_ext *ax, >>> char *ext_sh, int bigend, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t->set_code (type_code); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t->set_length (sh->value); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 t->alloc_fields (nfields); >>> +=C2=A0=C2=A0=C2=A0 f =3D t->fields(); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (type_code =3D=3D TYPE_CODE_ENUM) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 { >>> >>> base-commit: 318d3bda5cad124bd11eebb0349d0f183ba625b1 >>=20