From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BNgdDAyWxmK5rg0AWB0awg (envelope-from ) for ; Thu, 07 Jul 2022 04:15:08 -0400 Received: by simark.ca (Postfix, from userid 112) id 1EC721E22D; Thu, 7 Jul 2022 04:15:08 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=lCVNY2VJ; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 24E1A1E220 for ; Thu, 7 Jul 2022 04:15:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28DFD3856973 for ; Thu, 7 Jul 2022 08:15:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28DFD3856973 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1657181704; bh=Wv5KnfYUoSi3S1EcKVK/WHUpqicgK5bOlEuzzMiHUt0=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lCVNY2VJlhlK7axtuG6812Xq+I7GFXEBw71bryvy0H03rqSE0hgQqE4NKbFhw1mm0 dLSgUbTolKXrRTEFi4e0sIszBik2/p5GfRIPZEy73x4/va0VimrQA5NiDTMFt+U74T FGLYK690nHTv1IsHx7af4/C0bq1Bsz//mSnazntA= Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2053.outbound.protection.outlook.com [40.92.98.53]) by sourceware.org (Postfix) with ESMTPS id 2E50B3858D32 for ; Thu, 7 Jul 2022 08:14:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2E50B3858D32 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RNtL1de6Cuso+8Plc5W668EP3u80MN0Nl8MP1Z0UBRsg/nPtwI0n2KxnXcXsdGsRk7ka3TSzx5B62IH3Ut7VOy7rjfLxwqfwbING9TkaQ7F0aiW28s6ab0Rkb/WPMpb46oFeHmRN5VIsk4xVsEwd6m5kqTyU8gPUU0a+tavGgj7ZlRh4ZCQAzkspKtJeEGnwqvDm4V2uwHVGz1R6whcPDCgbkNBjvE61yk2KStu/CtocDtzSECeeLzGaHF4EgL4JwVVFMwitxwLRYB5P0NNsiVYYIMFsau/WBudTHf6SCBr5VlM5K89MIVAyWZ2fXgAD/t1KxIEAlKtTkKzjd6b0pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wv5KnfYUoSi3S1EcKVK/WHUpqicgK5bOlEuzzMiHUt0=; b=b/gF8UhpuQrSrpbB4LRF9/X7CR0NRof6e16tXQk+UJOwNmroGl3tYcrTrNWFREp+QcI+e02e4b28Z1YB+DHYpU9pxWfBMZE4o0LVdrbuRnBm0fiAzn7lB9gjy4O0PUpINwyyV5fW6eufYT6a/4zR8chkT2qAbaoLHGMg8Wo1mofLcTlyTtKYeUmJZ54Py49eChEBuW7WpWNtxv4avGzhOmw/NyUmrz5o1eLQteInd4HU3oc2GZtwd2Fet2eM1so7SGzyl2gM/8gszo0LWmEUiexzYweNmTJVSFohIDoHEJrD7RK+bCC66iCuujUSY0BxlSmNoppWh+PSQtFBmXcD/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:15d::14) by OS3P286MB2693.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:1fc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 08:14:40 +0000 Received: from TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM ([fe80::8e5:96b:ee37:9896]) by TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM ([fe80::8e5:96b:ee37:9896%2]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 08:14:40 +0000 Message-ID: Subject: Re: [PATCH][gdb/build] Handle deprecation of scm_install_gmp_memory_functions To: Tom de Vries , gdb-patches@sourceware.org Date: Thu, 07 Jul 2022 16:14:19 +0800 In-Reply-To: <20220707075809.GA16313@delia> References: <20220707075809.GA16313@delia> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 Content-Transfer-Encoding: 7bit X-TMN: [86b3HS+5bntbNFoh/sljuxCZMk4I73FTmyt1MOKoAcSggzpJ6GJYxtQSZvJ+SwVLdsbvFOq3rCg=] X-ClientProxiedBy: SI2PR01CA0001.apcprd01.prod.exchangelabs.com (2603:1096:4:191::13) To TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:15d::14) X-Microsoft-Original-Message-ID: <269b739db8f5b1cf69d6efbb3b4706d744ae0c02.camel@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cd6268f-7e61-4624-9c38-08da5ff0bd9b X-MS-TrafficTypeDiagnostic: OS3P286MB2693:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AYN+ccp1uHngYpyQyRQS0B0wxqOoMPElOhJelNSQrmjgqw8VcNEbLg/rsmQ1DmSo4QkVuqV3ozrCqxjXE58/QC+YZ1ueRQBNT+uxq1D85ONG5v4lPIdyEDn2IrIWA7PrUG8Vu9Gi1EWoJRywvoJoqxcCRTTJaEolbcvg93VvcIDEdTItwWx8kbVXhZau0EhmhbvmHk2yzGez5OjKm9+UmLrikhaHznTBXZTk5Urt9y8BYratxUPG206By3B092HluNmuYQnwk3VsUHawWbxaMMy8NhyamF54ofCvF6CAdtCTqYXrp0ca7XgBe2qfurx9Auy2sew7nkTSWpYG7riO5YZ/4batJuOTJfzKHTExhcBS30NbA3M0jlI2hIn8AaRN3tMsXHIFp7x+fFhF6Yui2hHTe5a98xcSP9rnSLMoEzLKcOaJPQHdslCX+s3rp3g9E7hMDrhaeKs2bPy56znrlkWsnTMD5iidH/ee6K9lLfvF/+rUA5JekTzKH/Xn0/zBU2iWZDdVERHgIuDQbqy80nh9pIS1DkYGvSvReGPYckUR5EI/d0O7kQlYCmlgoEuWwTkl7H/db32yJPiHfEh3UW0YtDJmmt2ZjHSVnYvan6Ce7I4YASRwpDxuD4xkLapgFjXsONPyvb1TsbxQDoOixDJEfNNHNeHQBG1qb8XsLf8QaePbTZsLOz4gKjebZd989rITYJsy+L9wHIFRHlUz9oPQrH6DRcps2jqJck7+cNU= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Skl2L2FxcDBXcGdwUFJYSkp6V2VaSzVybERVbENhYUR1TzN6UkVoaWY1QUl0?= =?utf-8?B?Z2c4b3RDUUpBbkVlQ0VtTU14M1l0WnhkVExON1M4Ujhja2lqUzZOU0lYMllS?= =?utf-8?B?Nkd1Sk54QThTd0xhWFpXd1RnZ3hGUk9GZS8zMFh1MmlhUUQ3dWpWL3grL0ox?= =?utf-8?B?aFczcWhzd2pWdDNqQUZTY2R5U2llNkpDK3lTZU5ZdXJ3YzVVSDN2MEJ5bG55?= =?utf-8?B?YjVQeVU2SEQrMVhvRzFxeDN4VEoxdGM4WkZqSEZadDNMUk1oZmw5dEl6V1gz?= =?utf-8?B?Y091dlliZ3YzSWJwUmthRytVUStCYThBR3RubC9tL2lxa1BhU25ocCtxK2Za?= =?utf-8?B?bGY4U0pHbmRQSUlhVWR4WXBLeDlvKzNrd2MrV240bXBpQWRJVWpxUW9tRzNV?= =?utf-8?B?ejhLeFA0WE5jMTgyaU51VmdWK0RTcy8xRUswTU9yRStUcXA4dlpjdHg1emdr?= =?utf-8?B?cHpUS05Xcm5SSll5THp0QWd4WWw5MThaeUtHZ1Q1TS82TzlMV3BTUFByamhQ?= =?utf-8?B?MVIrcHZOUHVXUUY3ZW1vcHl5aGlBQXBVRlVIaWJiZHVEYTl3N1h4bC8xTHJn?= =?utf-8?B?VWJ6MzJZRFAwRDk0bW5tNjhVV1UzVUpDRTJla1VOWjBFaTdiZjVpT3MxMG5x?= =?utf-8?B?cE9VaC9KQVdySmpacXJlWkdUTEROcUxrZ3dMbE5zRXlCRkZUT1VCMmt0emtB?= =?utf-8?B?d3VDRnJpblJiZUY5VGZhT1NtbDdrRW1DSnFDM3BPajF2WkFnK3p3bGVEdW8v?= =?utf-8?B?aVZGNHQvYU1kbHNVQnlEUXYrWVlza00yUkp3UXBNZnNiaHFLaHhIZ2Vmb2Nt?= =?utf-8?B?dytDcm9Vam5tS2hubC8vb3N0dFArM1FkYzRtbmQ3b0Mzd1M3TkpiditVWFkx?= =?utf-8?B?VldWaUtvUHlJdGxZOVBaczlvc3ArQ0tmZmc3UkVUNFkyMlljc3NNaVkreGxj?= =?utf-8?B?VkpUSVlPWFlOcnBHZURKZTlkdEhQUVpQYlB5NWtsS0o3QmpaMFlUMnRGZEJT?= =?utf-8?B?blFGSGE2NHRGSkw2ZDVwYUpZeFZHTERPVW1LZ1RHcy90WEV3dHVsSVhwNUx6?= =?utf-8?B?VFh4MUxrNU1nNDJHUEk3ZlFNUHh6ZFE0RWVPNmlNU1N0eWI0LzJqUS80ait0?= =?utf-8?B?YWRzT0FkcTlwdmdmUnRhS1hpWWJtZitGQm8wVmI4WXp1OXZJVStHaGxJc3RV?= =?utf-8?B?eFZiR3RJZlBBWjFRVWQra1NLRFpFSkNNQzFKQzFHRE5OUjNGRnZPSHROQzFB?= =?utf-8?B?VGE2YkNpVGUwQnRDZSt5d3lmZ3lSZGloamZ4S2NITDR4VHFEWEZ0RjVRR21t?= =?utf-8?B?R2txS2ZYZkVHRVdkUzNzMVNDb2RPMGdQbTEyRllyWjJXaFM5d0JEMGRCNmdO?= =?utf-8?B?VWc5MlR2OVpBR3hsaE9RWmxRcHlTN3RNNVhVQlVPQnZKeU9kcEVNdzhMZ3ps?= =?utf-8?B?MkR0ZWhBWVlxaTIydkdja0N6VEFudHFvRDV3MHFTMHptLzFsWE9aUEt0d2oz?= =?utf-8?B?eU10b3J1Y0pKdkEyS3MzZmVkUU9IRittczlzbENOMlJES0tsYXhpeWI1Qm9E?= =?utf-8?B?Q3hHU1oxN1Q3RW5OWGNDYjBrd25VY0pvSGVLRWhURGhLZk0xQTc5NzdreXNr?= =?utf-8?B?YTlscHVkMExxcU96VU14RnNmc0ZSYUVoK0hXRW9kcStEdkI4ZStHK2dRQVRW?= =?utf-8?B?N1RrK09TY0g0ZmNpejc4WE5rdk5MS1pmdTh3bDRDVE1meDBMMTk4WGtldmx3?= =?utf-8?B?US8yYkV2aHhTdUVMOXRod2FWMjZsTHVUM01jL2xKWGNxZ1pLcE90cGg0ZFU0?= =?utf-8?B?cGlQMzJKeVRRVGlVMmY1dz09?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd6268f-7e61-4624-9c38-08da5ff0bd9b X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB2163.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 08:14:40.7508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3P286MB2693 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Enze Li via Gdb-patches Reply-To: Enze Li Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Tom, Thanks for doing this. :) On Thu, 2022-07-07 at 09:58 +0200, Tom de Vries via Gdb-patches wrote: > Hi, > > When building gdb with guile 3.0.8, we run into: > ... > gdb/guile/guile.c: In function \ > 'void gdbscm_initialize(const extension_language_defn*)': > <...> > > Tested on x86_64-linux. > > Co-Authored-By: Tom de Vries ^^^^^^^^^^^^^^ This part confused me. Is it necessary to include such a line when the author of the patch is the same person? Thanks, Enze > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28994 > > Any comments? > > Thanks, > - Tom > > [gdb/build] Handle deprecation of scm_install_gmp_memory_functions > > --- > gdb/guile/guile.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/gdb/guile/guile.c b/gdb/guile/guile.c > index 14b191ded62..e5565b627d9 100644 > --- a/gdb/guile/guile.c > +++ b/gdb/guile/guile.c > @@ -677,7 +677,17 @@ gdbscm_initialize (const struct > extension_language_defn *extlang) > "double free or corruption (out)" error. > Work around the libguile bug by disabling the installation of > the > libgmp memory functions by guile initialization. */ > + > + /* The scm_install_gmp_memory_functions variable should be > removed after > + version 3.0, so limit usage to 3.0 and before. */ > +#if SCM_MAJOR_VERSION < 3 || (SCM_MAJOR_VERSION == 3 && > SCM_MINOR_VERSION == 0) > + /* This variable is deprecated in Guile 3.0.8 and later but > remains > + available in the whole 3.0 series. */ > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Wdeprecated-declarations" > scm_install_gmp_memory_functions = 0; > +#pragma GCC diagnostic pop > +#endif > > /* scm_with_guile is the most portable way to initialize > Guile. Plus > we need to initialize the Guile support while in Guile mode > (e.g.,