From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 00TIK1GspGe2MyYAWB0awg (envelope-from ) for ; Thu, 06 Feb 2025 07:34:25 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=KwDAupYg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A63F21E105; Thu, 6 Feb 2025 07:34:25 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 59A761E05C for ; Thu, 6 Feb 2025 07:34:24 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE9B1385840D for ; Thu, 6 Feb 2025 12:34:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE9B1385840D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=KwDAupYg Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by sourceware.org (Postfix) with ESMTPS id F1A9B3858CD1 for ; Thu, 6 Feb 2025 12:33:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1A9B3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1A9B3858CD1 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.198.163.12 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1738845224; cv=fail; b=lZRu9fkr8yrvOEON3q9SIsngwNtLkK1Ri7ahPl+g/E4LRPAPjatayjYgC+oGgta0x1jNT6BCNigrERK0VUno5BvVLGFPVdR7cFC8aOHX32f0oMMcrPVD95B4y/b7AurSqFtmb5Az/v439L3H+AoVkPzrb0EGQXhVp/8sTB/G7NY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1738845224; c=relaxed/simple; bh=ff5XDjUc5sGKzizyWlpyKGN/LM40ycddnN8Y1nPEveo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=NVV43G2W5aU2xcXMt0u+75FeHjp5chLCaFu0huUH8JZs6kqEzkbZH57ggtMRTPG+o+vR6lfbNUTK0CqwEvg72Vd7GKCea+lK7DkWKN0nHXq4OajE+sK5E9EwRi0GbvqUvmW/lkvmZrexRzXbev8Zf6cs1izNZh5e8wfhXZ2BG5k= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F1A9B3858CD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738845224; x=1770381224; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=ff5XDjUc5sGKzizyWlpyKGN/LM40ycddnN8Y1nPEveo=; b=KwDAupYgdJK0OQqaijoSMcqU9U7gzfTlpPZhZLBsZKYosL8oVB0H1cJl zXR2ED3qA8YpivdcyGZOYeSNiylCLf41UvAzz5WzcP89cVxPa+iovkLbg GFRgS6uGm+BF3dwuhun0FiHyw9o78rS/Yh6q/RooP7xkA9nl3Ya0a5LHV 7VC/TaYaZ/+bed3cTiFatyP9CNuIzSKa0LHYIRdiVTUQwCD23epjfIydX lWHnZOutU7+8L4pF/6oolAPaJhrXjarXH15eVNtKwMn5uYgDYbJ+exbRz HDhNqGpsMe208qLh0FyDtkj2UQBrohLo70bwfUQS9j+SB5nHMS2fiHOCC A==; X-CSE-ConnectionGUID: +jHWwjP5Qtq8kAdfNMBtpQ== X-CSE-MsgGUID: 5LIcNlrpRzuCBc9MH9vH5g== X-IronPort-AV: E=McAfee;i="6700,10204,11336"; a="43369143" X-IronPort-AV: E=Sophos;i="6.13,264,1732608000"; d="scan'208";a="43369143" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2025 04:33:19 -0800 X-CSE-ConnectionGUID: nkWCBhMVRQ6BLx1hS0paeg== X-CSE-MsgGUID: CJRqWmp+RNedxmsoLAFBwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="111049074" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Feb 2025 04:33:19 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 6 Feb 2025 04:33:19 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 6 Feb 2025 04:33:19 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 6 Feb 2025 04:33:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xNkr7TmKOmpyOi8TInwJ6CFcZ5Hs7EJ324w4zss8vQP0uQWgvUU65qSQ731k4HaWhpWKpBOviZa2ZA0vjvZ2y99CuoYJEfRzMZZUQMEIO6/aCI1JIlBNkKxLHbmpcBM+/C/8n0M5u02+j7PdRDZ9KwxjyL5/EZhLP2tuNdYomrJf0DCYywXjwT7/xahr2VX6njFwWT3Rk4WywC0589glu0k1nVkjo1fFHTB8S34zvHserQkpXU03uSpSbPN4KzD0fZ0x64f8niy3HOXXHuKhwUyyN3dLhHdEnDLGKECfeB+tfPmNWsI40BNFHQmlMdPH2H6k1YXluWnOe81vgYE/Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pZeFbJm3ZHdYZz6uoYqDI8H2S2kosQgJZWWHAeDJ8YU=; b=V1735lu0IFVKafdKem37AIgjNpZ6SfWuvd6YYlvcf4+uXwwBUUGNxtwI9frmLewbLWVJj9g+cRQOfC8GwxZnPbWF1Cno2YsvrBY76ULv77ykMdSDyZFewKbdxXkN+BHpmkl2xnmgdi6UKesxJBqeAWmP5FNn6YUe/N+AmMzHCtN94Sakxm9+Kr690lIj6Sf8TsLlN1/UAYS+I6xtw+lYgqNZNj/UL6cKsFxVODAphva8hNQzHZnzWaHhP8og7STIoD0D43xg1E8XHXKQxW2CaV957k1j7nM3udyRQ/hIEkjP+6JUW2c7QGV+4kwrv02z2tYzbJ2xm9qifKTVWkHmOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7638.namprd11.prod.outlook.com (2603:10b6:806:34b::22) by DM6PR11MB4722.namprd11.prod.outlook.com (2603:10b6:5:2a7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.12; Thu, 6 Feb 2025 12:33:14 +0000 Received: from SN7PR11MB7638.namprd11.prod.outlook.com ([fe80::25b8:16dc:755e:34d1]) by SN7PR11MB7638.namprd11.prod.outlook.com ([fe80::25b8:16dc:755e:34d1%4]) with mapi id 15.20.8398.021; Thu, 6 Feb 2025 12:33:14 +0000 From: "Schimpe, Christina" To: Thiago Jung Bauermann CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 05/12] gdb, gdbserver: Use xstate_bv for target description creation on x86. Thread-Topic: [PATCH 05/12] gdb, gdbserver: Use xstate_bv for target description creation on x86. Thread-Index: AQHbUxupn2GJm5G7GkCTlBR+JFxYTbM54vqhgACb1yA= Date: Thu, 6 Feb 2025 12:33:14 +0000 Message-ID: References: <20241220200501.324191-1-christina.schimpe@intel.com> <20241220200501.324191-6-christina.schimpe@intel.com> <87bjvfixah.fsf@linaro.org> In-Reply-To: <87bjvfixah.fsf@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7638:EE_|DM6PR11MB4722:EE_ x-ms-office365-filtering-correlation-id: 5161b804-0fc0-4c49-e326-08dd46aa6d23 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?3Bj54340vnGhrm/rN4lsqdE7LdU3AMWgBMACoSEaEQPRRdQaXw9KldyNNO0d?= =?us-ascii?Q?6urOyvhLx2XJka+WCrH4Wtp5vFFHk9BZdz1Jlur4ZeZbr3HGSx/k25ewys14?= =?us-ascii?Q?T8VQk41fPF17NHC970tsA2kDEfs4G2z+bLAXxdTeitiRqRNQqD9k/d6RbQYE?= =?us-ascii?Q?qIsuM5kw8evmTnFoTUUDKFSYraU7BLouWEW8itu5SPVA3ewqM3WxK38O0LXX?= =?us-ascii?Q?wTUriBeKm78n3GiZCosm7e3iZSHtn55yGFiye07McGVVFlZK+zU31Yjomx0v?= =?us-ascii?Q?Q1DTn0cjJx1e6O3RUjil3Bp1LicSbSx9WSSNNZFQ7Vis0uh5mOcVbFNY5mEP?= =?us-ascii?Q?tVqXCodJydck1RWYMbvenjXUB5Et9kPLLRQf0ii3vjX/SduPv+NOSGpuZIGm?= =?us-ascii?Q?dywJwoevbb2X/VZl8IT3Mk+uuaZhTBGoIslekJcxUY5KiNlH9TW9IWy8RJPF?= =?us-ascii?Q?vufdeAv8oSmPlsVOvejPdyH5qNqLJhaiyiT9uQbrLSnYPpbjT/6eod2LeJF6?= =?us-ascii?Q?sJtA9RuD8y4jKY14mnyBkNABZtk99fqfqaF/b0cZlziTYYNxor7DHBRFRHlA?= =?us-ascii?Q?bAlvYXUXQG71LPFvyz+YJKtbh8DvZaNOAW/pIotm+zQDJ9oxA1ndnsWvgMlt?= =?us-ascii?Q?Etu1VR0/LjW9Yt/S3ErX9EgvNVVe5GiDPj6mg68vs95OCXSVmiIxN7Fq6mRn?= =?us-ascii?Q?IJnY4Y2cgf0NiJHWQ5oKs4xEXfkN741yBU9ElUxesYN/Ipisr/zqAbGt15S+?= =?us-ascii?Q?pfkdfHVd3tmiMHWKIKk0kDapagkfGb6f/FK6RuwqFdkmR4FJeoUrx+VCVYwq?= =?us-ascii?Q?gK4jaXwJyvQUSnzklCp+WFqoYkUzf+RAQ/12/X/WIW0IQA0PplFTHlyzs7vD?= =?us-ascii?Q?KAWZOjQc57KpimxfT/OeMExwWap6FbJ+I0QvMfGafQSPpoiXU3KxwX/Jg2BB?= =?us-ascii?Q?Q/MVfsVKQxeZq4A0ksTjbdvP9zV8kTME1ypdrvEHJl0ZzYnoEFPVETAkYwho?= =?us-ascii?Q?NGq3zBDSAtcVFAmv34yCvdcn37I43DbavdSAKB0+YgPPr75KhxcS/7PdG6uL?= =?us-ascii?Q?jxg67vg65dha6UzRsf0roFeRMfBiAExJxoWD7Udy+8y8wswcnphaR577lQW2?= =?us-ascii?Q?tM3zBRwOZdcY+sru7btWPnnewvbm0kW+i3iR79ro1hD4qgcNBDUmR65lIfUz?= =?us-ascii?Q?pdMSSTyauyXRn5wvcrXsEUomZcHyk2IzsR8l9OeibaY1atkt2E2ZXbxMMxVT?= =?us-ascii?Q?3lrsBUM6mvHdlWI8vlJbwexvwBtv8I7jKJQBecbOL0bxJvP61mXoO1QaGQXO?= =?us-ascii?Q?hka4mKXHJVkef1msRCZNtU9PeGpY2WvPQpH+B66rMq6tKovxhwUmlAUhInuc?= =?us-ascii?Q?seeHR+5rKWBOM0urFdt3U9bEWjlNDL4HRkNyvwk4j2P3XWySupIH8xk5BWDO?= =?us-ascii?Q?V5FtdwxXJEhHjuOQ/kDTN1OT/J30587C?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7638.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?S6H7+2Cs6+wnYit06xU22ek2/Oyy46YLWjTjB9DEFTy5N+nu9z79gudCRKG1?= =?us-ascii?Q?GAx0ErLSIIrrtfZ2/gkTb7T7BNvZFEzU6Y+6MX8izUN1YUtPZD/cINZjcDfM?= =?us-ascii?Q?XjzVw3cqbtz/qlHOoZXVPCJ3eYa6c8F1j4oHD9K3b9wuI+2Ej9hC9pnWzwn1?= =?us-ascii?Q?cSeSLg6q/bv9JwNDs53Gk1jKjlOU9OVBwJM+hOcPZGutzjxSIh6Pz3xZXJ1c?= =?us-ascii?Q?NbbsZGfDUiiJx8lpHlRxtA+k0W25R68zhCABHbBd7tkfQbdIE1RCF8ZVBrY+?= =?us-ascii?Q?LBTOS64yuHcS6wkaGTdSVzm9jszOFaocSJ0ZQVTkaLUGNYiN+HEb22zNky3k?= =?us-ascii?Q?TGlepJwDEczlnIpGmPq1FQFMYX1av5tZaSH3Yf+ymUVmNT1GQU2HKBwnN8dq?= =?us-ascii?Q?ZaBoeRhVED1BGz4n88fzRmgn16zur/uqBlEdHzTEJRIZzU3uTGdvP+ETuNLk?= =?us-ascii?Q?ppFLlOdyCje5u7x81MPv41hF929lKyHYGRunCPNPGsvSX81SNE15ZiTiSxoc?= =?us-ascii?Q?EKW+fZckuxJYZKkdElKwvIsj/u69z0lx/WFJAqJ3eI3OmRIoqk5Sqmnf6ge5?= =?us-ascii?Q?IfBtIPsnJxcEFudQtPDzk/s0cNp+tmyB06THdkXSVYgg1LNda9WCxmRYguJY?= =?us-ascii?Q?6beFiuLF6Sqjwt0slaKk1Q1iOX3Hr+l4mVPpsyvOU7hUCUvwDc6HDM9Qo6XC?= =?us-ascii?Q?B7Q7Hz/hRSEsXiiJJTduUfJhLmOtRmkjRJ4eX09ojcvCfbe/53tP+UefxSGM?= =?us-ascii?Q?1QfPuj69i6zbMwf1N/ndqCzHCpoGtrV4EzC895y0xe92b89xyVtplsPwfUi/?= =?us-ascii?Q?gQnWNlUGvDsadqY90AQhY52Vkez8h63auBtO3cciuy3UiKx9ETOOrNiNBdO0?= =?us-ascii?Q?NQXsP3QV1GfOKlpJu+9kUaxbGxgFVsdeeP3lVlUvLTDQl4u/uA3aucCrPygY?= =?us-ascii?Q?QG4WKtDgi0ZRPkSCq4eQ1USPY2D63XDW/2zvaBpQM8lDZAXmDTNH3BIqHDqc?= =?us-ascii?Q?Y94qisI57/O+KP741rAydYeYoaE5NkSFopyF8M9d0TmJKIynhUH0B3N98Vwi?= =?us-ascii?Q?vPJBJEXdMNGdGmi13YWwJnqiO6wbFTeJb+2ziIsZTZ40VUFOh23gi/VW+FTH?= =?us-ascii?Q?lDfcUk5Zxs16qq0pQfXUeuliZyCXjaWmRRV+dkoK0J8EWaQMaiqWOrAtK578?= =?us-ascii?Q?Y5G5bjgBIrABqEMeKdkk6jc93OKxowbKfizjo8oWcBpXruVV96SjNPtdEuIM?= =?us-ascii?Q?PZ0dn36bfmrTIOn5Q894FZPbchtLJE6Y5M12kU3Gn/lxwqS6xAyH0Hpt4Mns?= =?us-ascii?Q?Xp8W/HtA4LLppuCp9mpcaSslUIQx/3GsdNREI2qf7L8lkER+z0KJBm10qEi5?= =?us-ascii?Q?A8U4qqsQcbD7xBRX0sZ2QS/yEwpTDE9Qg1ee10we7p6Pf0Pd1arKyAALfEZ7?= =?us-ascii?Q?urs0WJZsn+tjucQ9jhMwEKkNOalr5Z4WSA94yc0WWdL68Tj8NO/qPvdx48dc?= =?us-ascii?Q?PZQiE7HWMcTdiJdc3HMuJvMkjtoMIeStrxaHS7kRb4GoJM+9BWeBUqrxD5ZM?= =?us-ascii?Q?8Dd1h2bqMJSBbiVqotJ2OZuHBnLIymFFBBoyUz2iyGevNFLnVQQ6qhQi2Y7F?= =?us-ascii?Q?Ow=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7638.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5161b804-0fc0-4c49-e326-08dd46aa6d23 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2025 12:33:14.5579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lZYaml/6hwnwIS2Sl4Pi5eqLarNZGstNao1lyLf3IZJooEXv6CEA/L7RDBxSMcgA8BY2tDYCcNA5j/D65/fTqM9O0SG8MLbAvyAZBbI9qtU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4722 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Thiago, Please see my comments below. > -----Original Message----- > From: Thiago Jung Bauermann > Sent: Thursday, February 6, 2025 4:10 AM > To: Schimpe, Christina > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH 05/12] gdb, gdbserver: Use xstate_bv for target descr= iption > creation on x86. > = > = > "Schimpe, Christina" writes: > = > > The XSAVE features set is organized in state components, which are a > > set of or parts of registers. So-called XSAVE-supported features are > > organized using state-component bitmaps, each bit corresonding to a > = > Typo: "corresponding" Will fix. > > single state component. > > > > The SDM uses the term xstate_bv for a state-component bitmap, which is > > defined as XCR0 | IA32_XSS. The control register XCR0 only contains a > > state-component bitmap that specifies user state components, while > > IA32_XSS contains a state-component bitmap that specifies supervisor st= ate > components. > > > > Until now, XCR0 is used as input for target description creation in GDB. > > However, a following patch will add userspace support for the CET > > shadow stack feature by Intel. The CET state is configured in > > IA32_XSS and consists of 2 state components: > > - State component 11 used for the 2 MSRs controlling user-mode > > functionality for CET (CET_U state) > > - State component 12 used for the 3 MSRs containing shadow-stack pointe= rs > > for privilege levels 0-2 (CET_S state). > > > > Reading the CET shadow stack pointer register on linux requires a > > separate ptrace call using NT_X86_SHSTK. To pass the CET shadow stack > > enablement state we would like to pass the xstate_bv value instead of > > xcr0 for target description creation. To prepare for that, we rename > > the xcr0 mask values for target description creation to xstate_bv. > > However, this patch doesn't add any functional changes in GDB. > > > > Future states specified in IA32_XSS such as CET will create a combined > > xstate_bv_mask including xcr0 register value and its corresponding bit > > in the state component bitmap. This combined mask will then be used > > to create the target descriptions. > > --- > > gdb/amd64-tdep.c | 14 ++++---- > > gdb/amd64-tdep.h | 8 +++-- > > gdb/arch/amd64-linux-tdesc.c | 33 ++++++++--------- > > gdb/arch/amd64-linux-tdesc.h | 7 ++-- > > gdb/arch/amd64.c | 15 ++++---- > > gdb/arch/amd64.h | 10 ++++-- > > gdb/arch/i386-linux-tdesc.c | 29 ++++++++------- > > gdb/arch/i386-linux-tdesc.h | 5 +-- > > gdb/arch/i386.c | 15 ++++---- > > gdb/arch/i386.h | 8 ++++- > > gdb/arch/x86-linux-tdesc-features.c | 55 > > +++++++++++++++-------------- gdb/arch/x86-linux-tdesc-features.h | 25 > +++++++------ > > gdb/i386-tdep.c | 14 ++++---- > > gdb/i386-tdep.h | 7 ++-- > > gdb/nat/x86-linux-tdesc.c | 18 +++++----- > > gdb/nat/x86-linux-tdesc.h | 7 ++-- > > gdb/x86-linux-nat.c | 11 ++++-- > > gdbserver/i387-fp.cc | 40 ++++++++++----------- > > gdbserver/linux-amd64-ipa.cc | 10 +++--- > > gdbserver/linux-i386-ipa.cc | 6 ++-- > > gdbserver/linux-x86-low.cc | 9 +++-- > > gdbsupport/x86-xstate.h | 4 ++- > > 22 files changed, 196 insertions(+), 154 deletions(-) > = > Just some minor suggestions in comments. > = > Reviewed-by: Thiago Jung Bauermann > = > > diff --git a/gdb/arch/x86-linux-tdesc-features.c > > b/gdb/arch/x86-linux-tdesc-features.c > > index f6eb112f312..3f041ece6eb 100644 > > --- a/gdb/arch/x86-linux-tdesc-features.c > > +++ b/gdb/arch/x86-linux-tdesc-features.c > > @@ -28,18 +28,21 @@ > > > > We want to cache target descriptions, and this is currently done in > > three separate caches, one each for i386, amd64, and x32. Addition= ally, > > - the caching we're discussing here is Linux only, and for Linux, the= only > > - thing that has an impact on target description creation is the xcr0 > > - value. > > + the caching we're discussing here is Linux only. Currently for > > + linux, > = > Nit: "Linux" Will fix. > > + the only thing that has an impact on target description creation are > > + the supported features in xsave which are modelled by a xstate_bv_m= ask > > + value, which has the same format than the state component bitmap. > > > > In order to ensure the cache functions correctly we need to filter > > out > = > I think this should read "filter" rather than "filter out". I understand = the latter to > mean that xstate_bv_mask feature bits that are relevant should be ignored= , which > isn't what the code does. I think you are right. I could even make it a separate generic patch since "to filter out" was use= d = before already. But I think it's also ok, to just fix it with that patch. > > @@ -51,11 +54,13 @@ extern int x86_linux_amd64_tdesc_count (); extern > > int x86_linux_x32_tdesc_count (); extern int > > x86_linux_i386_tdesc_count (); > > > > -/* Convert an index number (as returned from x86_linux_xcr0_to_tdesc_i= dx) > > - into an xcr0 value which can then be used to create a target > > - description. */ > > +/* Convert an index number (as returned from > > + x86_linux_xstate_bv_mask_to_tdesc_idx) into an xstate_bv_mask > > + value which can then be used to create a target description. > > + The return mask same format than the state component bitmap and > > +does > = > Missing words: "The return mask has the same format ..." Will fix this and all your comments above for the next version. = Also I'll add your Reviewed-by tag. Thanks! Christina Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928