Re: [PATCH 1/1] testsuite: add unsupported in case OS corefile is not found

Luis
2025-08-18T22:54:23Z

Hi Christina,

On 8/11/25 12:44, Christina Schimpe wrote:
> Even though the core_find proc will log a warning, it's better to log
> "unsupported" and then terminate the test. This will help to avoid

Did you mean untested here instead of unsupported, based on the code below?

> silently skipped tests, when running the testsuite. Most of the tests
> already do that. This patch adds the missing ones.
> ---
> gdb/testsuite/gdb.base/corefile.exp | 1 +
> gdb/testsuite/gdb.base/corefile2.exp | 1 +
> gdb/testsuite/gdb.base/corefile3.exp | 1 +
> gdb/testsuite/gdb.base/many-headers.exp | 1 +
> gdb/testsuite/gdb.mi/mi-corefile.exp | 1 +
> gdb/testsuite/gdb.threads/corethreads.exp | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.base/corefile.exp b/gdb/testsuite/gdb.base/corefile.exp
> index da1fdf3517c..fd8d1d1274c 100644
> --- a/gdb/testsuite/gdb.base/corefile.exp
> +++ b/gdb/testsuite/gdb.base/corefile.exp
> @@ -31,6 +31,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
> # mmapped data in core file" test.
> set corefile [core_find $binfile {}]
> if {$corefile == ""} {
> + untested "unable to create or find corefile"
> return 0
> }
>
> diff --git a/gdb/testsuite/gdb.base/corefile2.exp b/gdb/testsuite/gdb.base/corefile2.exp
> index 392705b5930..d35ba1a1295 100644
> --- a/gdb/testsuite/gdb.base/corefile2.exp
> +++ b/gdb/testsuite/gdb.base/corefile2.exp
> @@ -40,6 +40,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
>
> set corefile [core_find $binfile {}]
> if {$corefile == ""} {
> + untested "unable to create or find corefile"
> return 0
> }
>
> diff --git a/gdb/testsuite/gdb.base/corefile3.exp b/gdb/testsuite/gdb.base/corefile3.exp
> index 57b230004b6..ef391d15049 100644
> --- a/gdb/testsuite/gdb.base/corefile3.exp
> +++ b/gdb/testsuite/gdb.base/corefile3.exp
> @@ -34,6 +34,7 @@ if {[build_executable $testfile.exp $testfile $srcfile] == -1} {
>
> set corefile [core_find $binfile {}]
> if {$corefile == ""} {
> + untested "unable to create or find corefile"
> return
> }
>
> diff --git a/gdb/testsuite/gdb.base/many-headers.exp b/gdb/testsuite/gdb.base/many-headers.exp
> index f46b9800cf9..5e022da8534 100644
> --- a/gdb/testsuite/gdb.base/many-headers.exp
> +++ b/gdb/testsuite/gdb.base/many-headers.exp
> @@ -33,6 +33,7 @@ if {[build_executable "failed to prepare" $testfile $srcfile debug]} {
> # Generate core file.
> set corefile [core_find $binfile]
> if {$corefile == ""} {
> + untested "unable to create or find corefile"
> return 0
> }
>
> diff --git a/gdb/testsuite/gdb.mi/mi-corefile.exp b/gdb/testsuite/gdb.mi/mi-corefile.exp
> index 3f0e7202330..b4914866dfc 100644
> --- a/gdb/testsuite/gdb.mi/mi-corefile.exp
> +++ b/gdb/testsuite/gdb.mi/mi-corefile.exp
> @@ -29,6 +29,7 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
>
> set corefile [core_find $binfile {}]
> if {$corefile == ""} {
> + untested "unable to create or find corefile"
> return 0
> }
>
> diff --git a/gdb/testsuite/gdb.threads/corethreads.exp b/gdb/testsuite/gdb.threads/corethreads.exp
> index 3b50ae3a3cd..0011dc3547c 100644
> --- a/gdb/testsuite/gdb.threads/corethreads.exp
> +++ b/gdb/testsuite/gdb.threads/corethreads.exp
> @@ -29,6 +29,7 @@ if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executa
>
> set corefile [core_find $binfile]
> if {$corefile == ""} {
> + untested "unable to create or find corefile"
> return 0
> }
>