RE: [PATCH v2 1/9] gdb: Generalize handling of the shadow stack pointer.

Schimpe, Christina
2026-04-10T07:55:17Z

> -----Original Message-----
> From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
> Sent: Freitag, 10. April 2026 07:03
> To: Schimpe, Christina <christina.schimpe@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH v2 1/9] gdb: Generalize handling of the shadow stack
> pointer.
>
> Hello Christina,
>
> "Schimpe, Christina" <christina.schimpe@intel.com> writes:
>
> > Thank you for sharing the patch and the review.
> >
> > I wonder if we should we split this commit into 2 separate ones:
> > #1 "aarch64: Implement gdbarch function
> top_addr_empty_shadow_stack."
> > #2 "gdb: Generalize handling of the shadow stack pointer."
> >
> > This way you could be the author of patch #2, and I'll add my self as
> > co-author since I'll also move my changes from aarch64-linux-tdep.c into
> this patch.
> >
> > With the commit "gdb: Generalize handling.." only, the GCS unwinding
> > logic is still functional and will be generalized in the aarch64 specific patch.
> >
> > I'll also include the patch in my v3 then.
> >
> > What do you think?
>
> I don't mind the patch the way it is now, but if you think splitting is better,
> that sounds good to me too.
>
> As you mention, the main thing is to keep existing functionality working
> between each patch to help with bisection.
>
> --
> Thiago

Thank you for the quick feedback. I'll split it then. 😊

Christina
Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928