From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oJezD6NUm2eqRh8AWB0awg (envelope-from ) for ; Thu, 30 Jan 2025 05:29:55 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Cv2F+dQn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3B96A1E105; Thu, 30 Jan 2025 05:29:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D4911E08E for ; Thu, 30 Jan 2025 05:29:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26AEA3857B90 for ; Thu, 30 Jan 2025 10:29:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26AEA3857B90 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Cv2F+dQn Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by sourceware.org (Postfix) with ESMTPS id B2EAC3858D34 for ; Thu, 30 Jan 2025 10:29:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2EAC3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2EAC3858D34 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=198.175.65.15 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1738232950; cv=fail; b=j8S9zKeahv+3Hk+oD2CIezCJnBqaYGz9kqFKARRSE9JR2Ts5/CN6Ip/7dhE0wWiSMAxFMimgfRYpBKFNXmq35V+n9zywLKJ81uEB4chBy6vhUxBLLUXhTUjDdQL3omWF6cnvixKlwm1SBSs/1UQ6DRPw79li78Kx3yen5dCkTcI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1738232950; c=relaxed/simple; bh=kaqF6XBqvOd0hhYFIOpOU7Q22nDjy8uDNp0Eq1dTPhc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rtKIHi4FXCvADn4tTwPf2B6a9n3rw8SLrO/5wYGbJABvdy0AIJwlFBC43VuRwcvTYxamShP1a7ikpoztsS4rV5P7RKdIQn+YTJtTLacHKFruZvyPW+0p0KcqKOXiEeOxtna6BBVrz/FAu2ZMuXQdOdcLtyYAmb0UtzeHMA5EqWo= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2EAC3858D34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738232950; x=1769768950; h=from:to:subject:date:message-id:references:in-reply-to: mime-version:content-transfer-encoding; bh=kaqF6XBqvOd0hhYFIOpOU7Q22nDjy8uDNp0Eq1dTPhc=; b=Cv2F+dQnkNYg2Sx8OuVBfQPMCAky1+Nk/Wrg+geqouqJgoLXMzrfwhIQ QSR6vXlyYT06Iv4ugPT8V/WhgMB6e63t2zsDOluXXgm7zMrEHkghrsTTq rVKwboqhVuL2ykNK0jA28++ZVbHOPX8EIXyuK0ZCz2QEcLwtep1lLneYF U4hlTHCb7k+H2IXYzShTdLSV9QRHtx+Lx7ax4wNKxBizjrRGAuq+i8/rt zxSQq98A4SJaZc0qvG2wYoSqsO894hsIVlZu26DbEijScJ+UTEc1h0rJb zFOWpUnwDzklKueMKJXDeso/qf59dGfheCHG8ZZ22GH1CDWZwnIEpoKLh Q==; X-CSE-ConnectionGUID: poHY68VbQgGPGml9O1Z82g== X-CSE-MsgGUID: RZn5NDAoQAm7BPs1XW3//g== X-IronPort-AV: E=McAfee;i="6700,10204,11330"; a="42426848" X-IronPort-AV: E=Sophos;i="6.13,245,1732608000"; d="scan'208";a="42426848" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2025 02:29:09 -0800 X-CSE-ConnectionGUID: pd6sEU9tRce+4zGkgHXPRw== X-CSE-MsgGUID: 4pi71cUkRquO+Fs2BWQeYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="109138022" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Jan 2025 02:29:08 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 30 Jan 2025 02:29:08 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 30 Jan 2025 02:29:08 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 30 Jan 2025 02:29:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EAa60TBK2wi/+g91ejtix6QSwI0FlP+VeypiITAW8SSfcfzfxv+ViD1vx8GPuz/k3Y2/8zU0Xl93aSIlF3C7rxd3jc6sgIP9So1G7HGDYZ4AJaCph3f7k0VBmXy3iTF0N/Dbm6duD6tznmOtMjNLxPMCUeC0/cTsKzUN49D/scwbqeY9FHOo/ejF9zzBxKJkV/9/z/DnLobcx7M0PgNFJCdvEfls/jXstMWS+LgoLyYiQ5zu8q3NgmrUvatfLE1wBY68j1jvquRg+DnHgwiYnBvDN9aatof3f6Fpm6jczT9Nu9W02Xnt/4ZeIe39HBZOPhNTsOqWtYrdfQPsoScDhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0gPYAaVBHBTa995o34YfR6XHhJ0O7ZTQaU6ZtjEjRqY=; b=IlMr4FoxntjRTShBAALEM8g0QTfI5PT6/mGQ0GYnamlg8WQNggdSOERLnBzwvz+sfH8VzsyupLzFLl7wmQBpE+8JSwhLbamrVLqU/NfPNsP+SpeF8BuVnTwfEqZwa+WGVWLlxWeRZAlaljQEXjUdm+oVpR7cs44Zjg9j7SLwJlmqFx8trGDRVaPmeGjQEnPQw8BXgabHV9ypSuFrZrlPYQwBXm4UIcBaTHg+71ZNH6vyD1DORmnDT15CXLu/9XPOR+pQ3IZt9MX+QruYpxykC2wV3ujUZaCbLN8tVbcJ6RFZYrHXspflSFPR3Vw56mh5XZEAmQG6/6H6JqsJd0Z6HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7638.namprd11.prod.outlook.com (2603:10b6:806:34b::22) by SA1PR11MB6989.namprd11.prod.outlook.com (2603:10b6:806:2be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.17; Thu, 30 Jan 2025 10:28:19 +0000 Received: from SN7PR11MB7638.namprd11.prod.outlook.com ([fe80::25b8:16dc:755e:34d1]) by SN7PR11MB7638.namprd11.prod.outlook.com ([fe80::25b8:16dc:755e:34d1%3]) with mapi id 15.20.8398.014; Thu, 30 Jan 2025 10:28:19 +0000 From: "Schimpe, Christina" To: Guinevere Larsen , "gdb-patches@sourceware.org" Subject: RE: [PATCH 02/12] gdbserver: Add optional runtime register set type. Thread-Topic: [PATCH 02/12] gdbserver: Add optional runtime register set type. Thread-Index: AQHbUxrU2gAlb8SJ2EqWNe0HUPOCmrMsbMYAgABUWQA= Date: Thu, 30 Jan 2025 10:28:18 +0000 Message-ID: References: <20241220200501.324191-1-christina.schimpe@intel.com> <20241220200501.324191-3-christina.schimpe@intel.com> <17373ce7-75d2-458f-a9a0-dd9db428371a@redhat.com> In-Reply-To: <17373ce7-75d2-458f-a9a0-dd9db428371a@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7638:EE_|SA1PR11MB6989:EE_ x-ms-office365-filtering-correlation-id: ac4a70fb-a744-4a83-f32a-08dd4118d08a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?HetH23tvSlhuJugPSke+W/0SZTMe7aEEXuXr6pr0JyJNfWcyG6AyrcNIKBCl?= =?us-ascii?Q?JF5ZLnbYz8stcqO4CdvUR+gtWucC4c3T6hsY3JSAtLkP2rDkAMzHRkk1Pnwo?= =?us-ascii?Q?BVnyrXJxXgvUFylDouDNcGPYMnU0sHqHEHKpSZxKr6SzjMVgHcTRNA+tSqOt?= =?us-ascii?Q?ep2Vm3DRC6wltjIIEt4fm01fAD1L2ryt238uyYW00ZbSBHszcQARXqN3WZag?= =?us-ascii?Q?Ea3rn1WDSiYWS9tx9cuCiC7OudrybquPt4XWASEBJ/5GifQIe/YohwUnD5SE?= =?us-ascii?Q?LyNPU9jVCEkqdMyUZts0vSZUX4otL2myTQ5sYWXIMb9LG/a7LoUjPXayJ3ST?= =?us-ascii?Q?ZLYQAfxG63BXVseXVhjch25WXr32VQILoBSeNcYMs+QNLuyhnsY6tzRPcl2D?= =?us-ascii?Q?W+Y/FHY53vhw1/O+o3iNnF7WNB8cieTUUMuSjShFG3eqIhQcg6xPGhD9k9LV?= =?us-ascii?Q?t9qz9U3iCWYAvPnk88xQ4q8NJBqzq4uq32fdy7U82RqdTMZrnqHHDRlKb6Sp?= =?us-ascii?Q?eFd1lNKAezfSTRToW6cEdBvbzZoiKyue8wz/0tj7kwGLK8NChTSxsK4wmhY0?= =?us-ascii?Q?3/LnecmiEsGOk4MZj4056Cge7AEe85VL6IILM01J52FZW3ckJEIuXzYsV/HB?= =?us-ascii?Q?64HhTXcWY5yxL8us4utzdAtBkhoK+3k/0SfgZ6/TWvIeyUgbhr7GckFv3PxW?= =?us-ascii?Q?vVB79vGOVR93uqVBmCZRwAZY93i0P7pJ+EjThiS35jZGUSEC7WAQK27VgmJH?= =?us-ascii?Q?ShPQNzrIsdqMkDDQShX9qSFy7Mj8iNj9shTouaR2ophKiiC5aVFMJ7z6BtwZ?= =?us-ascii?Q?td0EuNuL9UCr19Bd1+KnZ+Gorxvq5P9v418mm8z7q3y31LTyN3TacjO+lHiM?= =?us-ascii?Q?sGWmFIHfluKhcls+DtmjpdH+Ii5OOx5aG5cunIPH2OEu5LR6O0pHYTB97LYq?= =?us-ascii?Q?TYxkrDLtR+bWVfytkXpzTT4bHW8I8GYl5tVA+pM25AxGgmr9Wf35fVart1JZ?= =?us-ascii?Q?v/s0Gyg+3fk9IOV9TxnkJw7lnAPqx5fZ6zFOkWToaHeom6Xsv1kpiTwnjYvB?= =?us-ascii?Q?BO0QC3mvM7WC3F6cQyCMaNiGc2oWLBdkzDJ9FV44erPks2BQNREDpT8sc5wt?= =?us-ascii?Q?9Kgn7v+DwKbfoSVuCkZ0PbKreIU3RdL5ogAJSk7p/USyAvdB4+4iF7VqtEbz?= =?us-ascii?Q?anxrhUSpqmJuKJo9hN3l5M6II3hQzaueTmu6MGVq78DfcWXcIaR9e05rrWhy?= =?us-ascii?Q?JKoSfeXkWiBWTHO5dTjOlP07NKJI6IBZsWbja/XJdsXKycRO4fPFQsXvqfR1?= =?us-ascii?Q?XQ8GAD0iQI1yYV0Xe5++gr1s46RSs42cLJLCiBJLMZXXjH328upZgrSaNuCK?= =?us-ascii?Q?36B0q/I42HIthbMiUsZKCTxzTJLoUFnDBRQXMk3VkLXcvyAsI5KTv+p0KhkH?= =?us-ascii?Q?5GPunInchFEL1W7k2DPMJOKMpqjqjVUT?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7638.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r7x5oL86HMWEDtaY7EyJo23F06fYPvs+fSllkE8+k6iAHWr1xsHTfdWT+edL?= =?us-ascii?Q?nhEMxsGSBEnFZNz6D+iRTQWSq9pTkfPY2LxoKOI0jM8BSbbaHARdKeJ2amjZ?= =?us-ascii?Q?tZeMNoSFUC/IRlvWkyYHWxNHwk75oSLZEafExQdnNqR4ewWXZYtTWAlN0T9g?= =?us-ascii?Q?Fu59gKZuIDuqyUc494MrfNHnCqCNqejHgvI44f0xiA8+zQ9xxfQ0/fF7Vaiv?= =?us-ascii?Q?nPRjYxXrw8gJSuS0IJD6AKXcmCihQ3liivyIpTXxXZUV1e+HK7iFsGxXs11B?= =?us-ascii?Q?V+16MXQO4BA0pWbjxnpT86/wy7cL5Z2aJ6pqD+nwq0J+N6fiIygjDUEHnaQF?= =?us-ascii?Q?YGVYei66zb3kHDxoPtJm29oenUuaQW9A9V8WBDVGp3AePsZ0I2QRSGpCuLmk?= =?us-ascii?Q?Y7UR219zP8gEnrhcoX7KVt658ubwm67m/zWyLWX1O45sN0yUV6Ct7FNjvgNy?= =?us-ascii?Q?I3snvcNh2NcF4GcJvyFmZkxR2bK9DgbRqSZrpqwSc61GGYX5kOFGQZIiAggr?= =?us-ascii?Q?C5S6Wy7R08r/CDBE6H5p8BXJRlt8rjTf3/hQxn8kUJ8J4RxMd5HJpGZLPctM?= =?us-ascii?Q?DdurLL6vN9kCkFwyxaQzScxiySeD3y+y5t2WgN5Y3D2OxxqQq8joxBhpW8tI?= =?us-ascii?Q?UBeynSvCZKpDD1s336bjq7JDBD8eghyBbef8UEfW8LXlUDg0ANSNTwca3T9K?= =?us-ascii?Q?7IXlQKXImfbWI8Byvxg4wsP6UY06AyoKmsEgOtftKJQkSDXcpRllV1UC1j0E?= =?us-ascii?Q?C+WXkjoqGu/CfaH1j/TANkJY9novigty+qNL+H6srtptGmRqlHk2fokF2qyw?= =?us-ascii?Q?oDks50Wf6g0uv9vbR6LRUk/mNHLedW0nLnkq4bib8lyZTYS+mayC3l7me48w?= =?us-ascii?Q?LBIzhBzhGUVG2qdQsSSnumCbVyu70/C4BVlrE4bdd2YyOwZ9oMJD1EDHBD9O?= =?us-ascii?Q?2Qg5g1/h0GC5oPuMSGLNAHe+RleqNbGM9WQuALWrqZhRxyXJUTp9tkzKYIm/?= =?us-ascii?Q?q/S+Gz8zRvWL9MxfoYLDt7LwcMgil4vbvDWv1Tcel0F74t7JuxpLFwAVHN+Y?= =?us-ascii?Q?hdk2sVaV30TxrPpCRy8jfBNcCMA1Cav7tNTno8YQg2IQ/d59b4Kr/vna6SxQ?= =?us-ascii?Q?GvaSd2aFJXji31OkOrn7gCiGZBE6EADxmpx44xgZVyGSI7Y+YmbTCzSNz0fx?= =?us-ascii?Q?nvdhdMu485gnQFOD2wqNZlTuZqjsfqzfKFBzKV5Bs8x6DiJl6Zca1bgPBVfy?= =?us-ascii?Q?K2eL6HDisLcZy0MMPg5mkDOlYtL8gZZ74S9beFdJPrVDN95FH0Fs1XNqJm3G?= =?us-ascii?Q?vL5ssnH4y40GitGMBkcEUgLqrl4XRgsLxau+7GxSlbgdnnh/0WqZOXAEVrj4?= =?us-ascii?Q?y7W82yCusn4Eq6YKnAhUD72f+bKXdtjy2/g3ijyIfD1DgiO5CLPIr7fJN9QY?= =?us-ascii?Q?AUeoo333ylPpGYakLXn94NtOpdZPwJqrOmPT5/SmchfFxy0pANokDY37chuv?= =?us-ascii?Q?/dRx9dWQBjGTO0+zTYNQgtr2qwAjOjf3IvlXj+SI6V7gt52EuQ0MmtquGFt1?= =?us-ascii?Q?xtHyiUaqlrVnadrD8QZuwDDgVjO6+zNYLo+iVKDj7ficAeLLCAmaK/Ejh2lc?= =?us-ascii?Q?rg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7638.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac4a70fb-a744-4a83-f32a-08dd4118d08a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2025 10:28:18.9829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oj92/dWy+6lWc8HSfbAFBSqfjhdRIxEf+miSoN/HV/gM1miQeT4DiveOEOm7a7e04i8M3V0J1dzIoabNJF3X5ZL1b8KUodMhiqBQ7F3Kt3s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6989 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > -----Original Message----- > From: Guinevere Larsen > Sent: Tuesday, January 28, 2025 2:35 PM > To: Schimpe, Christina ; gdb- > patches@sourceware.org > Subject: Re: [PATCH 02/12] gdbserver: Add optional runtime register set t= ype. > = > On 12/20/24 5:04 PM, Schimpe, Christina wrote: > > Some register sets can be activated and deactivated by the OS during > > the runtime of a process. One example register is the Intel CET > > shadow stack pointer. This adds a new type of register set to handle > > such cases. We shouldn't deactivate these regsets and should not show > > a warning if we fail to read them. > > --- > > gdbserver/linux-low.cc | 40 ++++++++++++++++++++++++++++------------ > > gdbserver/linux-low.h | 7 ++++++- > > 2 files changed, 34 insertions(+), 13 deletions(-) > > > > diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index > > 50ce2b44927..355b28d9fe4 100644 > > --- a/gdbserver/linux-low.cc > > +++ b/gdbserver/linux-low.cc > > @@ -5007,23 +5007,31 @@ regsets_fetch_inferior_registers (struct > regsets_info *regsets_info, > > if (res < 0) > > { > > if (errno =3D=3D EIO > > - || (errno =3D=3D EINVAL && regset->type =3D=3D OPTIONAL_REGS)) > > + || (errno =3D=3D EINVAL > > + && (regset->type =3D=3D OPTIONAL_REGS > > + || regset->type =3D=3D OPTIONAL_RUNTIME_REGS))) > > { > > /* If we get EIO on a regset, or an EINVAL and the regset is > > - optional, do not try it again for this process mode. */ > > + optional, do not try it again for this process mode. > > + Even if the regset can be enabled at runtime it is safe > > + to deactivate the regset in case of EINVAL, as we know > > + the regset itself was the invalid argument of the ptrace > > + call. */ > > disable_regset (regsets_info, regset); > = > I'm somewhat confused by this patch. > = > The commit message and other comments here say that optional_runtime_regs > shouldn't be disabled. However, in here, if we get EINVAL we *will* disab= le the > regset. Did you mean to use !=3D instead of =3D=3D ? > = > I'll be honest, I don't know enough about the regset subsystem to know wh= ich is > the correct option, I just think it has to be consistent. > = Hi Guinevere, = Thank you for the review. For the errno EINVAL we want to disable the regset, as we don't want to cal= l ptrace using NT_X86_SHSTK again. This specific errno can happen if the kernel does= not support ptrace using NT_X86_SHSTK (older linux kernels). I tried to explain= that here: = > > + Even if the regset can be enabled at runtime it is safe > > + to deactivate the regset in case of EINVAL, as we know > > + the regset itself was the invalid argument of the ptrace > > + call. */ In case shadow stack is just not active but supported by the kernel we see ENODEV and we don't disable the regset, which I explained in another comment for the corresponding code area: /* ENODATA or ENODEV may be returned if the regset is currently not "active". For ENODEV we additionally check if the register set is of type OPTIONAL_RUNTIME_REGS. This can happen in normal operation, so suppress the warning in this case. = I didn't want to be too specific here to make the commit generic. Is there something I could add to make it more understandable or maybe there is just some information missing in the commit message? BR, Christina Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928