RE: [PATCH v3 0/1] Add Intel APX support

["Joos, Christina" <christina.joos@intel.com>]

> -----Original Message-----
> From: Joos, Christina <christina.joos@intel.com>
> Sent: Dienstag, 29. September 2026 17:15
> To: Joos, Christina <christina.joos@intel.com>; gdb-patches@sourceware.org
> Cc: keiths@redhat.com; ssbssa@yahoo.de
> Subject: RE: [PATCH v3 0/1] Add Intel APX support
> 
> > -----Original Message-----
> > From: Christina Joos <christina.joos@intel.com>
> > Sent: Dienstag, 29. September 2026 17:09
> > To: gdb-patches@sourceware.org
> > Cc: keiths@redhat.com; ssbssa@yahoo.de
> > Subject: [PATCH v3 0/1] Add Intel APX support
> >
> > Hi all,
> >
> > this is my v3 of the patch to enable Intel APX support in GDB.
> > It addresses the feedback of Keith, Eli and Hannes, plus some issues
> > that I noted myself. Also, some upstream tests for xsave core files
> > were added recently.  I aligned the APX core file testing with them.
> >
> > Changes since v2:
> > - Adapted core file tests based on a recently merged patch. Now the
> > testing is similar to the tests added by
> > "gdb: Enable OS generated core files on systems with Intel AMX support".
> > - Fixed documentation
> > - Fixed copyright year in gdb/features/i386/64bit-apx.xml
> > - Added comment in i387_guess_xsave_layout
> > - Changed long to uint64_t in the APX test program for Windows
> > - Removed unused masks in gdbsupport/x86-xstate.h
> >
> > I am looking forward to your feedback!
> > Christina
> 
> Previous versions:
> 
> v2: https://sourceware.org/pipermail/gdb-patches/2026-July/228990.html
> v1: https://sourceware.org/pipermail/gdb-patches/2026-June/227755.html

Thanks to everyone who took the time to review the previous versions and provide feedback.
Overall, I believe this patch is ready to go in. It has been on the mailing list since June.
The most significant changes across the different versions were related to the core file tests.

It has been regression-tested on different CPUs
- without APX support,
- with APX support but without AMX support,
- with both APX and AMX support.

The following board files were included:
unix, unix/-m32, native-gdbserver, native-gdbserver/-m32, native-extended-gdbserver

I will wait until the end of next week in case anyone has additional feedback or concerns.
If no issues are raised, I plan to self-approve and push the patch.

Christina

________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.