Re: [PATCH v2 1/9] gdb: Generalize handling of the shadow stack pointer.

Tom Tromey
2026-04-15T15:54:38Z

>>>>> Schimpe, Christina <christina.schimpe@intel.com> writes:

>> 3. Maybe it might be used in the future and we don't want to
>> hard-code the value and so it should be marked 'unused'
>> in gdbarch_components.py

> So based on that I'd go with option 3, do you agree ?

It seems fine to me.

> I could add a comment such as:

> + # Currently unused but we wanted to keep this hook around,
> + # since x86 32-bit shadow stacks would require a 4-byte offset,
> + # for instance. But this is not supported yet by the Linux kernel
> + # as x86 shadow stack for user space is only supported for amd64
> + # Linux starting with Linux kernel v6.6.
> + unused=True,

> I'd prefer the first comment, but keeping it short would be fine with me, too.

I agree, sounds good. Thank you.

Tom