RE: [PATCH v2 4/9] gdb: Refactor 'find_symbol_funname' and 'info_frame_command_core' in stack.c.

Schimpe, Christina
2026-04-09T12:41:51Z

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Donnerstag, 19. Februar 2026 18:33
> To: Schimpe, Christina <christina.schimpe@intel.com>
> Cc: gdb-patches@sourceware.org; thiago.bauermann@linaro.org
> Subject: Re: [PATCH v2 4/9] gdb: Refactor 'find_symbol_funname' and
> 'info_frame_command_core' in stack.c.
>
> >>>>> Christina Schimpe <christina.schimpe@intel.com> writes:
>
> > To avoid code duplication, create a new function
> > 'stack.c:find_symbol_funname', which will be used in
> > 'stack.c:find_frame_funname'. The function will also be used in a following
> commit.
>
> Looks reasonable to me.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom

Thank you the review und approval, and sorry again for my late response.

I hope I can bring this series to a v3 state soon, there were too many
interrupts in the last couple of weeks but I try to keep myself focused now. 😊

Kind Regards,
Christina

Intel Deutschland GmbH
Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928