Re: [PATCH v2 1/9] gdb: Generalize handling of the shadow stack pointer.

Thiago Jung Bauermann
2026-04-10T05:03:49Z

Hello Christina,

"Schimpe, Christina" <christina.schimpe@intel.com> writes:

> Thank you for sharing the patch and the review.
>
> I wonder if we should we split this commit into 2 separate ones:
> #1 "aarch64: Implement gdbarch function top_addr_empty_shadow_stack."
> #2 "gdb: Generalize handling of the shadow stack pointer."
>
> This way you could be the author of patch #2, and I'll add my self as co-author
> since I'll also move my changes from aarch64-linux-tdep.c into this patch.
>
> With the commit "gdb: Generalize handling.." only, the GCS unwinding logic is
> still functional and will be generalized in the aarch64 specific patch.
>
> I'll also include the patch in my v3 then.
>
> What do you think?

I don't mind the patch the way it is now, but if you think splitting is
better, that sounds good to me too.

As you mention, the main thing is to keep existing functionality working
between each patch to help with bisection.

--
Thiago