From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YGj3LLbmeGgDYQUAWB0awg (envelope-from ) for ; Thu, 17 Jul 2025 08:04:06 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=BTEIK/ie; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 96D6E1E11C; Thu, 17 Jul 2025 08:04:06 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2B0F41E089 for ; Thu, 17 Jul 2025 08:04:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D667385DDEF for ; Thu, 17 Jul 2025 12:04:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D667385DDEF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=BTEIK/ie Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by sourceware.org (Postfix) with ESMTPS id 933FB3858CDA for ; Thu, 17 Jul 2025 12:03:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 933FB3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 933FB3858CDA Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.198.163.13 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1752753805; cv=fail; b=UtkPbPHWOHQzxTsONjjudKqtGVZBk3QRLzzaLLjVLcPONwezbPLlyS9H5+EUBkI+tHeUMXejoXfGeYb3Q9Qjay+dj/hlnXqJS/7DQaC4nkfSx924N2uKSOPYOI41gGVNe/QkCMSxPxA9XIToKi81lh7JuSM5/LdDu/Fxzhu9yNo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1752753805; c=relaxed/simple; bh=1A+R0nIpvNzaydAetytCEtPrSLh3lsIMXeHu2Snds1E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eOAQOKiTVZRY6mZpZRQYaatMbHAURwJP1okf4dWmdYMOWbj/wAI+ShvLrulxkWick3C/b/Y1N/5eIULn0N8pMbrib/y+MXwfVjMk5qy03qjM08b08yBLaPhGZc7u8zncSLx+GPunzmtKKDkCTXihqQuwnhe5nWnlpxqAzgrBh5w= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 933FB3858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752753805; x=1784289805; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=1A+R0nIpvNzaydAetytCEtPrSLh3lsIMXeHu2Snds1E=; b=BTEIK/iejPEqKRraST7i9NLNJuf+Hbei/fe0JynLm272MbjyhERrSDXv q9QxMzx98kTEAthhJTXcKzwNMt5Ov3F1BJ52lNqBN4oH8MrULmhhA/C3u rFs71UgUhLJ6mdDUNlltmh7o1ajBX+CsswE5o1XB9pUQiBuzYggdAWxke Dv98jeKht9EBUFlbhb1AyYnIOcUTHq4D2iuLkn2+l8VeV+Kx4UqBKInUg w0Tcu0Xtmsf9MTULCPeU4lDyJfvghuYKb8rWyraRhSiQas9Y+NIDDF2JH LQBhiktHEoG2+b3yx0H4nkspkqKUQDXVfIbLZtPoeQ99idPq6e9+rAo76 A==; X-CSE-ConnectionGUID: wc49U7zwQLa/QEHHztfqVw== X-CSE-MsgGUID: Kjj0ghcCTumTifoAX8drRw== X-IronPort-AV: E=McAfee;i="6800,10657,11493"; a="57639495" X-IronPort-AV: E=Sophos;i="6.16,318,1744095600"; d="scan'208";a="57639495" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2025 05:03:24 -0700 X-CSE-ConnectionGUID: t0HQjW/sS7iFRiDziEf2Qg== X-CSE-MsgGUID: BeeMkr/2S2STqLMN9iLR2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,318,1744095600"; d="scan'208";a="158329860" Received: from orsmsx902.amr.corp.intel.com ([10.22.229.24]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2025 05:03:23 -0700 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26; Thu, 17 Jul 2025 05:03:20 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26 via Frontend Transport; Thu, 17 Jul 2025 05:03:20 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (40.107.223.50) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.26; Thu, 17 Jul 2025 05:02:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FVq3ljyQ5KEFybG/z/1wGPVmJmjn/G98Ommcj5H+Tj9bjmTKc0XVjw/Zz01TM44Qz9Ow/yjOpTG84jWdJAXaElD4HfAjoE31a1/YQg1gv5Eq2DAjotnfBPX8a3+4pltvSm+YPzAQcmuRJusMmRDFhnhfVmh85vXKLZPGXm7Qzs8MA9IevCV2sswO6nCiExByM+jOfusYZuEhQwYzNUwqY3S4zcRnbqPN5pJhOzQf15+VNUf8Y4OF3tIrV6AVBTVpylt62lV0Azq57H/DpfFAoSuDV5s/ObmG80j/PE7xoAJP7Kb0U7yscXZGkBvZqgmbLAwuqPbXUQkk47Jg+V6GpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cqllS7UCLnyeePrLYuKD6oeYjgFiVI7HpxshFUYfnuw=; b=tuBouVSbj89YOrwoPzFDyv4FszXobeoTRuPqyU1YguzgETICUrROEAWDG0KcGdg+HmeGPy6gyneZ2WqCyIHOAqkfVttwMHC5EQ46y/wGvPV7LKP0YZGWmXoNH5fKdQ3Ac+b8hMjc4Jeme7lu9S+ddYjjU5m6hXRKNi4K3peMFi3AmwjnULaXWpfohPrVEX6tfzZZBOtusQNraYOA4D/enugg1BVxURcDt0dBBsiT/n6/EhlaYma3l31el/F3e1n5zkSs7YDofeOAPe+e8wPTpmf0Yfwd+gOo6FcRAaVGwP2NABlONA0JFnMtiUtChQ/WA4QenBCmOCW95Exv3FhrFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7638.namprd11.prod.outlook.com (2603:10b6:806:34b::22) by MN0PR11MB6254.namprd11.prod.outlook.com (2603:10b6:208:3c5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8943.24; Thu, 17 Jul 2025 12:01:59 +0000 Received: from SN7PR11MB7638.namprd11.prod.outlook.com ([fe80::25b8:16dc:755e:34d1]) by SN7PR11MB7638.namprd11.prod.outlook.com ([fe80::25b8:16dc:755e:34d1%4]) with mapi id 15.20.8857.026; Thu, 17 Jul 2025 12:01:59 +0000 From: "Schimpe, Christina" To: Luis Machado , "gdb-patches@sourceware.org" CC: "thiago.bauermann@linaro.org" , "Andrew Burgess" Subject: RE: [PATCH v5 00/12] Add CET shadow stack support Thread-Topic: [PATCH v5 00/12] Add CET shadow stack support Thread-Index: AQHb6Ab9l+qATzhkEUSjG8AwKTocrrQsz1UAgAAuc0CAACpYAIADAyIwgABWyICAAMttgIAEunog Date: Thu, 17 Jul 2025 12:01:59 +0000 Message-ID: References: <20250628082810.332526-1-christina.schimpe@intel.com> <15bae8c2-6b3b-45b5-9b4f-f9158192fd80@arm.com> <1736d9c3-8cc6-4e00-bf5f-f824a4de0f34@arm.com> <38834676-29a4-4459-8fc7-1e59f6ad194f@arm.com> In-Reply-To: <38834676-29a4-4459-8fc7-1e59f6ad194f@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7638:EE_|MN0PR11MB6254:EE_ x-ms-office365-filtering-correlation-id: aab778e7-454e-4245-a892-08ddc529bbc7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?OMBHiA5PrHDFyhJqomEJQc8knLieSr08Wc8Wzsl7ebfzkAQDOBRtbXV0+7kY?= =?us-ascii?Q?vaCRJxrv/P8scOJVx9ST6mIss1GEgfazF6uUx1qQLlNdbbOGnwgrrqBAtRdw?= =?us-ascii?Q?1fp9cGss0U2Pwd2GiERVnZHlHsYD6YUiPb/H2eNbxP0BmaBqKyr7s0kjDvai?= =?us-ascii?Q?0alVbssXK9md4g9mh1FNvSb7c3RpmDHgj/kYSlTuTivEWY6UUI32mqPZnAKm?= =?us-ascii?Q?HJRVa5oeGilC/0rL/UkcGvPxQ73K7zfvT64RLQGLSswNOFZEQnkTyGbkoTsp?= =?us-ascii?Q?spNhWFG2/C1WKnjEDbn7n3tRWkTfXJP0q2r39V42E9CjQpqth/Jwh+QB9pLC?= =?us-ascii?Q?yG+14erwN6toXmnEhO5In9VzwTFozGDVlzKw5Lr9LZtzQx/RhP3K1SYpV2kK?= =?us-ascii?Q?dzN0yAhBmZXiKAq1QS0AwM6Ltuaze0svtkz/8X6TcIqUzK56xdj3rv1R5FoK?= =?us-ascii?Q?u7JZHpq22TobIk/HfaqUDrUzAgqvYj4uVZI4L8RKV0/j3a/XGkXFg6rYCTfp?= =?us-ascii?Q?wPe1Bbaf1+z9Er/UJEmqavE3Vybhn78A0SzOgIKFtzZqeUbT1q4p477jfuHg?= =?us-ascii?Q?YKlcivLJKbYVaOzTjXZCikVK8X2diSXGG4AV7XWDVJYmSB0bNGjaCbBT0DWF?= =?us-ascii?Q?9K52qe1EmkCcgXJt/Qm3rbL/epcbHoIAjjtIhtETXUlDYuGUhIhZcS5mVg6V?= =?us-ascii?Q?ctOrlDAv33XSxHJM4EJ5rWYrkxjM9aLPEmg5Z/YV6fweS8tGc2VVGrPYPkw2?= =?us-ascii?Q?j27cuhHxpQsHMmMPfE2355vPZgCp5Al9ACj3DaLl0Y4R3DsEC71MBMKFK06f?= =?us-ascii?Q?5yxdSujHtMl4BFHdPfbQOhZdsLJwg5i81SyIjlnU8rbwsb6Lc0vPw40WmNlY?= =?us-ascii?Q?fD3ISedjcpNR0hPLVRcymNvlXG6C946KPXLhBrsrQxSumUtSrvXbDGHOw0DA?= =?us-ascii?Q?dVATXEudaG0YO1WeJ1AYVju3UxpvJ4ceaOUQ7FM5gr9GXwD9/nFv7Vvo3qLT?= =?us-ascii?Q?GUGtPWDPufGtYHNeHV10IxpSus+v6Ul/Nx39sjXtGISrIKUN1TGFwjihGAP1?= =?us-ascii?Q?1i694o75/QhPOAezyx6nZOcLUoDoFZmJtmklsGaYjOtmyksaywZ0fJPUzyz2?= =?us-ascii?Q?sAnEdQS0LQaL6qPfLUJmpX/Sa1du/grTEQQus6pV/kw0+MR+dzLpqMmZaDF4?= =?us-ascii?Q?Wr+joHv30Xbjc/Zts1z61U7y284RiVXnMFfcITdaQURcO1xT1VsJZumD5Qxa?= =?us-ascii?Q?5ZUT6H5GuSWriBoRKwVS5JwvyymCV/Nt3xUmZaki0ntZlA1lU72ZpYKw5dXl?= =?us-ascii?Q?M4jYCFlbf3ht+ShiFq4i5ZG6j3cxEtcexQUpoMFY+DgmuNeqosDhyrYjf6Zt?= =?us-ascii?Q?mXHQoDPK7UpHCpB4Se08GFwHWfNJfD9YGJq1zDLTz/USc0eVO+N5ndUpFdls?= =?us-ascii?Q?G7JaA7s53jJXd/yQRTQ+FedPZbKsEGjMd8ZjCQQo1V0jIHVhyJ1IBQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7638.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jOmk/FNl9JfUWFJgWRM7N7C0McwKn/OAHRHiURp9WzzRaNrnSkFBsn8iiDDN?= =?us-ascii?Q?5QaA2eDx2/CYJNlb9X9oBLGfwY+wXpmXB0XtDfhLt6zSfj1Sw7dNbXIbrHZm?= =?us-ascii?Q?BT69SiIKCIxUoApFiYKNi48O8dKCTn5pGMy10TpDFg/g4G2rnUamQQde/Roo?= =?us-ascii?Q?0Vz/cAD0Ndmyr4P1nR+6N0VMC6CY5Baj6bqeMkW2eV1MCfnp0c6XVa5AlCUW?= =?us-ascii?Q?DMYwKAuC16BQ6F2LrcikIjcqQ0fR8hb+puVjCWvdfev0Oi6iC55MNAjJ2lUH?= =?us-ascii?Q?wLQatUQ0KFzh2gtyZGqMzbXoCmzXHy7kQW7+a4vSBIkxiS+NyRqh3AeMHOMM?= =?us-ascii?Q?FVbzfqwaz2WuXe9N5p4Y2i+Xo8iwvJ51zSR9NfuaOFL3Fgj7WuAEJVxxR2q/?= =?us-ascii?Q?BDK/sX1S3cWjheQAr6z5sZvX+RUyct1Q6E3rJGtCBNxmFZvKNqE9faZ3J53i?= =?us-ascii?Q?IlOktGs0O4Rq+lttKlPDZzG9KVqCvZr9E7jnxR1lR8Y6EzofLhcbNrElHmpI?= =?us-ascii?Q?FoENc76cPyShE4K7aWuEJDiHz/TyTos3031r5A4vZJGtJrn0QHndKct+Q31e?= =?us-ascii?Q?FRRQeZVvZCZFKhtAKBBqMJwCXuxHo4EcdkwHmpWuWDRvPzpfSAWFWbTSasEm?= =?us-ascii?Q?Eifd6vUd/InAhATyqYt7IQSfGuR4FXMtL4LATL8qpx4BMZyxOk48XKygjvus?= =?us-ascii?Q?8udeUy9G4QEpUuTbhY0wR7VljWKsBV3fn6nyOAu5widkK+Guz5EPp7c8eHtu?= =?us-ascii?Q?UH4GR6yt8wJfN7gucszyRLT8dry1cJCDf8YHTq5BZkEfhMxb6hB3jVXved8h?= =?us-ascii?Q?32GFXpczJ1pdLUiCjfwQkNdUZg62s3YhAgyGxQ2KfH/YWqGFZf32NkWyEo6r?= =?us-ascii?Q?psS7owWUPG4HLPQY98KKRQddEgkLcvOUSVPVstm/8iMQSoV6+n6rf6sAzpVo?= =?us-ascii?Q?2QJ5UlzyvUMfz9Ja8NJxCYvC3A+OoEPpZ7EEbcXvz08uUp5eRKXbjCBMStBb?= =?us-ascii?Q?euUwFR46LHajUmZJQ+J9bU5p+waeenLDFL9lYT4cK8NR7vVy/KWxcgw7ncbp?= =?us-ascii?Q?mop5TVzJYnw69nCHUBQFMIr/ISJWHJcySlqmpEVGM6K7VBzCu6VjqiUK3nZu?= =?us-ascii?Q?3lLWvYPad6ncFLVt8qmnf2VwzA7Tb//EkFNeu/BHEv6kveCBzLD+PbSrhmAd?= =?us-ascii?Q?DflUzXVZPuxHnm3FJguFBxJzALcCloNYvFld4xEexzw2/aF6bONwML7LNMx6?= =?us-ascii?Q?b67w5MgfSs858gSG76ajFTEaSZ0GIdNN6VYTLOJEKu4njruJfGU88bjxPf0H?= =?us-ascii?Q?c0aHzESDegI6fCzQKpzxBamIx3bUrnPTCay3xQi0meVxCZRxdi6JVHart7WW?= =?us-ascii?Q?9zN8Cags0K2jmDtt5IxBhs9Hhh0wOpe2uIoaF+BOhkAxAPu8rM9PbLkdGRNM?= =?us-ascii?Q?7cKl+yCAn0SuIGaphhEWJBjHBIP8N6NasaKeDjDnYAZEUOv12HjpB6E2i8/v?= =?us-ascii?Q?fjUroCwyTsRVeXTzJptVnvjJ6dgrJoj9AH2tpOptLD+uc8pk8jh/gFjCGKDR?= =?us-ascii?Q?us8Mtk1FHt/y3XKN4+keNyIVbYUw6sZreyekgwlczYKYKATEqWEyhH0YV2Jh?= =?us-ascii?Q?8Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7638.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aab778e7-454e-4245-a892-08ddc529bbc7 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2025 12:01:59.1022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 53nfSOYaIaiqSUgr8b8W+Y8bbqh3/tsFdD2Cqlwxy3yiLQDkOYAmKbKb/btQCy5a3dnwUCez1uTTP0an5ricN240RWGkVoxlq8u1aGK77KY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6254 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Luis, Thank you for the feedback. > -----Original Message----- > From: Luis Machado > Sent: Monday, July 14, 2025 9:13 AM > To: Schimpe, Christina ; gdb- > patches@sourceware.org > Cc: thiago.bauermann@linaro.org > Subject: Re: [PATCH v5 00/12] Add CET shadow stack support > = > On 7/13/25 20:05, Luis Machado wrote: > > Hi, > > > > On 7/13/25 15:01, Schimpe, Christina wrote: > >> Hi Luis, > >> > >> Thanks for sharing that info. > >> I tried to reproduces with the same ubuntu & kernel versions and a very > similar system but am not successful so far... > >> Just to be sure, I assume you test with gcc compiler (which version?) = and > compiled GDB with latest upstream master + my cet shadow stack patches? > > > > Interesting. GCC says: gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0 > > > > I applied the CET shadow stack patches from v5. And yes, gdb is the lat= est > tip-of-tree. > >> > >> Do you see this for target_board=3Dnative-gdbserver and > target_board=3Dunix? > > > > No. native-gdbserver, native-extended-gdbserver and unix work just fine. > > > > Let me have another look to see what might be going on. > = > Heh, found it. I had a freshly-installed system and was missing libexpat-= dev, > so no XML was being generated. > = > With libexpat-dev installed, everything looks fine. So this is good. Sorr= y for > the noise. No worries! > I spotted two things while building gdb with the patch series applied > = > There is a uninitialized usage warning > = > gdb/nat/x86-linux.c:151:12: warning: 'ecx' may be used uninitialized [- > Wmaybe-uninitialized] > 151 | if ((ecx & bit_SHSTK) =3D=3D 0) > | ~~~~~^~~~~~~~~~~~ > ../../../repos/binutils-gdb/gdb/nat/x86-linux.c:147:26: note: 'ecx' was d= eclared > here > 147 | unsigned int eax, ebx, ecx, edx; Yes, thank you for catching this. I'll fix it as follows: diff --git a/gdb/nat/x86-linux.c b/gdb/nat/x86-linux.c index 1756d5441fc..d037992d849 100644 --- a/gdb/nat/x86-linux.c +++ b/gdb/nat/x86-linux.c @@ -145,6 +145,7 @@ x86_check_ssp_support (const int tid) stack is not enabled for the current thread, we still want to return true. */ unsigned int eax, ebx, ecx, edx; + eax =3D ebx =3D ecx =3D edx =3D 0; > Also, git am seems to complain about some whitespace issues: > Applying: gdb, gdbserver: Add support of Intel shadow stack pointer regis= ter. > .git/rebase-apply/patch:596: indent with spaces. > # Having unavailable registers leads to a fall back to the st= andard > .git/rebase-apply/patch:597: indent with spaces. > # unwinders. Don't add unavailable registers to avoid this. > .git/rebase-apply/patch:598: indent with spaces. > if (str (val) =3D=3D ""): > .git/rebase-apply/patch:599: indent with spaces. > continue I would assume that these findings are false positives, since it's a .py fi= le and the idents are consistently with spaces in that file. Is that ok? > .git/rebase-apply/patch:587: new blank line at EOF. > + Thanks! Will fix. I also spotted a few whitespace issues through the series: = diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c index 782b66f1467..a2b49730e00 100644 --- a/gdb/amd64-linux-tdep.c +++ b/gdb/amd64-linux-tdep.c @@ -1981,7 +1981,7 @@ amd64_linux_shadow_stack_push (gdbarch *gdbarch, CORE= _ADDR new_addr, return; = /* The shadow stack grows downwards. To push addresses to the stack, - we need to decrement SSP. */ + we need to decrement SSP. */ const int element_size =3D amd64_linux_shadow_stack_element_size_aligned (gdbarch); const CORE_ADDR new_ssp =3D *ssp - element_size; @@ -2004,7 +2004,7 @@ amd64_linux_shadow_stack_push (gdbarch *gdbarch, CORE= _ADDR new_addr, regcache_raw_write_unsigned (regcache, tdep->ssp_regnum, new_ssp); } = -/* Implement shadow stack pointer unwinding. For each new shadow stack +/* Implement shadow stack pointer unwinding. For each new shadow stack pointer check if its address is still in the shadow stack memory range. If it's outside the range set the returned value to unavailable, otherwise return a value containing the new shadow stack pointer. */ diff --git a/gdb/arch/x86-linux-tdesc-features.h b/gdb/arch/x86-linux-tdesc= -features.h index d1d74e70df8..a280bf608d7 100644 --- a/gdb/arch/x86-linux-tdesc-features.h +++ b/gdb/arch/x86-linux-tdesc-features.h @@ -58,7 +58,7 @@ extern int x86_linux_i386_tdesc_count (); x86_linux_xstate_bv_mask_to_tdesc_idx) into an xstate_bv_mask value which can then be used to create a target description. The return mask has the same format than the state component bitmap - and does include user and supervisor state components.*/ + and does include user and supervisor state components. */ = extern uint64_t x86_linux_tdesc_idx_to_xstate_bv_mask (int idx); = diff --git a/gdb/testsuite/gdb.arch/amd64-ssp.exp b/gdb/testsuite/gdb.arch/= amd64-ssp.exp index 6ddc875b9a3..18d43065034 100644 --- a/gdb/testsuite/gdb.arch/amd64-ssp.exp +++ b/gdb/testsuite/gdb.arch/amd64-ssp.exp @@ -47,4 +47,3 @@ save_vars { ::env(GLIBC_TUNABLES) } { # configuring the shadow stack pointer. gdb_continue_to_end } - diff --git a/gdbserver/linux-i386-ipa.cc b/gdbserver/linux-i386-ipa.cc index 1a0393d127c..beb04b7f8f6 100644 --- a/gdbserver/linux-i386-ipa.cc +++ b/gdbserver/linux-i386-ipa.cc @@ -174,7 +174,7 @@ initialize_fast_tracepoint_trampoline_buffer (void) const struct target_desc * get_ipa_tdesc (int idx) { - uint64_t xstate_bv_mask =3D x86_linux_tdesc_idx_to_xstate_bv_mask (idx); + uint64_t xstate_bv_mask =3D x86_linux_tdesc_idx_to_xstate_bv_mask (idx); = > warning: 5 lines add whitespace errors. which I plan to fix locally, too. > = > Could you please address those locally? > = > Otherwise... > = > Approved-By: Luis Machado > = > I'd give this another week in case someone has any more comments, and > then push it. > = > Thanks for the series. My plan is to address your feedback as described here and also Andrew's fee= dback for the v5. So far I haven't received any feedback that would block merging this or req= uires a new version think, but my plan would be to wait until middle next week. I also plan to include= parts of Thiago's patch "gdb, testsuite: Extend core_find procedure to save program output" (first = patch of v5), if his series will not be merged before mine. Please let me know if you have any concerns with that plan. Thanks, Christina Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928