From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id O/gqFI30pWfcFScAWB0awg (envelope-from ) for ; Fri, 07 Feb 2025 06:54:53 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VDsrYXml; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 436AE1E105; Fri, 7 Feb 2025 06:54:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CED6E1E05C for ; Fri, 7 Feb 2025 06:54:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 206D03858290 for ; Fri, 7 Feb 2025 11:54:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 206D03858290 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VDsrYXml Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by sourceware.org (Postfix) with ESMTPS id 805FB3858CD1 for ; Fri, 7 Feb 2025 11:54:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 805FB3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 805FB3858CD1 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.198.163.7 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1738929247; cv=fail; b=BWEid8ZbLByEPvijZEaGjpEvUIsiW0ZoTdnsSGcMpnkDmjCSVn5x2z9gZ2PB+0ujtOFPlKPPrzdbGnwz+f0fYrAH+gjsEwL5Yezw2WcTnbxvA/g7mrR/+5qZ8YjrVnWdeYtb6jltgtc1Py6zyCZAKZiGq+0cDhs0WYyYDxyXvjw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1738929247; c=relaxed/simple; bh=i0BeEEBBzGojj0YD7FY7At6J1/ZhvDuh/ho/Sz0E1+M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ELBXqQLZnojI1Z2eMAlWpuw/+yNYj9EqAbIgSJN7LaFubuyJPWCRZ2NxZELILfOcCjU/R68zJB5Jz4/QczNt66pWjR6oCx5rq3nQkhwbQuEod2GcHSf/ECYWQwlkLaouBnKLml5Pq7zCDdW4Ylp0XS7IR6ml1LEea/XnWeQ+Zfo= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 805FB3858CD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738929247; x=1770465247; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=i0BeEEBBzGojj0YD7FY7At6J1/ZhvDuh/ho/Sz0E1+M=; b=VDsrYXmlnTMbEdPhiR8DdNGfRSZfzGtm40xC+NIba/ovy20jB3d580h8 IqWbcSb+VvMP92qUPQnKKkr0Fhf2QCvLhxYrLhE7linBVJzqiC2StFoH3 kbZq6WlhadTbsQ3185bAVDXPtpRwJ7vLRfPJf4hEyu/XhAvT6ZsfGpmzU vCc4eDUbcnp9qqp3pYe/3uhkAgbjq041MQljGtznA50CU67ZdvzDwXYgB oKfettNm045ahZy4tjyIyVPfBmiskSsCOawmVrkhJI1T2EEUByWjvZ4qL C3aFJhHO8vFF6vtQLU38R8UFyS04BvutBzM6J8G/UphPPui4qqv3bQ/74 Q==; X-CSE-ConnectionGUID: UaQ5xohbTIa21t7Lnzsfsw== X-CSE-MsgGUID: znySGEFkTi+z/xzhkylUjA== X-IronPort-AV: E=McAfee;i="6700,10204,11336"; a="64924391" X-IronPort-AV: E=Sophos;i="6.13,267,1732608000"; d="scan'208";a="64924391" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2025 03:54:05 -0800 X-CSE-ConnectionGUID: HUL1PvQnR1Or1duNMaZWeA== X-CSE-MsgGUID: bb/Zcmb7R6O8L1QlBGiX5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="142378279" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Feb 2025 03:54:05 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 7 Feb 2025 03:54:04 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 7 Feb 2025 03:54:04 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 7 Feb 2025 03:54:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vy24ZRUMxOVF3wN2Wx/xGbOO3dUzEDHFT445FEO8ZWrlG1nCmnOB4OrSStXa+EXwaXMMAxiRql9GXtfD4Xz8KBBFMLUx2SbeFu8u/gI2h73Bqh/atmqOHrAOUXJ0d+qRt5g+ZRJLa0BzTxpR9FjzysL2X0tBEcAOVL1AOBsDCbsXS10Wt5kHGQw2t5OXTM3vC9tdz0vCG/LfJGTr6ZPmcYFyYih1btCkmaVUhxfhySp87ro/wifwxQ33fdvjPmnVR2WdOTZn4LxwuzrSh+cjBX8otm7r/me0N9IoZGwlbDkA2nWhytFAPwUsKtE5SCFoSqxsfjHdWt7r8INP+X3DXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=si40Z/dm+MDCiuxdWxnWqPKJ2M8OuFf2bK0VWXn3n+E=; b=eIReFpZU3k0+/ljYO+6uQk/ESmVXkHR+Q6cUhNbL3XpKxO0Tng0cs/YTXQAaLNOhjYSy2LDMTxjOcJ7UK5BQmD2qREoN1EqGjuHKCWM+Do4uvbqOVsiWnoAMFXNaX4lLAgODx6abKFcr0HBiTTT91KB4IsTwZ3RHeU5uXXGIxZS5ozsPmt5rYKcZlJzNp0gvQyy+3JXkdQbDjSvQ4SJM+pPo8gGSS3XfVbixfsHhADTYHJgPo7yWfthep1Gr/ygsVVOZZ5q/1n3+C09T6kXlGF1z8haqrdjn3K8kOqOyqMHhB2+tGWzwnzAQW7ERJxN4NNnvN07rvlCcJ++ppz18JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SN7PR11MB7638.namprd11.prod.outlook.com (2603:10b6:806:34b::22) by PH7PR11MB5913.namprd11.prod.outlook.com (2603:10b6:510:137::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.25; Fri, 7 Feb 2025 11:54:02 +0000 Received: from SN7PR11MB7638.namprd11.prod.outlook.com ([fe80::25b8:16dc:755e:34d1]) by SN7PR11MB7638.namprd11.prod.outlook.com ([fe80::25b8:16dc:755e:34d1%4]) with mapi id 15.20.8398.021; Fri, 7 Feb 2025 11:54:02 +0000 From: "Schimpe, Christina" To: Thiago Jung Bauermann CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 07/12] gdb, bfd: amd64 linux coredump support with shadow stack. Thread-Topic: [PATCH 07/12] gdb, bfd: amd64 linux coredump support with shadow stack. Thread-Index: AQHbUxuw/b/Q89MZq06jeCa3Hmvop7M55I8qgAC9poA= Date: Fri, 7 Feb 2025 11:54:02 +0000 Message-ID: References: <20241220200501.324191-1-christina.schimpe@intel.com> <20241220200501.324191-8-christina.schimpe@intel.com> <8734grix17.fsf@linaro.org> In-Reply-To: <8734grix17.fsf@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB7638:EE_|PH7PR11MB5913:EE_ x-ms-office365-filtering-correlation-id: 0f31b15f-9364-49f8-f140-08dd476e1dc8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?ikSArKkOSpVVgeiaoECDNs+x1lFkfazxCHr6beN40dZ0605hYkKmv4l8ijxk?= =?us-ascii?Q?zgZv03/ai2/ucP0Znwl5ngVbbyNPxneXsTubjRh2uPy9CPcI9Wk1PCXvY99p?= =?us-ascii?Q?RUHr4WTGk2jCm6cwyngFhFJlm3NcnYhQzEyR5b0MsrMcICinNN7be8QBkxw2?= =?us-ascii?Q?GrZb6WU4ktUgD/je4EwHAURhyhOSHfseKOqDb1qmxhou7FIEmmw3QOOAR4dG?= =?us-ascii?Q?5MzslM82ZE+IgE2HBU2oHO/CxZiWhTV0ij+yEa8OORcuTdKGoNd33Wa7PDPo?= =?us-ascii?Q?irHdIQsCuOy0FLeRx3tqFipNo17/OLjMlx/SM9YGhYV6rhwOMCt57M67kL5P?= =?us-ascii?Q?Ua4QaHiXYYCzgfsRdgJkn62dKq6owOZ+dP5Ara87zN4lrXy9LeLau0ieJvID?= =?us-ascii?Q?vIBqo937S9XMCWNbsYFLGwKW1qm4Oawgz9bjWgvWwcwaxjwyUJ7qb2fVFLDX?= =?us-ascii?Q?hb5PXupMkb5BDPm0icdB/ZGuCS5FXtZXGA7m+WTGsfvYz/U2gNK2krCPoSYe?= =?us-ascii?Q?zWRv5EiKuVx1BCxmmWDwwxFssI1EuGh0jIM9OTKBxrde2mIB0gJOynCsJYBF?= =?us-ascii?Q?Aa8qE8jL68UI+g7HOhza7AI++5mBT6ypBGEuXiQu/Fj4x3F+BNcaSSRFE8NE?= =?us-ascii?Q?xgUz7bMJZ1z7sBewnGBAjFjB/RztU4Iye4QMxwQXbwOXzltAkNA3yuh5zCaH?= =?us-ascii?Q?ZvbcRM6pfsNoW8tsFoOQFR9/OYUGpdELqGhwFZ/J36gwWrAYuWkCmW3rX6Gt?= =?us-ascii?Q?x0lBM2twdULpkxPsmhHj/FeHrvKmRvB4AGS1+33K+Kj6sdOSgDjifjbr0njx?= =?us-ascii?Q?mvc/Ha4Tyegxnr1rJ+95vl1s2UfZ4DX5d3z3ls+ujOO3Mtd5JK2fT53TWKks?= =?us-ascii?Q?vdhGBlB2MHGrkqJruDxS33Bs1RGXprhr22EZocZxpzmL4XvCosEDLTl3WR2v?= =?us-ascii?Q?6+26omnGslfMxG3UGEPTI6dGAkSGHanVn6KFeSRlchTSWYb3xVe3wUwNdidN?= =?us-ascii?Q?40k+51yRE3cj2bI6lMQUfUDD4dMG+aWK9Jf7zDE37DfDZg8OcDFCBzl53+J4?= =?us-ascii?Q?W4dks7HkOB6kUToHOGlSvVfRTpysKWSrs3STDyntUFTKSN7h8dgAbRbybE/q?= =?us-ascii?Q?xgIlFhk/fQNxqviZZ+GB7oTg+FZaU/xoiLzt2qCz+9pnQY9zZILcgYuHK9DE?= =?us-ascii?Q?QCsc7XFaw6LpPkbW6lK8CzobD/hB6rCqCVauKW7kChG8oiroDRjUsIWwgOPs?= =?us-ascii?Q?edpEJSD6F4lfwLFZCebITQjCs7BO0EzVglZtxatih/7vf1nb+X6Ogs7GpcMK?= =?us-ascii?Q?xZrhiUWtzrQAuK/0Luuh5nslcaEonwP9n4PM4eBT+H3G5HtQAzAC8S2Hx8iu?= =?us-ascii?Q?7ByfOWqBpTa49tK03q36q7IzzAAYJ6W8qksPWMqErbSSASMQBjIappibHSEk?= =?us-ascii?Q?cAYteITYm4h37TOExmF61gOJmzyxxqfU?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN7PR11MB7638.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Bz552qPlLxM+AqWAJwd/DcvKDZ0nF2uLXWS450hpNf3RKkbWJeGGFWeAAna7?= =?us-ascii?Q?gSm1xFj+F9dip6sr0YPur+8e6T3/un7KYobldB8lGKrJiIZ0i745h9T+Lt64?= =?us-ascii?Q?sA/OcFh5zggfbnTSwiB7JD0mudUWSNEOzDpz6QeMKwfvdTIljiW0RbV9oa4+?= =?us-ascii?Q?IQRH2eDdYON+LuA11Zy9EOu8Yyz7eSG55iwBsgJJuRohhWo9OaDqIiUVqWQN?= =?us-ascii?Q?VRM+aEdUtTo9qR9Tj+4X3f0aiOC5EYSHspnBfemrpNenSHjvK+F7GlacF62y?= =?us-ascii?Q?jpCNHqe1m2AAeNNT1xoGeSfhcN6HHz68bD9/UIU77v+dbscMzVBjgEpWPloA?= =?us-ascii?Q?/wMVN8+N8J80NlrmaKAl4T1NgyFg3W4KNPam5TXo+XFGNDzL7Bd2ZFNyWeIn?= =?us-ascii?Q?O0QkjGj6I1KsLhhsciN9b5SJuVRMwID3cfdh6shOOkPbzvI9B6y6WWbxMEH9?= =?us-ascii?Q?aeB8ZW0x56ZqUGstYqTsdg5tYaaR37SQc90feBc/9fhbY21shpZXX9tzH4oq?= =?us-ascii?Q?XpUBzlZyGtFqgMZgE052gxHnaafV/eaEPpo/38oJ8UKALMLwDtTIG3nbNtyz?= =?us-ascii?Q?460c0jXKn2THPL0kyvHX9TmbNpTj3gAMmIJTaZ81gDqbJp96mWr1sFIHzncF?= =?us-ascii?Q?hOCPG9p0vuN6QWVBnyAAexmSC9hhYbXUF8x7P1eFgnvM4oCOyYAOMlsmgEGR?= =?us-ascii?Q?mX7CHVcWsRD4fufSgQ9xmwVBjpVKCnKqyaUphn2tQJAH6z8QsJIp288bRvDY?= =?us-ascii?Q?L05aaVvkVGAin4MUOd5fuQvbhIMxhYYcynVMvW3GCUUQbPML47pqvuiHTphl?= =?us-ascii?Q?0kvlCyU9w6rgXYMNTS2iH3NEWqm5vwywjiUGEtRc2GX8ceHyz9KaXpsoIga3?= =?us-ascii?Q?YCqt0NixgeZ/mLgD2Nz1Dvxkjtt7pSakR1f5Xcmlhh7QZg1MCrr7aIV7qRy6?= =?us-ascii?Q?JnHOi85b/iNfn0d8AeMpm7R/SImqEhHDcfqE80pDjmPDHfx1P8kw4y+ZSzBQ?= =?us-ascii?Q?y6/hyi6Ph0VZckWmLCfKSk58B3X/rH8eg3Lc0Gxcjo6aLNiojk8aKjgKqaBw?= =?us-ascii?Q?wgorGapSq8AcL5Vb5wGzfgcRrYOd4w9skGTaZVOjxgGvToOyBh4/F6HLfZZa?= =?us-ascii?Q?l1fj4i1rvYBTkU5Uv/tsFOCyT9fbm4QgEcnsWxGMDLRwjKgQKy61RVUeFP5K?= =?us-ascii?Q?HX7TZwBBiKbZThnm7bWZZ5DcY7hewjEh4lCbPEipH8b+uyCFZmEXNkGY+eAw?= =?us-ascii?Q?U65944AvUJMQnt/76LRqzZJdwAXcKaobHFgD/UmeV4Dsv/rBmLwngNiJM892?= =?us-ascii?Q?HjyXaIZAcIRd69AFaf2rhECpDwaYzMNNjmd10VuzeNB2zyaNYwKuSJt7zQHH?= =?us-ascii?Q?4jFBLGzU8h5aEm7OzW27uDAsEIXOGsfGBdU70BKUeX3RZfXOzMeRokqHQTyH?= =?us-ascii?Q?bTD8174WOsDalgEwNRwRjwz6Y2XLuUM+hasxPm8WzV9o/2GHYm7kh8mk8zWD?= =?us-ascii?Q?yYiMNluG6q1Jn5y2P67oezE/3fS9wW7fy5thDcXjYOnS6X1p8sHGK0TgNWAB?= =?us-ascii?Q?LHGnScrFEzyU8BNMHbtuqjYRuSe3GuHvh6yAbaY1GOUS/bmxIj4PkqCfaq/r?= =?us-ascii?Q?jQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7638.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f31b15f-9364-49f8-f140-08dd476e1dc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2025 11:54:02.8088 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u35reeCUl7uKaxcxZo9bgh1o9ut6rWmi9yumeQQILBORBi3ijbTeOYyPtQy8uWCdepW09xt1KFNqW0BktxriWmkB3ozJAB6AwnislS9Uzk8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5913 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > -----Original Message----- > From: Thiago Jung Bauermann > Sent: Thursday, February 6, 2025 4:15 AM > To: Schimpe, Christina > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH 07/12] gdb, bfd: amd64 linux coredump support with sh= adow > stack. > = > = > "Schimpe, Christina" writes: > = > > From: Felix Willgerodt > > > > Intel's Control-Flow Enforcement Technology (CET) provides the shadow > > stack feature for the x86 architecture. > > > > This commit adds support to write and read the shadow-stack node in > > corefiles. This helps debugging return address violations post-mortem. > > The format is synced with the linux kernel commit "x86: Add PTRACE > > interface for shadow stack". As the linux kernel restricts shadow > > stack support to 64-bit, apply the fix for amd64 only. > > > > Co-Authored-By: Christina Schimpe > > --- > > bfd/elf.c | 24 +++++++++ > = > I don't know what is current practice: should BFD changes be sent separat= ely to > the binutils mailing list, or in the same patch or patch series as the GD= B changes > that use them? > = > If the latter, then the binutils mailing list needs to at least be on Cc: Right, I think I should post it in the binutils mailing list. Thanks for po= inting that out. I will fix your comments and post it then there. Christina > > gdb/amd64-linux-tdep.c | 52 +++++++++++++++++-- > > .../gdb.arch/amd64-shadow-stack-corefile.exp | 50 ++++++++++++++++++ > > 3 files changed, 122 insertions(+), 4 deletions(-) create mode > > 100644 gdb/testsuite/gdb.arch/amd64-shadow-stack-corefile.exp > = > Just some minor comments. > = > Reviewed-by: Thiago Jung Bauermann > = > > @@ -1630,6 +1642,30 @@ static const struct regset amd64_linux_xstatereg= set > =3D > > amd64_linux_collect_xstateregset > > }; > > > > +static void > > +amd64_linux_supply_ssp (const struct regset *regset, > > + struct regcache *regcache, int regnum, > > + const void *ssp, size_t len) > > +{ > > + x86_supply_ssp (regcache, *static_cast (ssp)); } > > + > > +static void > > +amd64_linux_collect_ssp (const struct regset *regset, > > + const struct regcache *regcache, int regnum, > > + void *ssp, size_t len) > > +{ > > + x86_collect_ssp (regcache, *static_cast (ssp)); } > = > These functions should have documentation comments. > = > > + > > +/* Shadow stack pointer register. */ > > + > > +static const struct regset amd64_linux_ssp_register > > + { > > + NULL, amd64_linux_supply_ssp, amd64_linux_collect_ssp > > + }; > > + > > + > = > Just one line of separation between functions is enough. > = > > /* Iterate over core file register note sections. */ > > > > static void > = > -- > Thiago Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928