RE: [PATCH] gdb/breakpoint: make a copy of the "commands" command's argument

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

> >>>>> "Tankut" == Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tankut> When GDB reads commands from the input, its internal buffer is re-used
> Tankut> for each line.
> 
> I wonder if this could be changed instead.

This sounds much reasonable, however I'm not able to comment on how hard or intrusive
it would be, particularly because it involves readline and you already recalled
it being hard.

> At least when reading from the user, a copy is already made.  For
> instance, readline returns an allocated string.
> 
> I recall thinking that this was hard for some reason, but I don't
> remember why any more :(
>
> Tankut> gdb/ChangeLog:
> Tankut> 2020-09-11  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
> 
> Tankut> 	* breakpoint.c (commands_command_1): Make a copy of the 'arg'
> Tankut> 	argument.
> 
> This is ok.  Thank you.

Thanks, I pushed the patch.
 
[from the second email]
> 
> I forgot to mention -- this seems like a good candidate to apply to the
> gdb 10 branch as well.
> 
> Tom

What is the policy for a release branch?  Should I simply cherry-pick the patch from
master and apply to the gdb-10 branch?

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928