Re: [PATCH v2 4/4] gdb/mi: add a '--force-condition' flag to the '-break-insert' cmd

Simon Marchi via Gdb-patches
2021-04-21T12:36:48Z

On 2021-04-21 8:06 a.m., Aktemur, Tankut Baris wrote:> Simon, the MI's -break-condition command directly uses the CLI's cond command.
> I chose the straightforward solution of skipping the first "-" if the
> argument pointer starts with "--force". This essentially makes both the CLI
> and the MI command accept both "--force" and "-force". I thought it'd be good
> to have this flexibility. The alternative is to parse the MI argument strictly
> for "--".

I disagree, I don't see how this flexibility is useful, and it just puts
an unnecessary burden on future maintainership, needing to support
both going forward. I think we should accept just the one that respects
the convention for each interpreter.

GDB has not been very good historically w.r.t concistency in how it
accepts flags and arguments, I think we should strive to do better.

Simon