Re: [PATCH 0/2] Breakpoint conditions at locations with differing contexts

Jonah Graham
2021-04-06T14:38:05Z

On Tue, 6 Apr 2021 at 10:11, Aktemur, Tankut Baris <
tankut.baris.aktemur@intel.com> wrote:

> Hi Jonah,
>

Hi Baris,

>
> Thanks for the feedback and reporting this issue.
>

Thanks for implementing it :-)

> I'll submit a patch to fix it.
>

Great. AFAICT -break-insert with a condition included always acts as if
-force-condition was included. i.e. "break method -force-condition if
symbol" is equivalent to "26-break-insert -c symbol -f method"

>
> "N*" is the third possible value and it means "disabled because the
> condition is invalid at the location". I'll also submit a patch to
> update the doc.
>

Great.

>
> > Can the warning string be part of the breakpoint structure returned in
> MI?
>
> Are you referring to the "warning: failed to validate condition
> at location 1, disabling:" string? I'm not sure it should be a part
> of the breakpoint structure. Wouldn't the 'N*' value suffice to give
> the necessary information?
>

It is sufficient. I assume therefore that "N*" in a reply to break-insert
always means "warning: failed to validate condition
at location 1, disabling:" (What does the "1" refer to? IIUC it is the ".1"
in the breakpoint number?).

In the breakpoint table N* always means "Breakpoint condition is invalid at
this location" and that the breakpoint is disabled?

> >
> > 2. The other problem is I want to enable the -force-condition in the UI,
> but AFAICT that isn't supported from MI? If it is, I couldn't figure out
> the invocation that worked.
>
> This flag does not exist. I'll submit a patch to recognize it in
> the MI command.
>

Great.

>
> >
> > Any guidance you can provide is most welcome.
> >
> > Thanks,
> > Jonah
>
> Thanks.
> -Baris
>

Thanks again,
Jonah

>
>