RE: [PATCH 2/3] sim: callback: add printf attributes

["Aktemur, Tankut Baris via Gdb-patches" <gdb-patches@sourceware.org>]

On Tuesday, June 29, 2021 4:32 PM, Mike Frysinger wrote:
> On 29 Jun 2021 07:01, Aktemur, Tankut Baris wrote:
> > On Monday, June 28, 2021 5:25 AM, Mike Frysinger wrote:
> > > This helps these funcs get printf format checking coverage.
> > >
> > > The sim-io.c hack as a result is a bit unfortunate, but the compiler
> > > throws warnings when printing with empty strings.  In this one case,
> > > we actually want that due to the side-effect of the callback halting
> > > execution for us.
> > > ---
> > >  include/sim/callback.h | 12 ++++++++----
> > >  sim/common/sim-io.c    |  3 ++-
> > >  2 files changed, 10 insertions(+), 5 deletions(-)
> >
> > This patch resulted in the following build error:
> >
> > /path/to/sim/ppc/sim_calls.c: In function ‘sim_io_error’:
> > /path/to/sim/ppc/sim_calls.c:382:32: error: zero-length gnu_printf format string [-
> Werror=format-zero-length]
> >    callbacks->error (callbacks, "");
> >                                 ^~
> > /path/to/sim/ppc/sim_calls.c: In function ‘error’:
> > /path/to/sim/ppc/sim_calls.c:394:32: error: zero-length gnu_printf format string [-
> Werror=format-zero-length]
> >    callbacks->error (callbacks, "");
> >                                 ^~
> 
> are you forcing extra -W flags in your build ?
> -mike

No, I'm not.

Interestingly a fresh `configure --enable-targets=all; make` is now
giving me:

/path/to/sim/bpf/../common/cgen-run.c: In function ‘sim_resume’:
/path/to/sim/bpf/../common/cgen-run.c:254:5: error: ‘engine_fns$’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
    (* engine_fns[next_cpu_nr]) (cpu);
    ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/path/to/sim/bpf/../common/cgen-run.c:232:14: note: ‘engine_fns$’ was declared here
   ENGINE_FN *engine_fns[MAX_NR_PROCESSORS];
              ^~~~~~~~~~

Bisection points at

  78484bcab9a sim: bpf: enable -Werror usage

Thanks
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928