From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Tom Tromey <tom@tromey.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v2 1/7] Change how complex types are created
Date: Thu, 2 Apr 2020 14:59:50 +0000 [thread overview]
Message-ID: <SN6PR11MB28938FF417B024FFE57CCA8BC4C60@SN6PR11MB2893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200320215340.16749-2-tom@tromey.com>
On Friday, March 20, 2020 10:54 PM, Tom Tromey wrote:
> This patch changes how complex types are created. init_complex_type
> and arch_complex_type are unified, and complex types are reused, by
> attaching them to the underlying scalar type.
>
> gdb/ChangeLog
> 2020-03-20 Tom Tromey <tom@tromey.com>
>
> * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
> (read_range_type): Update.
> * mdebugread.c (basic_type): Update.
> * go-lang.c (build_go_types): Use init_complex_type.
> * gdbtypes.h (struct main_type) <complex_type>: New member.
> (init_complex_type): Update.
> (arch_complex_type): Don't declare.
> * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
> Make name if none given. Use alloc_type_copy. Look for cached
> complex type.
> (arch_complex_type): Remove.
> (gdbtypes_post_init): Use init_complex_type.
> * f-lang.c (build_fortran_types): Use init_complex_type.
> * dwarf2/read.c (read_base_type): Update.
> * d-lang.c (build_d_types): Use init_complex_type.
> * ctfread.c (read_base_type): Update.
Hi Tom,
The all-architectures tests (e.g. gdb.base/all-architectures-2.exp) started failing
after the commit (5b930b4538f "Change how complex types are created") because of an
assertion.
A manual way to reproduce the cause is
$ gdb -q
(gdb) set architecture c5
The target architecture is assumed to be c5
(gdb) ptype 1.0L
type = /gdb/gdbtypes.c:3037: internal-error: type* init_complex_type(const char*, type*): Assertion `TYPE_CODE (target_type) == TYPE_CODE_INT || TYPE_CODE (target_type) == TYPE_CODE_FLT' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Quit this debugging session? (y or n)
This GDB was configured with --enable-targets=all.
Thanks.
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2020-04-02 14:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 21:53 [PATCH v2 0/7] Update complex number support Tom Tromey
2020-03-20 21:53 ` [PATCH v2 1/7] Change how complex types are created Tom Tromey
2020-04-02 14:59 ` Aktemur, Tankut Baris [this message]
2020-04-02 19:17 ` Tom Tromey
2020-03-20 21:53 ` [PATCH v2 2/7] Add accessors for members of complex numbers Tom Tromey
2020-03-20 21:53 ` [PATCH v2 3/7] Change how complex types are printed in C Tom Tromey
2020-04-02 6:42 ` [committed][gdb/testsuite] Accept new complex print style in mixed-lang-stack.exp Tom de Vries
2020-04-02 13:30 ` Tom Tromey
2020-03-20 21:53 ` [PATCH v2 4/7] Change the C parser to allow complex constants Tom Tromey
2020-03-20 21:53 ` [PATCH v2 5/7] Implement complex arithmetic Tom Tromey
2020-03-20 21:53 ` [PATCH v2 6/7] Add _Complex type support to C parser Tom Tromey
2020-03-20 21:53 ` [PATCH v2 7/7] Fix value_literal_complex comment Tom Tromey
2020-04-01 20:10 ` [PATCH v2 0/7] Update complex number support Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB28938FF417B024FFE57CCA8BC4C60@SN6PR11MB2893.namprd11.prod.outlook.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox