Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Tom de Vries <tdevries@suse.de>,
	Luis Machado <luis.machado@linaro.org>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH][gdb/testsuite] Handle early_flags in gdb_default_target_compile
Date: Mon, 29 Jun 2020 15:24:46 +0000	[thread overview]
Message-ID: <SN6PR11MB289388225F90CCB2DFF97A54C46E0@SN6PR11MB2893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <6100c6f4-dfc9-26d1-c053-a9bd2995c1be@suse.de>

On Monday, June 29, 2020 4:32 PM, Tom de Vries wrote:
> This should be fixed by attached patch.
> 
> Any comments?
> 
> Thanks,
> - Tom

Hi,

The patch fixed the regressions that I was seeing.

+        if { [regexp "^early_flags=" $i] } {

I think there is a tab vs. spaces issue for this line.

Thanks.
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

      reply	other threads:[~2020-06-29 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 12:10 [PATCH][gdb/testsuite] Limit default_target_compile override Tom de Vries
2020-06-19 14:18 ` Tom de Vries
2020-06-19 15:46 ` Tom Tromey
2020-06-22 21:34 ` Luis Machado
2020-06-26 11:35   ` Luis Machado
2020-06-29 14:31   ` [PATCH][gdb/testsuite] Handle early_flags in gdb_default_target_compile Tom de Vries
2020-06-29 15:24     ` Aktemur, Tankut Baris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB289388225F90CCB2DFF97A54C46E0@SN6PR11MB2893.namprd11.prod.outlook.com \
    --to=tankut.baris.aktemur@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox