Re: [PATCHv3 3/3] gdb: Track the current frame for each thread

Eli Zaretskii via Gdb-patches
2020-09-26T06:16:25Z

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Fri, 25 Sep 2020 23:24:09 +0100
>
> +set restore-selected-frame [on|off]
> +show restore-selected-frame
> + This option is off by default. When turned on GDB will record the
^
Comma here, please.

> + currently selected frame in each thread. When switching between
> + threads GDB will attempt to restore the previously selected frame in
^
And here.

> + the thread being switched too. Executing a thread will cause the
> + GDB to discard any previously selected frame (GDB will select the

"the GDB" sounds awkward; please remove "the".

> @item
> -the current stack frame summary for that thread
> +the current stack frame summary for that thread, this is the inner
> +most frame for the thread, see @ref{set restore-selected-frame} to

Here, it is best to use @pxref, like this:

most frame for the thread (@pxref{set restore-selected-frame}) to

> +When switching between threads @value{GDBN} will select the inner most
^
Comma.

> +frame in the thread being switched too, see @ref{set
> +restore-selected-frame} to change this behaviour.

@pxref again.

> +If a thread has been running then when it stops the previously
^ ^
Two commas missing.

> + add_setshow_boolean_cmd ("restore-selected-frame",
> + class_stack, &restore_selected_frame_per_thread,
> + _("\
> +Set whether GDB restores the selected frame when switching threads."), _("\
> +Show whether GDB restores the selected frame when switching threads."), _("\
> +When this option is on GDB will record the currently selected frame for\n\
^
A comma is missing.

Documentation parts are OK with those nits fixed. Thanks.