RE: [PATCH] gdb: get jiter objfile from a bound minsym

["Aktemur, Tankut Baris via Gdb-patches" <gdb-patches@sourceware.org>]

Hi Mihails,

A few nits below.

On Monday, October 19, 2020 11:50 AM, Andrew Burgess wrote:
> * Mihails Strasuns via Gdb-patches <gdb-patches@sourceware.org> [2020-10-14 11:00:03 +0200]:
> 
> > This fixes a regression introduced by the following commit:
> >
> > fe053b9e853 gdb/jit: pass the jiter objfile as an argument to jit_event_handler
> >
> > In the refactoring `handle_jit_event` function was changed to pass a matching
> > objfile pointer to the `jit_event_handler` explicitly, rather using internal
> > storage:
> >
> > ```
> > --- a/gdb/breakpoint.c
> > +++ b/gdb/breakpoint.c
> > @@ -5448,8 +5448,9 @@ handle_jit_event (void)
> >
> >    frame = get_current_frame ();
> >    gdbarch = get_frame_arch (frame);
> > +  objfile *jiter = symbol_objfile (get_frame_function (frame));
> >
> > -  jit_event_handler (gdbarch);
> > +  jit_event_handler (gdbarch, jiter);
> > ```
> >
> > This was needed to add support for a multiple jiters in a following commits.

"a multiple jiters" -> "multiple jiters"
"in a following commits" -> "in a subsequent commit."? Or maybe just end the
sentence after "jiters".

> > However it has also introduced a regression, because `get_frame_function
> > (frame)` here may return `nullptr`, resulting in a crash.
> >
> > A more resilient way would be to use an approach mirroring
> > `jit_breakpoint_re_set` - to find a minimal symbol matching the breakpoint
> > location and use its object file. We know that this breakpoint events comes

Dot-space-space.
"events" -> "event"

> > from a breakpoint set by `jit_breakpoint_re_set`, thus using the reverse
> > approach should be reliable enough.
> >
> > gdb/Changelog:
> > 2020-10-14  Mihails Strasuns  <mihails.strasuns@intel.com>
> >
> > 	* breakpoint.c (handle_jit_event): and an argument, change how

"and" -> "Add"

Thanks for the fix.  It makes sense to me.

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928