From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120737 invoked by alias); 20 Aug 2015 20:30:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120726 invoked by uid 89); 20 Aug 2015 20:30:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: na01-bn1-obe.outbound.protection.outlook.com Received: from mail-bn1on0078.outbound.protection.outlook.com (HELO na01-bn1-obe.outbound.protection.outlook.com) (157.56.110.78) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Thu, 20 Aug 2015 20:30:39 +0000 Received: from SN1PR0701MB1853.namprd07.prod.outlook.com (10.162.100.158) by BN3PR0701MB1606.namprd07.prod.outlook.com (10.163.38.29) with Microsoft SMTP Server (TLS) id 15.1.243.23; Thu, 20 Aug 2015 20:30:36 +0000 Received: from SN1PR0701MB1853.namprd07.prod.outlook.com ([10.162.100.158]) by SN1PR0701MB1853.namprd07.prod.outlook.com ([10.162.100.158]) with mapi id 15.01.0231.024; Thu, 20 Aug 2015 20:30:36 +0000 From: Marc Gauthier To: Pedro Alves , Max Filippov , "Joel Brobecker" CC: "gdb-patches@sourceware.org" , Maxim Grigoriev , Woody LaRue Subject: RE: [PATCH v2] xtensa: initialize call_abi in xtensa_tdep Date: Thu, 20 Aug 2015 20:30:00 -0000 Message-ID: References: <1440075160-13310-1-git-send-email-jcmvbkbc@gmail.com> <20150820130736.GF4571@adacore.com> <55D5E088.3050807@redhat.com> In-Reply-To: <55D5E088.3050807@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=marc@cadence.com; x-microsoft-exchange-diagnostics: 1;BN3PR0701MB1606;5:3hMsZZsEBjXnu7H4KW+2GA89D3SeVKoWqLq59utv9zCtXulzAaL3X1VoKLAdUvvbzyRgYth/VSMF8VyIFRPIGH8rsI5zqyg4R2jfxyaBR6UD529QPJ9ZywEpZRxDmZnarbWafuU01c7uhp8nRssG1g==;24:cJwe5htGkVisM3XViT6wDH1KwiR62wo0n1odado7yn9HGbo2hemtoKjaIrL6d0NViHpU11JdOU5kdILXyG5vO8lixOac9XEpOwYAwrS/Wp8=;20:r48k7cTqzYV3E2Q+UJOxaOEdfAClFAhmmmMO9WW8JgJ9zcmPRsCgEDq39gsOtYp3rvdAETgw0z4pD14O7y2fzmOb4q1dCGKYHP8ebKfwbq/gVH5AOfzrOGdzFYQ95qMbYDoXAeMsnn8PVeBWIi/8nYNpNVtog3U5I2uS0CoRFEk= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1606; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:BN3PR0701MB1606;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1606; x-forefront-prvs: 0674DC6DD3 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(189002)(377454003)(199003)(479174004)(36092001)(76576001)(46102003)(122556002)(5001960100002)(76176999)(106116001)(99286002)(40100003)(93886004)(81156007)(106356001)(2656002)(87936001)(74316001)(107886002)(4001540100001)(5001860100001)(189998001)(50986999)(5001770100001)(33656002)(101416001)(54356999)(97736004)(5001830100001)(86362001)(66066001)(64706001)(77156002)(2950100001)(105586002)(62966003)(92566002)(68736005)(102836002)(5003600100002)(77096005)(5007970100001)(5002640100001)(2900100001)(10400500002)(5004730100002)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0701MB1606;H:SN1PR0701MB1853.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: cadence.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2015 20:30:35.8229 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1606 X-SW-Source: 2015-08/txt/msg00560.txt.bz2 UGVkcm8gQWx2ZXMgd3JvdGU6DQo+IE9uIDA4LzIwLzIwMTUgMDI6MzcgUE0s IE1heCBGaWxpcHBvdiB3cm90ZToNCj4gDQo+ID4gQWN0dWFsbHkgaXQncyBh cyBzaW1wbGUgYXMgdW5wYWNraW5nIGEgdGFyYmFsbCB0byB0aGUgc291cmNl IGRpcmVjdG9yeSwNCj4gPiBhbmQgd2UgaGF2ZSBpdCBhdXRvbWF0ZWQgaW4g dGhlIGVudmlyb25tZW50cyB0aGF0IGJ1aWxkIHRvb2xjaGFpbnMsDQo+ID4g bGlrZSB0aGUgQnVpbGRyb290IG9yIHRoZSBjcm9zc3Rvb2wtTkcuDQo+ID4N Cj4gPiBUaGUgaWRlYSBiZWhpbmQgdGhpcyBpcyB0aGUgZm9sbG93aW5nOiBY dGVuc2EgY29yZSBpcyBjb25maWd1cmFibGUsIGENCj4gbG90DQo+ID4gb2Yg aXRzIHByb3BlcnRpZXMgbWF5IGJlIGNoYW5nZWQuIE5vYm9keSBldmVuIHRy eSB0byB0ZXN0IGFsbCBwb3NzaWJsZQ0KPiA+IGNvbWJpbmF0aW9ucyBvZiBj b25maWd1cmF0aW9uIG9wdGlvbnMgYW5kIG5vYm9keSByZWFsbHkgY2FyZXMg aG93IG1hbnkNCj4gPiBYdGVuc2EgY29yZSBjb25maWd1cmF0aW9ucyBleGlz dCwgcGVvcGxlIHRoYXQgZ2VuZXJhdGUgWHRlbnNhIGNvcmUNCj4gPiBvbmx5 IGNhcmUgYWJvdXQgdGhlaXIgcGFydGljdWxhciBjb3JlLiBXaGVuIHRoZXkg Z2VuZXJhdGUgaXQgdGhleSBnZXQNCj4gPiBhbGwgdGhlIGZpbGVzIHRoYXQg bmVlZCB0byBiZSBjaGFuZ2VkIGluIHRoZSB0b29sY2hhaW4sIHRoZXkgYXBw bHkgdGhlbQ0KPiA+IGFuZCB0aGV5IGdldCB0aGUgdG9vbGNoYWluIGZvciB0 aGVpciBwYXJ0aWN1bGFyIGNvcmUuDQo+IA0KPiBIb3cgYWJvdXQgbWFraW5n IHRoZSBjb25maWd1cmF0aW9uIGdlbmVyYXRvciB0b29sIG91dHB1dCBzb21l IGRhdGENCj4gZmlsZSB0aGF0IGdkYiB3b3VsZCBzb3VyY2U/DQoNCkFzIEkg dW5kZXJzdGFuZCBpdCwgYSBzaW1wbGUgZGF0YSBmaWxlIGlzIHByb2JsZW1h dGljLiAgRm9yIGV4YW1wbGUsDQpjdXN0b21lcnMgYWRkaW5nIGN1c3RvbSBl eHRlbnNpb25zIHRvIGFuIFh0ZW5zYSBwcm9jZXNzb3IgY2FuIGRlc2NyaWJl DQppbnN0cnVjdGlvbiBvcGVyYW5kIGVuY29kaW5nIGFuZCBkZWNvZGluZyB1 c2luZyBhcmJpdHJhcnkgdmVyaWxvZw0KZXhwcmVzc2lvbnMuICBBbHRob3Vn aCB0eXBpY2FsbHkgc2ltcGxlLCB0aGVyZSBpcyBjdXJyZW50bHkgbm8gY29u c3RyYWludA0Kb24gdGhlc2UgZXhwcmVzc2lvbnMsIHNvIHRvIGZ1bGx5IHN1 cHBvcnQgdGhpcywgdGhleSBnZXQgdHJhbnNsYXRlZCBpbnRvDQpDIGNvZGUg d2hpY2ggR0RCIGFuZCBvdGhlciB0b29scyBjYW4gdXNlIHRvIGFzc2VtYmxl IGFuZCBkaXNhc3NlbWJsZQ0KWHRlbnNhIGluc3RydWN0aW9ucy4NCg0KU28g dGhlIG1vcmUgbmF0dXJhbCAiZGF0YSBmaWxlIiB0byBkZXNjcmliZSBhIGN1 c3RvbSBwcm9jZXNzb3IgaXMgYSBzaGFyZWQNCmxpYnJhcnkgb3IgRExMLiAg VGhpcyBpcyB3aGF0IENhZGVuY2UncyBUZW5zaWxpY2EgdG9vbHMgdXNlLiAg SG93ZXZlciwgaW4NCnRoZSBmYXIgcGFzdCwgdXBzdHJlYW1pbmcgdGhpcyBh cHByb2FjaCB3YXMgcHJvYmxlbWF0aWMgZ2l2ZW4gdGhlIHZhcmlvdXMNCnBy b2plY3RzJyBhdmVyc2lvbiB0byBkeW5hbWljIHNoYXJlZCBsaWJyYXJpZXMs IHdoaWNoIGFyZW4ndCBzdXBwb3J0ZWQNCm9uIGV2ZXJ5IGhvc3QgYXJjaGl0 ZWN0dXJlIChub3QgYWxsIHN1cHBvcnQgYSBkbG9wZW4gZXF1aXZhbGVudCku DQoNCk1pZ2h0IGl0IGJlIHBvc3NpYmxlIG5vdyB0byBpbnRyb2R1Y2UgdXNl IG9mIGEgZHluYW1pYyBzaGFyZWQgbGlicmFyeT8NCklmIHRoYXQgd29ya3Mg Zm9yIEdEQiwgbXkgbmV4dCBxdWVzdGlvbiB3aWxsIGJlIGFib3V0IGJpbnV0 aWxzIGFuZCBnY2MgOi0pDQoNClRoYW5rcyENCi1NYXJjDQo= >From gdb-patches-return-125446-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Aug 21 03:14:32 2015 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 113236 invoked by alias); 21 Aug 2015 03:14:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113035 invoked by uid 89); 21 Aug 2015 03:14:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-oi0-f52.google.com Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 21 Aug 2015 03:14:04 +0000 Received: by oiev193 with SMTP id v193so34644629oie.3 for ; Thu, 20 Aug 2015 20:14:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=gHXof6aobVxy4nXT9CdRMEiYD8PK0BJQgeUk97n2+Gk=; b=A73kXWrd1KLRnnswR/Wxlh35p8y9yQ7WuGxG+CPypcspPwPRsZ//pOLXW0HTTBM/NW 2lE6ZM5ETawyuFdWeJAwbkAQOQ9nKoEAPfSraSZapzrqCFOn2K6WE88wsV/dCjCw0VzW 5xT1GiEssVxvL8lTi3qbTEQP+cInR9jWLp4zt49+mXFWmG6mNA+ge5SV5ST5NA3t9LOT Ool7/lpyKaEAEWSi0V2NHR8+79GmaX4h8pT3WkLpnqlCb/WGWP2D4IEsAYDQfOtj3SnI fuUGO6UrsaB94c8eV7SWsyV+WFKvp1V7l7Fy6G0wKM5szd//NisgHJWTzWRZ2TgPg2Ov XrPg== X-Gm-Message-State: ALoCoQk9QmXdrDGefXNW3Aj8aANnzYjn07fxQzYntvvaDl4apZF2mjmvSSic+0SmlgpOAUe5BI7N X-Received: by 10.202.69.4 with SMTP id s4mr906757oia.63.1440126842956; Thu, 20 Aug 2015 20:14:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.115.105 with HTTP; Thu, 20 Aug 2015 20:13:43 -0700 (PDT) In-Reply-To: <55D6125C.7080408@redhat.com> References: <1439959138-9326-1-git-send-email-patrick@parcs.ath.cx> <55D6125C.7080408@redhat.com> From: Patrick Palka Date: Fri, 21 Aug 2015 03:14:00 -0000 Message-ID: Subject: Re: [PATCH] Remove fields curch and cur_line from TUI_CMD_WIN To: Pedro Alves Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-08/txt/msg00561.txt.bz2 Content-length: 2294 On Thu, Aug 20, 2015 at 1:46 PM, Pedro Alves wrote: > On 08/19/2015 05:38 AM, Patrick Palka wrote: >> These fields are currently used to track the location of the cursor >> inside the command window. But their usefulness is questionable because >> ncurses already internally keeps track of the location of the cursor, >> whose coordinates we can query using the functions getyx(), getcurx() or >> getcury(). It is an unnecessary pain to keep these fields in sync with >> ncurses, and their meaning is not well-defined anyway. For instance, it >> is not clear whether the coordinates held in these fields are >> authoritative, or whether the coordinates reported by ncurses are. >> >> So to keep things simple, this patch removes these fields and replaces >> existing reads of these fields with calls to the appropriate ncurses >> querying functions, and writes to these fields with calls to wmove() >> (when necessary and applicable). >> >> In the function tui_cont_sig(), I removed the call to wmove() entirely >> because moving to (start_line, curch) makes no sense. The move should >> have been to (cur_line, curch) -- which would now be a no-op. >> >> Does this seem like a step in the right direction? These fields like an >> unnecessary abstraction. >> > > Sounds like a good idea to me. > >> Tested on x86_64 Fedora 22, with seemingly no obvious regressions. >> >> gdb/ChangeLog: >> >> * tui/tui-data.h (tui_command_info): Remove fields cur_line and >> curch. >> * tui/tui-data.c (tui_clear_win_detail) [CMD_WIN]: Don't set >> cur_line or curch, instead call wmove(). >> (init_win_info) [CMD_WIN]: Likewise. >> * tui/tui-io.c (tui_puts): Likewise. Don't read cur_line, >> instead call getcury(). >> (tui_redisplay_readline): Don't set cur_line or curch. >> (tui_mld_erase_entire_line): Don't read cur_line, instead call >> getcury(). >> (tui_cont_sig): Remove call to wmove. >> (tui_getc): Don't read cur_line or curch, instead call getcury() >> or getyx(). Don't set curch. >> * tui/tui-win.c (make_visible_with_new_height) [CMD_WIN]: Don't >> set cur_line or curch. Always move cursor to (0,0). > > OK. Thanks for reviewing! Committed. > > Thanks, > Pedro Alves >