From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FFCjMjNkRWoWiSEAWB0awg (envelope-from ) for ; Wed, 01 Jul 2026 15:02:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=0FAXvTAW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BA89A1E024; Wed, 01 Jul 2026 15:02:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 967FB1E024 for ; Wed, 01 Jul 2026 15:02:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 53B394BA23CF for ; Wed, 1 Jul 2026 19:02:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 53B394BA23CF Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=0FAXvTAW Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazlp170100005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c111::5]) by sourceware.org (Postfix) with ESMTPS id A6FE34BA2E10 for ; Wed, 1 Jul 2026 19:01:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6FE34BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A6FE34BA2E10 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c111::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1782932502; cv=pass; b=vN+PbzV9ew0bQ5iKk3zGO+d7KM8olEubMCaK7mlR2SZlh6TkX5VF6f6Ss5LRbvxdm3Nfi/zWKrCXCpyJIvSIyEIlegQOtsh7lzRIYEy3pPu/lGYLzgYDp75iX7wxO+aWynih537NMNsKi0ObKKRPiQhoYq0xdoUoLFCXwffgOw4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1782932502; c=relaxed/simple; bh=5NnbvjEsFp2VTiQrvBJcKx0spH4ikVsyT3paowh9u7U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bx4oyHP6HpxiW/tFeXVEZMD3OxWXqXbrCJHkhADouNRL/wxDuOPy6rGIgVukOXHcwSjxEhe2mQy8NOWH5VH6ia35cnQrAoJNFhUmWcavByvkTk4zclScqXi5fOgaaxO7v4sjv3LWugLGpnaViNQfyZnKiAvfKjWddHJsWxy5xh8= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=0FAXvTAW DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A6FE34BA2E10 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ucB38nt7XCdBje3HeT4cHh2B+5x8c9pj+HgbtXzpjl+mFvSgAkTrYipm0quLq1L7MvCWxqvA7vBViSAgko0iLxY4nQQXf9Doyq3frhfkOxvoYH1TO1JZXJksXK4G45t9FZ1eEwHfI8IZtm7xYqv5y6sDJN7poIEZUHvrgFC3xglKoE3AJLmzWUt/cXr6jbvaiQrfAW6NwAE6la7U8GlqyZRNQ4Xjx0tNmVbxIwGlpGiIAWApvPw+kktzF9Y5WxV+GhX/sCvRlynyzOrtZzH3gFkFC+eLNAHKye/7V8CVT0tewSbBf1ynlskw8FeLOoKal6RiZazL4JHprcFmfmTcxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+A7S5hFCsqS3Vdckyua+D6La50tefM23+Ux6vZ+odC8=; b=wY7toMXYUAvrfejS+mO71nWUXE2dWtTIacDfli/rHBmDI/zbDwLLwlUW/1exlrlZNuQzy/Waay7AnKaoJY+7B4LBqniI4vefxseBMWOAfwxLQnRGrMq1z3g9SNSP6a2rKLwqaDzBgY3kH8ioSwfLHyBQOWnpGnslhqUjrjnF3dbmO3CzAWf1zqNXhQNqDOiuczM7KhN2uqdLRvq1sGG+IkJkZwAfmJtvercwEL3Riwm2MpehoVs18sqLDt9a7ajUoGvm95OnIt+tHuBa44D6psa8WOS1y/hWNQvCGaifQbI9AWy+Na6VwHCSMNWblV7RCc/KxZWjP7BIoRJp1abdUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+A7S5hFCsqS3Vdckyua+D6La50tefM23+Ux6vZ+odC8=; b=0FAXvTAW9L0nZw0Fu469WdkvWBaIY+5yU/K3trPZfHzh2W3TFu2y9uk7vzwd1tL77tleG4tiGViIN63UYlg37Q5MxYOJM/hI5JNTQx+Fufzox1coUjD80M3hx5gN7Waaip7vUs4sdfheaQAt8Xpd1hVi8rdZPbu/vpdicKPEkfg= Received: from SJ5PPF816B88375.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::99b) by DM6PR12MB4284.namprd12.prod.outlook.com (2603:10b6:5:21a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.9; Wed, 1 Jul 2026 19:01:35 +0000 Received: from SJ5PPF816B88375.namprd12.prod.outlook.com ([fe80::eabe:29f4:4ae8:e793]) by SJ5PPF816B88375.namprd12.prod.outlook.com ([fe80::eabe:29f4:4ae8:e793%6]) with mapi id 15.21.0159.018; Wed, 1 Jul 2026 19:01:35 +0000 From: "Machado, Luis" To: Pedro Alves , "gdb-patches@sourceware.org" CC: "guinevere@redhat.com" Subject: Re: [PATCH v2] gdb: replace alloca with gdb::unique_xmalloc_ptr in remote-fileio.c Thread-Topic: [PATCH v2] gdb: replace alloca with gdb::unique_xmalloc_ptr in remote-fileio.c Thread-Index: AQHdCWuAFPYq4jF/o0i559B84WsNYLZY+bSAgAALFFw= Date: Wed, 1 Jul 2026 19:01:35 +0000 Message-ID: References: <20260630095238.1700797-1-luis.machado@amd.com> <20260701150714.3124191-1-luis.machado@amd.com> In-Reply-To: Accept-Language: en-150, en-US Content-Language: aa X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-07-01T19:01:34.282Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=1; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ5PPF816B88375:EE_|DM6PR12MB4284:EE_ x-ms-office365-filtering-correlation-id: 4ff6cb6e-867e-47c7-532f-08ded7a32c1b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|23010399003|376014|366016|1800799024|38070700021|6133799003|56012099006|11063799006|4143699003|22082099003|18002099003; x-microsoft-antispam-message-info: kUwHv9yMIq78H0B0TveVJ2MQlEQa6wdrHQRWYQvdGEOBGdauoAljvFeXsDRk1QAyjd2RaUwFMAGNlQ3H2PZeyQQOZYTkQB9gw8fgQcrg0YSmL9sGXmfn4eb6u0oG3auG5RG9ouH+WCLaBfoHPhCzxX6igFSe3YQSJ2yrz6VdMAvnoE3Hnc9JiWC4yHhjsXc+WgDQdXhcNL39zC2nElAx6bd9X0hQEZH4SL87SXGIn5MSPqdZpPcNQp/7ThfFWpwcjUgBdbGR0w50rY6OMaIfVCQ+fupGr0dxFNVmE76YD0pxf9+Karybv6ql7IadlQfJJ1zr8+D0F6jT3Dov6ZqmenaZ5VqD7S6lmeuvFgICpBjCvLs0EA0Wim5e69DIRd7JpSdtk00jHe43/sHbtieyNvqy2pno9okJc5DgdcaHsp52YtbPPjNG3WovDKWpiDmBgAcU8xhj/WWBoGM1gugEMVW6NHBvpwjZ4ftKEOAeTpehy6V4DoKSa8tQZo89JIoJ9fIzD4IK/MdG7dZp1chPtYVe17ICJ0pQ+atn0DId0OO1GkQ5LFFC52C3Q5xl3fM/eVE5yfv3IwpaKYjVOECM2g+k9XpJG2PRY7uH22qBPikBNG2ezInE9e2oI9/bg5cozxq23QkFp1IAeuj1xnhN6AHroNYT6TTjk1gNmGKVGqfMZsuQvlbkMRx6MWRzi47qH22tRhrL6x180xgNKqLYuUR5C1XLoM6pBK9df30Q3yw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ5PPF816B88375.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(38070700021)(6133799003)(56012099006)(11063799006)(4143699003)(22082099003)(18002099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hqEj4qkQiZkxQuFAV+g95E7FPLXOgbBSM/FxFXzRueqyt6TpNtzq49qJvmgU?= =?us-ascii?Q?6zimpMKIaup1pkfptNssCHVYMGIFE/6802KJvPNtIHucqRJQrFi9uetWSGys?= =?us-ascii?Q?C8EoUq/MIvtKCAX7qVcRzF98HoDfYosZMlA1dDT0ahZm2QrJWNN9OM1jgfum?= =?us-ascii?Q?YY+IQCO3Y3MCmbx/n410rFhiaAn6P6N3Bi24NrN6qqkKHck5F3b5Io+7TG8h?= =?us-ascii?Q?PnWkD50U8kTrq5H7kBw+HBlHYUYgGpuiKl7O5kp6gHjY4fCejjWwKI999KBl?= =?us-ascii?Q?dpVL+7AH6PXq1gz9MDjGfTT2pz7IcaM52z/m4AtwGt9vzDt57uQV8JHkF/Dx?= =?us-ascii?Q?IjkjuFgpBZImNt5YPJbHfTkO+PXGDpwcWeJZbUBPMhKuy9V5MN6F/a0H65CZ?= =?us-ascii?Q?3khdQztrWhNb0jtdHVmvgP5ZMZjcGOiP7uRN3QrL25qP8+1wzOaJtFcsjRp2?= =?us-ascii?Q?bJ5hCV0PR0a+5ISJrY+D75yraZpi5Flw5reuyUCPLafyXaAiaL1LkImV4puk?= =?us-ascii?Q?I/QWfdYGUXMl5rrbhcvgB7CI/9z9N94d3tE1CS39XCHYYyuWOWPiMEAGVVfw?= =?us-ascii?Q?00Xh1VzRxfUYuasNPMH0ZgWyBBprcyuXT6JVqShv0KQ6EY7dPrxIilzykYFv?= =?us-ascii?Q?I8iOMaZL0pk8BFK5z09TeFYi+dlFFCUx+5bVBqj6IaOhT3GN0Pu6obJY9RfY?= =?us-ascii?Q?8o4ywqeP+KHTrYMFUkuHaavlQX4JumojiZJpA9/lrQ7OgkqQamcsXepznN5D?= =?us-ascii?Q?2HIMuqPru6WlvLcGJlBiMKHOw2B5hNxs3TrKjsW+IXM1OCr/462Y8WnS8g6F?= =?us-ascii?Q?uEN/zbptn9cwUfapOA8mKMYZch56Xcz1bY+0b/cEgp6LpW+oXf0XWRmJvBMi?= =?us-ascii?Q?+MQxx7P2EfRJnvWQE4qVuiQuinzo1u6cFXUvGkqoW4iQ5qCuqnkHTt2YMmoh?= =?us-ascii?Q?MEOBUhdaRPPAwk+z7LvRZ/Fi+haiZgVfFc0oBHRaOnwm2hitxWnyyTbeRMXI?= =?us-ascii?Q?ZVtADRy7L+sCzekvHpoxXCSjqRqZ5+zsr/qe0oMe7N8X9cv3hVshhedCHC8R?= =?us-ascii?Q?ceu/uu5lPZVd2BZHm2uQ7aupaXE1lXzbSDkmde3dpTz7rz9rjOnPurcdqx/1?= =?us-ascii?Q?ORmSY9bqrTtTRPuI9e6RPE662AE90ciqdVuD/ifPr4fHNqS6IROi42sicvxP?= =?us-ascii?Q?R0fDlYTq1uMcDZk2UUwuEH6API9J3I7ZUnakJ8tc6nmN4cyM0FlHN9xwxKoA?= =?us-ascii?Q?CoWjIKilFmfyuRWiqZ4OD1Lh/ZN75h0KVH5wBO5MsqF5rAG39lbqgPnq+kn7?= =?us-ascii?Q?ts70KUk3jcGkKFNzCnS5AvTE5cqFRpcbytpCq0JiemmQ3oqUOBDQX5H8Z6oJ?= =?us-ascii?Q?06c1UZwR0lcHU6k1UhSLroDtyizif7VmxnkoXSOCbRgal70y2j1ETLozar9U?= =?us-ascii?Q?47bL/udwSBvebSMmn58dGG/XqgVMAgu3CmIaRHCbzQy1UhwEwqC71c3sRnhm?= =?us-ascii?Q?Smy/AwM3xAm9T5v9mEJfv4D7JSQ25JykQdisFDkcVJUWLZW7Xgon+TglCkcP?= =?us-ascii?Q?lCjwXiU8aJl9xiili1oCXkZyIjmodl/8yUoaqojqjRbWBEVtwujAHZrbLrFV?= =?us-ascii?Q?iCYwbhRFVDqXxHthGxr/JiF+U7i48oi76Bv4JIuKddHSxGLs8Au0dfrptmoC?= =?us-ascii?Q?9zNmvoRnmSYCSOgx/jcvSBfZr3qaX7nbjunxFefvPxUbdTzO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ5PPF816B88375.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ff6cb6e-867e-47c7-532f-08ded7a32c1b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2026 19:01:35.2062 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: im6PwCBdQUwhdfStVXaSktt0WoqNJ6ihD1OBEFvNhigUo2379xT0OdEfjuE5N54OI/zpjHKlUeVXtXCHskSjHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4284 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org At some point I think I did have the INT_MAX boundary check, but dropped it= for some reason. Probably in favor of the larger 64-bit value.=0A= =0A= V3 on its way.=0A= =0A= Thanks,=0A= Luis=0A= =0A= ________________________________________=0A= From: Pedro Alves =0A= Sent: Wednesday, 1 July 2026 19:20=0A= To: Machado, Luis; gdb-patches@sourceware.org=0A= Cc: guinevere@redhat.com=0A= Subject: Re: [PATCH v2] gdb: replace alloca with gdb::unique_xmalloc_ptr in= remote-fileio.c=0A= =0A= Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.=0A= =0A= =0A= On 2026-07-01 16:07, Luis Machado wrote:=0A= =0A= > char *c;=0A= > LONGEST retlong;=0A= > @@ -211,6 +213,11 @@ remote_fileio_extract_ptr_w_len (char **buf, CORE_AD= DR *ptrval, int *length)=0A= > *buf =3D c;=0A= > if (remote_fileio_extract_long (buf, &retlong))=0A= > return -1;=0A= > + /* Reject negative lengths and zero (unless the caller permits it for = the=0A= > + Fsystem NULL-cmdline sentinel). Oversized names are caught by the= =0A= > + syscall. */=0A= > + if (retlong < 0 || (!allow_zero_length && retlong =3D=3D 0))=0A= > + return -1;=0A= =0A= Given this no longer limits on PATH_MAX, RETLONG can be higher than INT_MAX= =0A= and still positive, and then the cast below yields bad values:=0A= =0A= > *length =3D (int) retlong;=0A= =0A= Like, e.g., (int) 0x80000000, wraps to INT_MIN (a negative length).=0A= =0A= So we should limit on INT_MAX.=0A= > + /* Valid: largest positive length accepted (technically INT_MAX). */= =0A= > + SELF_CHECK (parse ("1/7fffffff") =3D=3D 0);=0A= > + SELF_CHECK (length =3D=3D 0x7fffffff);=0A= =0A= This test would have caught it, I think:=0A= =0A= SELF_CHECK (parse ("1/80000000") =3D=3D -1);=0A= =0A=