From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0UxmNnlFNWroXw8AWB0awg (envelope-from ) for ; Fri, 19 Jun 2026 09:34:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Ag25uQZ/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D7E8E1E098; Fri, 19 Jun 2026 09:34:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E867F1E024 for ; Fri, 19 Jun 2026 09:34:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 604EA4BAE7C8 for ; Fri, 19 Jun 2026 13:34:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 604EA4BAE7C8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Ag25uQZ/ Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010021.outbound.protection.outlook.com [40.93.198.21]) by sourceware.org (Postfix) with ESMTPS id DE22B4BA799F for ; Fri, 19 Jun 2026 13:34:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE22B4BA799F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE22B4BA799F Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.93.198.21 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1781876061; cv=pass; b=huhTSX1K3Z+wFGs80hEIhTYNsZOHuJlT8azSB+swYNNa+vNF9PDlEuRyQY8x3t4D6f680EFbBzFCgDbO9B7TgImfirl12kqRcmU7odv2/eSoijVOMPxZzyCBpVWEyw8xUB4nbRdiT2B1L5cX58EGzsdq/h68xMbRFNtBP9uBafQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1781876061; c=relaxed/simple; bh=YSZlbyyWze76bvlOuVYl0DpAeEzy9k2tnSZ8Y7vFtdE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=q7GU+r6jnYDQIkOsocXwmCXLoXhbjPcvs692YDswQufZgjJTQsp903fNKS7sahYm2KPuOJSKrFsixYS/508QNpmKW/b9f4wYGbuJbyHJlR64fuCvwNGMerKXGV0P1PKMyKPMFspsd6wuhbN6nPQZFfsCFKoGGNyOSq/nNHw+bDQ= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=Ag25uQZ/ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DE22B4BA799F ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gL1LrLF+ec05rzm3oI0IcRpNmKZuifpbv+lvTCxuQ/ob6QTifLm/rjw3MYKkdl5owfnw5qXlkSt7TszKeq2IEX8jMA/waXtpZLwXNycS3GTZDFQxVqE1ju+VxuzftigF+s8K2AijeXyrel0XpIBkenO1BT1Z449WUk4ZSpJj20G+X7KfUcNdqyWzup1ETYO2NDHj5k+DaNYFPbnDuc+mw68WqSpmoCkaca5zwO81V8BcY6MnXWzbRx5qQi4832uQEuOnihXn0aLk/0xODFTk3j5/SPHnYrAlJEb26rlfKTISRB+V+DTRdeLNcePatQbcSC4mizeQGZWDj0+pxJJoJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cypFeKAb9iL0Xz/KqMb/5iTH8FQjCKQu+exnunmYZVc=; b=mEF4aFM1RF/3pn81LdcPLhuP2rYsHzYxNHKsLgAbuJreD/ClTguBcl6pn8Lk+k8uzkdjde1rf0k8z5aBqPe7CKy6Yt6d6Bj74rs3m1YjkMJ8mZqsU+IWICFhl2yoNcMASGS56PPthK/a3f2pMUXs2Y3uVzZ7xNrqMIRgYab6N9+tZ+RUI6+Bb5wZG6BfF9rKAPg5GYkjr8Tos9anrqBv3per727HpVJNkGtlmyQRZXVrJrG+AUyJAt9WdZw+k6VoAjR6Lvtvp75HFkUUZyZON8VhBHNIzcd6H1a/7NGh8lAJ+gBS1bS/CcL8mgLK3lYNkW4J5cTasP3iMjGp1IMS/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cypFeKAb9iL0Xz/KqMb/5iTH8FQjCKQu+exnunmYZVc=; b=Ag25uQZ/OlsU5zRCQEQhxQEcUs4A1MFA6oSyhxiCVioOqhHDC+VxxKKqAHTwLx0Q3VSAxTEMXzkbyutkt0KhoQyUYyBvednHhnNiiGVAnsnvvk77+XboGxwkM6aJmp5SiuuqTUB3moQomK9Tvn06CtLiIXd9nd+WJuEJC7/+E/w= Received: from SJ5PPF816B88375.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::99b) by LV2PR12MB999096.namprd12.prod.outlook.com (2603:10b6:408:353::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.11; Fri, 19 Jun 2026 13:34:14 +0000 Received: from SJ5PPF816B88375.namprd12.prod.outlook.com ([fe80::eabe:29f4:4ae8:e793]) by SJ5PPF816B88375.namprd12.prod.outlook.com ([fe80::eabe:29f4:4ae8:e793%6]) with mapi id 15.21.0113.015; Fri, 19 Jun 2026 13:34:14 +0000 From: "Machado, Luis" To: Guinevere Larsen , "gdb-patches@sourceware.org" Subject: Re: [PATCH] [testsuite] Log gdb_do_cache misses only, not hits Thread-Topic: [PATCH] [testsuite] Log gdb_do_cache misses only, not hits Thread-Index: AQHc/8QTkrRffbISjEm2W8b70SbD97ZF3DaAgAAEv/w= Date: Fri, 19 Jun 2026 13:34:14 +0000 Message-ID: References: <20260619081655.2166546-1-luis.machado@amd.com> <6cbaf2d8-0d2e-45bd-b929-8570316ef755@redhat.com> In-Reply-To: <6cbaf2d8-0d2e-45bd-b929-8570316ef755@redhat.com> Accept-Language: en-150, en-US Content-Language: aa X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Enabled=True; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_SetDate=2026-06-19T13:34:13.454Z; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Name=AMD General; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_ContentBits=1; MSIP_Label_198e8dea-a4f3-4850-b16a-fd6d2b1302b4_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ5PPF816B88375:EE_|LV2PR12MB999096:EE_ x-ms-office365-filtering-correlation-id: 295f85f9-224b-4774-a6b9-08dece077451 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|23010399003|1800799024|376014|22082099003|18002099003|56012099006|4143699003|11063799006|38070700021; x-microsoft-antispam-message-info: tjwVtMKYcIgLXMbLJgtJJ3GE75vec7mubzV/CovvKVx9uMUs04eY2agGjlWXxIDzG66voyJvLGECxDZ8iYD32ebc3zvT+qjc1FKAJn6NpDy1f9DwacpaxccgyhSDAvDhh6oO+5YWEg8/jjUysNtAQzdmFvw9jjDSiU7NkzKoUZ13+7Eg5OTUkT//BTflH5JmBd1B6c8jMRYf46C67QK5rmeJxVmHUEYJPqW8ZX+NcWgh7nI+JfOfladeTuDjugcc/+uWPZGzc7MHdQP0RWMiGZsSi3hAPT1I5T+D80C/a6l581F5Dfi8rfVBDI7GZP3iO7OyAPOLa0AdrZkLnHu7xWC0Qs9PQT3szcanN+G2OeOQOipcFKYHCpTuD6dDSAwGh71m4Wp4MEIYPXu5+T/raDCzC1g/iTSKr5AJYWiv5l+gh2QbAcLAFSF25imbYAlWZozcg8zvjrRvePAww/F0LS9Cs4lP6IK/6IJYQBYcu/LfTG4fnrMtmhFJPRsVLqAKDhM2TA5zWUAwJD/1VNamGsMS4/RJOWQlCsKvFl/UhUq53PMY89b/pmuRmNYdAe3Z42xKnqhjIF2o/pRMzh2GiVuS7qbbK53woivN7DPK7lMJXtwzw4vcGRG1PV/r3Fx9aPHZxgXXaAqBO3jBptVLaL69PT9Qiv6yyBfvegqq9Pm+xlbkd7fW1QmhFAAbkw5WEuXPgve1Exyy6ro21rlUqsLMCcfyWzUJ67GK0ShGYzk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ5PPF816B88375.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(23010399003)(1800799024)(376014)(22082099003)(18002099003)(56012099006)(4143699003)(11063799006)(38070700021); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L8PO26+DLIoIMfrFZgUg3yxBN9BIuMqBezhjvHrSB8pY/rpowTFJwT+YpoV4?= =?us-ascii?Q?K8p4OTBNRH5m2j5NZ4dU8RadVIuv2Av5P1V+gtjkfx1CoTiRT3km2jsCcpmC?= =?us-ascii?Q?jTFykELXwa8FzFA6grmZyULjU1P4qQgorv1qm+zbCDjqhm9phymWcTUpvCrl?= =?us-ascii?Q?+PQx4vZX1p9MnP1rbbWkYK6OycuhQxBXTTL7tAhtkMTj9pWe91uJeB98DAsr?= =?us-ascii?Q?EJ89XzKSaXI+kjZ5/FMX9OtFeZcBx2QExJCUYCmtuWsrLna+P9SIoDYoD4B2?= =?us-ascii?Q?DfVf34lmvFmq1+M6rcRTlAEgDDepwOQrYk/BqhWD2Ub7RGyf7BBUgqKvEMeU?= =?us-ascii?Q?ZVs7TYBaR2waL0ojK5qPlSqGgtbdDQ0k9Kc6fqEPAnQhT/KP96+egFjBDRNe?= =?us-ascii?Q?w4hv3wf0tIow3qtXxDmfh3PFK0JUXQNocJv/xmWSEg67F7zhzSkfDH9QPOTr?= =?us-ascii?Q?gtaQ2WiPihVZBQdbwzyiAbnw1vgQyiIoqXnGooU9QgzDz2hc7m17S/ra4GoX?= =?us-ascii?Q?XiO2Ik6noTtz16Z2Fpm8nBNRuzrIF5mbHQNm+p+XyvssoFAnrM6fYBrb8iLZ?= =?us-ascii?Q?MfbCeERaB2tRTBWWQ7r3+viZyDi7YjK2JNLaibGDWUIY95zXWAxzpbQ4n0LK?= =?us-ascii?Q?VU7IyJxUQxuRDgcG7t3f8vZYRURUJXxnmJq9jXlxPFENRWunZcmlOFnOpt9I?= =?us-ascii?Q?hsSM03hizJDdqz8TceS1A9Y7LT0DKqy8MkGaW+rvi6HTUL0ME/UHt8qruZ5A?= =?us-ascii?Q?0omb5UPPiNiV4Jornu2CsNwU6u9fu0+RQn5Y5e80kcwTqfb0EKz8jQOO9wTo?= =?us-ascii?Q?9lxyAdxycCu03TIVJCxg72M2/eIHanV928mVaIZodTM+pzXEyqEPZUxTkueZ?= =?us-ascii?Q?fvDE+rdgjm1z5Ps61Jm81mkClT7hVdovG80ngQ77vZAmtD/b+rtK0+uYn+z1?= =?us-ascii?Q?1buTdCQyY9vSEVJH0U706UrlnQWBcAl3yQ3bsvLRcU7sPF5dYsvB5qp1c6XL?= =?us-ascii?Q?++fctn/7whT75TEO6xRuLRqi88RHKKJfV6fTTmcvgZphMJx4zr6pKLPzIJsj?= =?us-ascii?Q?sFOtufBpf9iAQrUdjAAkHb4gDngOPNvQv8TkXeFnJ+s8U/cA7lNkVC5q3sm+?= =?us-ascii?Q?5t539VFDS7vjoL4ImEKjnPygUY9Ik6i3C5gGcW65r4+F9cajl7NKZTUw595R?= =?us-ascii?Q?9fWLJUI55fLKTO0CTdpGD0jtDK5oS95ERuS4bg7XjBFNYQVXUXKp7o8BN3FS?= =?us-ascii?Q?eko71F663Lzb4+ZDTV0UMHATZx6d001chZYFXaRPjkSX4haHJ3pCV7KfXNSq?= =?us-ascii?Q?qcJKJPtAacv6Qs1O5J3eUr/uu3atp7AcLbGwfqTZKY0WZ07hlybD6oMvHZEJ?= =?us-ascii?Q?ERiTzt1HUdc0zS3NWyDeBoGl/il4Nr/xd2MWscV16lJGFgQXCxHmhHW8l4xX?= =?us-ascii?Q?vg/e3jQ5lYn+jqLdndSfyfYjR4rQxkiPMZpAU1a12PA8N3TlFOMuVYvBMnX/?= =?us-ascii?Q?6zwknU9zhF+UlqNXDTSdjDxD03tmn22zkUt46rWFSTR0PJZQ9KBSY4Qu4cgC?= =?us-ascii?Q?uUsyYWzUSpAzen0DLDPdaRaE+tQ7tafsGn++W4vndRjk+fvLW3yPxu4ngWjI?= =?us-ascii?Q?LGoPY5HzSGV1c+jGufuAlrmwAh2CeAe4HEOBhWx95oNYfB+FDFTa1GgmLCQD?= =?us-ascii?Q?LMAQITv08KpkV5fGmmZzD4t+J4hDhfYLR09iPV+n1qMOA+Bl?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ5PPF816B88375.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 295f85f9-224b-4774-a6b9-08dece077451 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2026 13:34:14.4474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P0w61wk8JVCtjnhe34IVCWh15tjMo4ocH30tPQbKra4zbVDE7Z6SVFfqs4sJasvn56XbiP2E5T8IblbWYJn2FQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB999096 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks! I'll push this soon-ish.=0A= =0A= ________________________________________=0A= From: Guinevere Larsen =0A= Sent: Friday, 19 June 2026 14:16=0A= To: Machado, Luis; gdb-patches@sourceware.org=0A= Subject: Re: [PATCH] [testsuite] Log gdb_do_cache misses only, not hits=0A= =0A= Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.=0A= =0A= =0A= On 6/19/26 5:16 AM, Luis Machado wrote:=0A= > The verbose -log in gdb_do_cache fired unconditionally on every call,=0A= > including cache hits. With many tests calling gdb_caching_procs like=0A= > get_compiler_info_1 per compilation, this produced dozens of repeated=0A= > identical lines per test file in the log, like so:=0A= >=0A= > gdb_do_cache: get_compiler_info_1 ( c )=0A= > gdb_do_cache: get_compiler_info_1 ( c )=0A= > gdb_do_cache: get_compiler_info_1 ( c )=0A= > gdb_do_cache: get_compiler_info_1 ( c )=0A= > gdb_do_cache: get_compiler_info_1 ( c )=0A= > gdb_do_cache: get_compiler_info_1 ( c )=0A= > gdb_do_cache: get_compiler_info_1 ( c )=0A= > gdb_do_cache: get_compiler_info_1 ( c )=0A= >=0A= > Move the log to just before actual computation, after both the=0A= > in-memory and on-disk cache checks. This helps keep the logs clean.=0A= =0A= Yeah, this looks like a good idea, and would definitely reduce the noise=0A= at the top of the log=0A= =0A= Reviewed-By: Guinevere Larsen =0A= =0A= > ---=0A= > gdb/testsuite/lib/cache.exp | 3 +--=0A= > 1 file changed, 1 insertion(+), 2 deletions(-)=0A= >=0A= > diff --git a/gdb/testsuite/lib/cache.exp b/gdb/testsuite/lib/cache.exp=0A= > index 71688ee373e..1ba8c881716 100644=0A= > --- a/gdb/testsuite/lib/cache.exp=0A= > +++ b/gdb/testsuite/lib/cache.exp=0A= > @@ -103,8 +103,6 @@ proc gdb_do_cache {name args} {=0A= > global gdb_data_cache objdir=0A= > global GDB_PARALLEL=0A= >=0A= > - verbose -log "gdb_do_cache: $name ( $args )"=0A= > -=0A= > # Normally, if we have a cached value, we skip computation and retu= rn=0A= > # the cached value. If set to 1, instead don't skip computation an= d=0A= > # verify against the cached value.=0A= > @@ -195,6 +193,7 @@ proc gdb_do_cache {name args} {=0A= > set old_gdb_nested_caching_proc_calls $::gdb_nested_caching_proc_ca= lls=0A= > set ::gdb_nested_caching_proc_calls {}=0A= >=0A= > + verbose -log "gdb_do_cache: $name ( $args )"=0A= > set real_name gdb_real__$name=0A= > set gdb_data_cache(${cache_name},value) [gdb_do_cache_wrap $real_na= me {*}$args]=0A= > set gdb_data_cache(${cache_name},exit) $::gdb_exit_called=0A= =0A= =0A= --=0A= Cheers,=0A= Guinevere Larsen=0A= it/its=0A= she/her (deprecated)=0A= =0A=