RE: [PATCH v13 1/2] gdb: add annotation in 'info locals' command for variables shadowing case

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Hi Andrew,

Thanks for the feedback.

>> +      if (var->symtab () && var->symtab ()->filename ())
>> +	file_name = lbasename (var->symtab ()->filename ());

> I suspect there might be some history here, but did you consider using `symtab_to_filename_for_display`?  If not, then it might be worth a comment explaining what that isn't being used.

The symtab_to_filename_for_display function has not been tried so far. But a quick test shows that by default GDB is configured to use a relative path for filenames. In the past there was feedback to show only the basename here instead of the full path. I will add a comment explaining why we are using lbasename instead.

Best Regards
Abdul Basit

-----Original Message-----
From: Andrew Burgess <aburgess@redhat.com> 
Sent: Monday, July 13, 2026 5:13 PM
To: Ijaz, Abdul B <abdul.b.ijaz@intel.com>; gdb-patches@sourceware.org
Cc: pedro@palves.net; philippe.waroquiers@skynet.be; Schimpe, Christina <christina.schimpe@intel.com>; lsix@lancelotsix.com; eliz@gnu.org; Ijaz, Abdul B <abdul.b.ijaz@intel.com>; guinevere@redhat.com
Subject: Re: [PATCH v13 1/2] gdb: add annotation in 'info locals' command for variables shadowing case

Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:

> --- a/gdb/printcmd.c
> +++ b/gdb/printcmd.c
> @@ -2377,12 +2377,17 @@ clear_dangling_display_expressions (struct 
> objfile *objfile)  void  print_variable_value (symbol *var, const 
> frame_info_ptr &frame,
>  		      ui_file *stream, int indent,
> -		      const language_defn *language)
> +		      const language_defn *language,
> +		      var_shadowing shadow_status)
>  {
>    try
>      {
>        struct value *val;
>        struct value_print_options opts;
> +      const char *file_name = nullptr;
> +
> +      if (var->symtab () && var->symtab ()->filename ())
> +	file_name = lbasename (var->symtab ()->filename ());

I suspect there might be some history here, but did you consider using `symtab_to_filename_for_display`?  If not, then it might be worth a comment explaining what that isn't being used.

Thanks,
Andrew

Intel Deutschland GmbH

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928