From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1736 invoked by alias); 22 Aug 2005 20:28:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 346 invoked by uid 22791); 22 Aug 2005 20:26:54 -0000 Received: from e33.co.us.ibm.com (HELO e33.co.us.ibm.com) (32.97.110.131) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 22 Aug 2005 20:26:54 +0000 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e33.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j7MKQmf5217284 for ; Mon, 22 Aug 2005 16:26:48 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j7MKQJcX409546 for ; Mon, 22 Aug 2005 14:26:19 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j7MKQlVT006676 for ; Mon, 22 Aug 2005 14:26:47 -0600 Received: from localhost (dyn94122390.austin.ibm.com [9.41.223.90]) by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id j7MKQhrt006451; Mon, 22 Aug 2005 14:26:46 -0600 Date: Mon, 22 Aug 2005 21:42:00 -0000 From: Dwayne Grant McConnell To: Mark Kettenis cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Have gdb display float infinity. In-Reply-To: <200508221955.j7MJtcP0019867@elgar.sibelius.xs4all.nl> Message-ID: References: <200508221955.j7MJtcP0019867@elgar.sibelius.xs4all.nl> X-X-Sender: dgm69@[9.42.107.100] MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-08/txt/msg00235.txt.bz2 On Mon, 22 Aug 2005, Mark Kettenis wrote: > > Date: Mon, 22 Aug 2005 14:00:11 -0500 (Central Daylight Time) > > From: Dwayne Grant McConnell > > > > I noticed that gdb does display NaNs in a special way but not infinity. > > This patch changes that. I'm a bit new here so I have a few questions. > > Thanks! Since you're new, I'll have to ask whether you have a > copyright assignment for gdb? Yes. I have one for all the toolchain. I have contributed only to glibc up to this point. Remind me, do I need to give you a reference number or somesuch? > > 1. Should I submit a testcase to go along with the patch? as a separate > > patch? (I have no idea were to put it yet but I figured I would ask.) > > Yes please! A seperate patch is fine, but make sure it gets in > shortly before or after the fix gets in. Will do. > > 2. I simply duplicated floatformat_is_nan() with one minor change to > > produce floatformat_is_inf(). I could have done this differently. Should I > > have changed float_format_is_nan() to float_format_is_nan_or_inf() and > > given the function a parameter for NaN v Inf? Something else? > > Hmm, this indeeds seems to duplicate a fair amount of code. Having > seperate functions for nan and inf is good I think, but do you see a > way to avoid code duplication? Let me think about it and I'll submit an alternate patch. > > I have tested this with both ppc and ppc64 but nothing else. > > It'd be great if you also could test this on another platform, > preferably amd64, i386 or m68k since those have extended double > formats. I'll see what I can do. -- Dwayne Grant McConnell Lotus Notes: Dwayne McConnell/Austin/IBM@IBMUS