From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22934 invoked by alias); 6 Nov 2002 06:56:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22927 invoked from network); 6 Nov 2002 06:56:26 -0000 Received: from unknown (HELO is.elta.co.il) (199.203.121.2) by sources.redhat.com with SMTP; 6 Nov 2002 06:56:26 -0000 Received: from is (is [199.203.121.2]) by is.elta.co.il (8.9.3/8.8.8) with SMTP id IAA01747; Wed, 6 Nov 2002 08:56:23 +0200 (IST) Date: Tue, 05 Nov 2002 22:56:00 -0000 From: Eli Zaretskii X-Sender: eliz@is To: Jelmer Vernooij cc: gdb-patches@sources.redhat.com, Andrew Cagney , Elena Zannoni Subject: Re: [PATCH] mi-symbol-* In-Reply-To: <20021105204529.GA11137@charis.vernstok> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-11/txt/msg00092.txt.bz2 On Tue, 5 Nov 2002, Jelmer Vernooij wrote: > Here's the latest version of my mi-symbol-* patch. Thanks! The documentation patch is approved, but please take care of these minor problems before it is committed: - Please break all lines inside @smallexample that are longer than 64 characters, otherwise they will produce warnings from TeX and ugly results in the printed manual. (You can tell in a note that the broken line is one long line.) - Why did you add so many empty lines? IMHO, this produces unpleasant results, both in the on-line (Info and HTML) and printed formats. - Where you say "pattern", please add that the pattern is a regular expression. Finally, I think the addition of this new feature needs to be mentioned in NEWS.