From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23721 invoked by alias); 17 Oct 2002 06:39:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23714 invoked from network); 17 Oct 2002 06:39:24 -0000 Received: from unknown (HELO is.elta.co.il) (199.203.121.2) by sources.redhat.com with SMTP; 17 Oct 2002 06:39:24 -0000 Received: from is (is [199.203.121.2]) by is.elta.co.il (8.9.3/8.8.8) with SMTP id IAA04966; Thu, 17 Oct 2002 08:39:23 +0200 (IST) Date: Wed, 16 Oct 2002 23:39:00 -0000 From: Eli Zaretskii X-Sender: eliz@is To: Kevin Buettner cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH RFA/RFC] Address class support In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-10/txt/msg00285.txt.bz2 On 16 Oct 2002, Jim Blandy wrote: > The dwarf2read.c part is approved. Sorry, Kevin it seems like I overlooked the original RFA. > > As before, I'll need approval on the dwarf2read.c changes from > > either Jim or Elena and I'll need Eli's okay on the Docs changes. Approved, with the following comments/suggestions: > +@deftypefn {Target Macro} int ADDRESS_CLASS_TYPE_FLAGS (int @var{byte_size}, int @var{dwarf2_addr_class}) Do you really need to use @var inside deftypefn (I don't have the Texinfo manual handy, sorry)? I thought the @def... directives supply the @var automatically. > +Consider a hypothetical architecture in which addresses are normally > +32-bits wide, but 16-bit addresses are also supported. Furthermore, > +suppose that the DWARF 2 information for this architecture simply I suggest to use either DWARF2 or @w{DWARF 2}, to prevent TeX and makeinfo from splitting this between DWARF and 2. > +@smallexample > +somearch_address_class_type_flags (int byte_size, int dwarf2_addr_class) This line is too long (even for @smallexample), so please break it in two: +somearch_address_class_type_flags (int byte_size, + int dwarf2_addr_class) (There are more too long lines in your examples. In general, any line inside @smallexample that is longer than 64 characters should be broken into several lines, or else it will cause overfull hbox'es when you TeX the manual.)