[RFA]: Change all fopen modes to binary in cli-dump.c [was Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin]

Corinna Vinschen
2002-08-09T09:19:23Z

On Thu, Aug 08, 2002 at 12:57:13PM -0400, Andrew Cagney wrote:
> BTW,
>
> NickC's just pointed Corinna and I at include/fopen-{bin,same}.c. I
> guess GDB could just use those when it wants a binary file open.

In the light of this I had a closer look to cli/cli-dump.c and
found that there are a lot of constand "w"'s "a"'s and "r"'s
used. So the previous patch was pretty incomplete. The below
patch substitutes every constant fopen mode in cli/cli-dump.c
by the appropriate binary open mode define from include/fopen-bin.h.

Ok to check in?

Corinna

2002-08-09 Corinna Vinschen <vinschen@redhat.com>

* cli/cli-dump.c: Change fopen modes to use binary open modes
as defined in include/fopen-bin.h throughout.

Index: cli/cli-dump.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-dump.c,v
retrieving revision 1.5
diff -u -p -r1.5 cli-dump.c
--- cli/cli-dump.c 7 Aug 2002 08:52:24 -0000 1.5
+++ cli/cli-dump.c 9 Aug 2002 09:12:48 -0000
@@ -360,61 +360,61 @@ dump_filetype (char *cmd, char *mode, ch
static void
dump_srec_memory (char *args, int from_tty)
{
- dump_memory_to_file (args, "w", "srec");
+ dump_memory_to_file (args, FOPEN_WB, "srec");
}

static void
dump_srec_value (char *args, int from_tty)
{
- dump_value_to_file (args, "w", "srec");
+ dump_value_to_file (args, FOPEN_WB, "srec");
}

static void
dump_ihex_memory (char *args, int from_tty)
{
- dump_memory_to_file (args, "w", "ihex");
+ dump_memory_to_file (args, FOPEN_WB, "ihex");
}

static void
dump_ihex_value (char *args, int from_tty)
{
- dump_value_to_file (args, "w", "ihex");
+ dump_value_to_file (args, FOPEN_WB, "ihex");
}

static void
dump_tekhex_memory (char *args, int from_tty)
{
- dump_memory_to_file (args, "w", "tekhex");
+ dump_memory_to_file (args, FOPEN_WB, "tekhex");
}

static void
dump_tekhex_value (char *args, int from_tty)
{
- dump_value_to_file (args, "w", "tekhex");
+ dump_value_to_file (args, FOPEN_WB, "tekhex");
}

static void
dump_binary_memory (char *args, int from_tty)
{
- dump_memory_to_file (args, "w", "binary");
+ dump_memory_to_file (args, FOPEN_WB, "binary");
}

static void
dump_binary_value (char *args, int from_tty)
{
- dump_value_to_file (args, "w", "binary");
+ dump_value_to_file (args, FOPEN_WB, "binary");
}

static void
append_binary_memory (char *args, int from_tty)
{
- dump_memory_to_file (args, "a", "binary");
+ dump_memory_to_file (args, FOPEN_AB, "binary");
}

static void
append_binary_value (char *args, int from_tty)
{
- dump_value_to_file (args, "a", "binary");
+ dump_value_to_file (args, FOPEN_AB, "binary");
}

struct dump_context
@@ -442,7 +442,7 @@ add_dump_command (char *name, void (*fun
c->completer = filename_completer;
d = XMALLOC (struct dump_context);
d->func = func;
- d->mode = "wb";
+ d->mode = FOPEN_WB;
set_cmd_context (c, d);
c->func = call_dump_func;

@@ -450,7 +450,7 @@ add_dump_command (char *name, void (*fun
c->completer = filename_completer;
d = XMALLOC (struct dump_context);
d->func = func;
- d->mode = "ab";
+ d->mode = FOPEN_AB;
set_cmd_context (c, d);
c->func = call_dump_func;

@@ -547,7 +547,7 @@ restore_section_callback (bfd *ibfd, ase
static void
restore_binary_file (char *filename, struct callback_data *data)
{
- FILE *file = fopen_with_cleanup (filename, "r");
+ FILE *file = fopen_with_cleanup (filename, FOPEN_RB);
int status;
char *buf;
long len;

--
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com