From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17375-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 28457 invoked by alias); 6 Aug 2002 16:12:41 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 28450 invoked from network); 6 Aug 2002 16:12:39 -0000
Received: from unknown (HELO is.elta.co.il) (199.203.121.2)
  by sources.redhat.com with SMTP; 6 Aug 2002 16:12:39 -0000
Received: from is (is [199.203.121.2])
	by is.elta.co.il (8.9.3/8.8.8) with SMTP id TAA12420
	for <gdb-patches@sources.redhat.com>; Tue, 6 Aug 2002 19:10:24 +0300 (IDT)
Date: Tue, 06 Aug 2002 09:12:00 -0000
From: Eli Zaretskii <eliz@is.elta.co.il>
X-Sender: eliz@is
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin
In-Reply-To: <20020806101017.Q3921@cygbert.vinschen.de>
Message-ID: <Pine.SUN.3.91.1020806191005.12393B-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-08/txt/msg00125.txt.bz2


On Tue, 6 Aug 2002, Corinna Vinschen wrote:

> -  d->mode = "w";
> +  d->mode = "wb";
>    set_cmd_context (c, d);
>    c->func = call_dump_func;
>  
> @@ -450,7 +450,7 @@ add_dump_command (char *name, void (*fun
>    c->completer =  filename_completer;
>    d = XMALLOC (struct dump_context);
>    d->func = func;
> -  d->mode = "a";
> +  d->mode = "ab";
>    set_cmd_context (c, d);
>    c->func = call_dump_func;
>  
> 
> Is that ok?

Fine with me, thanks.