From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15400-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 10382 invoked by alias); 13 May 2002 05:22:26 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 10375 invoked from network); 13 May 2002 05:22:22 -0000
Received: from unknown (HELO is.elta.co.il) (199.203.121.2)
  by sources.redhat.com with SMTP; 13 May 2002 05:22:22 -0000
Received: from is (is [199.203.121.2])
	by is.elta.co.il (8.9.3/8.8.8) with SMTP id IAA08715;
	Mon, 13 May 2002 08:20:33 +0300 (IDT)
Date: Sun, 12 May 2002 22:22:00 -0000
From: Eli Zaretskii <eliz@is.elta.co.il>
X-Sender: eliz@is
To: Daniel Jacobowitz <drow@mvista.com>
cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix gdb/277 by separating types
In-Reply-To: <20020513005352.GA16752@nevyn.them.org>
Message-ID: <Pine.SUN.3.91.1020513081759.8317L-100000@is>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-SW-Source: 2002-05/txt/msg00448.txt.bz2


On Sun, 12 May 2002, Daniel Jacobowitz wrote:

> This patch requires my previous cleanup patch.  It fixes a test in
> gdb.c++/method.exp for GCC 3.x/stabs+, and closes gdb/277.

A minor comment about style:

>        type = (struct type *) xmalloc (sizeof (struct type));
> +      memset ((char *) (type), 0, sizeof (struct type));

Why the cast to `char *' in the first argument of memset?  I thought, 
since we require an ISO C compiler, we shouldn't need those anymore.
(There are more casts like that in the patch.)

The same goes for casting the return value of xmalloc, I think.