From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11403 invoked by alias); 6 Feb 2002 11:24:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11245 invoked from network); 6 Feb 2002 11:23:56 -0000 Received: from unknown (HELO is.elta.co.il) (199.203.121.2) by sources.redhat.com with SMTP; 6 Feb 2002 11:23:56 -0000 Received: from is (is [199.203.121.2]) by is.elta.co.il (8.9.3/8.8.8) with SMTP id NAA03660; Wed, 6 Feb 2002 13:22:56 +0200 (IST) Date: Wed, 06 Feb 2002 03:24:00 -0000 From: Eli Zaretskii X-Sender: eliz@is To: Pierre Muller cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] New info command for win32 native target In-Reply-To: <4.2.0.58.20020206103131.00ad1898@ics.u-strasbg.fr> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-02/txt/msg00161.txt.bz2 On Wed, 6 Feb 2002, Pierre Muller wrote: > This patch adds a new win32 native specific command: > "info sel" Thanks. A couple of comments: - this command needs to be documented in gdb.texinfo, similarly to "info dos ldt" and friends (and in the same chapter, but in a different subsection); - since it's a Windows-specific command, I suggest to name it "info w32 sel" or "info windows sel" or maybe "info cygwin sel": something that will tell it's not available on every platform (actually, using ``seg'' instead of ``sel'' might probably be even better, since the information you show is about a segment whose selector is passed as an argument); - I think it's a good idea to make the format used to print the segment as similar as possible to the one used by "info dos ..." commands; - why do you only print CS, DS, and FS if no argument is given? why not all of the segment registers? I think at least SS and GS might be interesting Finally, will this work on non-x86 systems running MS-Windows (assuming Cygwin supports such systems)? The register names are x86-specific, right?