From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17665 invoked by alias); 21 Jan 2002 09:51:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17633 invoked from network); 21 Jan 2002 09:51:04 -0000 Received: from unknown (HELO is.elta.co.il) (199.203.121.2) by sources.redhat.com with SMTP; 21 Jan 2002 09:51:04 -0000 Received: from is (is [199.203.121.2]) by is.elta.co.il (8.9.3/8.8.8) with SMTP id LAA16931; Mon, 21 Jan 2002 11:50:10 +0200 (IST) Date: Mon, 21 Jan 2002 01:51:00 -0000 From: Eli Zaretskii X-Sender: eliz@is To: Andrew Cagney cc: Fernando Nasser , gdb-patches@sources.redhat.com Subject: Re: [rfa/cli] s/NO_FUNCTION/NULL/ In-Reply-To: <3C4B4FFE.4050401@cygnus.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2002-01/txt/msg00636.txt.bz2 On Sun, 20 Jan 2002, Andrew Cagney wrote: > Do you have any problems with the below? > > Andrew > > > Hello, > > > > The attached replaces the NO_FUNCTION macro with NULL. If you > > examine the code, function.cfunc() is only sometimes assigned the > > value NO_FUNCTION and no code actually tests for a value of > > NO_FUNCTION. Consequently, I can't see any point in having this > > macro. IMHO, someone should test this change with the latest versions of GCC, including their development line: they could have their own ideas when you are allowed to pass NULL, especially with all the warning options we use.