Re: [RFC] add 'save-breakpoints' command

Michael Snyder
2001-12-04T22:48:08Z

Klee Dienes wrote:

[...]
> We've got a ton of stuff to submit, but as a warm-up, I'm starting
> witha relatively minor feature-addition --- a command to save the
> current set of breakpoints to a file that can be read in later. We've
> been using this on our platform for a few months now, and folks seem
> to like it. I've also tested the patch against the i386/Linux
> testsuite ... nothing appears to break.

Klee,

Could you elaborate a little bit on how this change works with
shlib breakpoints, what the original_type field is for, the
bp_tbreakpoint type, etc.? In what circumstances is the
current breakpoint type different from the original breakpoint type?

Also, a couple of comments on the patch:

There are several mentions of future breaks; you should probably
clean those up until you're ready to submit that feature.

And the changelog says:
> (set_raw_breakpoint): init new original_type field.

but that change itself doesn't seem to be in the patch.

get_breakpoint_count is defined but never used.

I will say that I like the idea, and the implementation's not bad,
but I'd like it better without that extra bit of complexity.

Michael