From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24729 invoked by alias); 26 Nov 2001 07:56:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.cygnus.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24708 invoked from network); 26 Nov 2001 07:56:57 -0000 Received: from unknown (HELO is.elta.co.il) (199.203.121.2) by sourceware.cygnus.com with SMTP; 26 Nov 2001 07:56:57 -0000 Received: from is (is [199.203.121.2]) by is.elta.co.il (8.9.3/8.8.8) with SMTP id JAA10772; Mon, 26 Nov 2001 09:56:01 +0200 (IST) Date: Sun, 11 Nov 2001 10:50:00 -0000 From: Eli Zaretskii X-Sender: eliz@is To: fnf@ninemoons.com cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] temporary fix for bogus language check In-Reply-To: <200111251921.fAPJLP323371@fishpond.ninemoons.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2001-11/txt/msg00221.txt.bz2 On Sun, 25 Nov 2001, Fred Fish wrote: > We could fix this problem by > eliminating the test of the current language, but then every gdb > session would incur the additional overhead of attempting to demangle > every symbol regardless of whether or not any C++ symbols were > present. Another option is to set some global flag whenever symbols > for a C++ function are read in, and then do the current language test > unconditionally once we know that there might be C++ symbols > somewhere. Yet another option is to add a parameter to lookup_symbol > that says whether to consider the possibility that the symbol to be > looked up is a C++ symbol, set that appropriately when calling > lookup_symbol, and use that value to decide whether or not to try > demangling the symbol. I think we should consider all the languages used in the program being debugged. How to find out what those languages are and whether to cache them in some list is an implementation detail. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Zaretskii To: fnf@ninemoons.com Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] temporary fix for bogus language check Date: Sun, 25 Nov 2001 23:56:00 -0000 Message-ID: References: <200111251921.fAPJLP323371@fishpond.ninemoons.com> X-SW-Source: 2001-11/msg00436.html Message-ID: <20011125235600.VLlc3OSha0Z_38NoutVS7KBHVaI9EMqd6eZgKKSS4RE@z> On Sun, 25 Nov 2001, Fred Fish wrote: > We could fix this problem by > eliminating the test of the current language, but then every gdb > session would incur the additional overhead of attempting to demangle > every symbol regardless of whether or not any C++ symbols were > present. Another option is to set some global flag whenever symbols > for a C++ function are read in, and then do the current language test > unconditionally once we know that there might be C++ symbols > somewhere. Yet another option is to add a parameter to lookup_symbol > that says whether to consider the possibility that the symbol to be > looked up is a C++ symbol, set that appropriately when calling > lookup_symbol, and use that value to decide whether or not to try > demangling the symbol. I think we should consider all the languages used in the program being debugged. How to find out what those languages are and whether to cache them in some list is an implementation detail.