From: Eli Zaretskii <eliz@is.elta.co.il>
To: Jiri Smid <smid@suse.cz>
Cc: gdb-patches@sources.redhat.com, Mark Kettenis <kettenis@science.uva.nl>
Subject: Re: [RFA]: x86_64 target - multiarch
Date: Tue, 11 Sep 2001 05:43:00 -0000 [thread overview]
Message-ID: <Pine.SUN.3.91.1010911144046.4452D-100000@is> (raw)
In-Reply-To: <s8vsnduj589.fsf@naga.suse.cz>
On 11 Sep 2001, Jiri Smid wrote:
> *** 466,472 ****
> {
> int retval;
>
> ! if (len == 3 || len > 4 || addr % len != 0)
> retval = i386_handle_nonaligned_watchpoint (WP_INSERT, addr, len, type);
> else
> {
> --- 481,488 ----
> {
> int retval;
>
> ! if ((len != 1 && len !=2 && len !=4 && (TARGET_HAS_DR_LEN_8 && len !=8))
> ! || addr % len != 0)
> retval = i386_handle_nonaligned_watchpoint (WP_INSERT, addr, len, type);
> else
> {
Unless I'm missing something, the new code loses if addr and len both
equal to 3, for a target which does not define TARGET_HAS_DR_LEN_8. I
think this is better:
if ((len != 1 && len !=2 && len !=4 && !(TARGET_HAS_DR_LEN_8 && len ==8))
(There's one more case like this.)
Other than that, I have no comments.
next prev parent reply other threads:[~2001-09-11 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-05 7:02 Jiri Smid
2001-09-05 7:38 ` Eli Zaretskii
2001-09-05 15:31 ` Mark Kettenis
2001-09-05 18:05 ` Andrew Cagney
2001-09-06 0:30 ` Eli Zaretskii
2001-09-11 5:13 ` Jiri Smid
2001-09-11 5:43 ` Eli Zaretskii [this message]
2001-09-12 2:31 ` Jiri Smid
2001-09-05 17:55 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SUN.3.91.1010911144046.4452D-100000@is \
--to=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@science.uva.nl \
--cc=smid@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox