Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@is.elta.co.il>
To: Elena Zannoni <ezannoni@cygnus.com>
Cc: ezannoni@cygnus.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Multiarch tm_print_insn
Date: Wed, 05 Sep 2001 03:12:00 -0000	[thread overview]
Message-ID: <Pine.SUN.3.91.1010905131249.13798C-100000@is> (raw)
In-Reply-To: <15253.42307.875233.300520@krustylu.cygnus.com>

On Wed, 5 Sep 2001, Elena Zannoni wrote:

> How about this?

Approved, with a few minor comments (see below).

Thanks!

> +debugged memory abd returns the length of the instruction, in bytes.  If
                   ^^^
A typo.

> +a target doesn't define its own printing routine, it defaults to an
> +accessor function for the global pointer @var{tm_print_insn}.

Isn't tm_print_insn a name of a real variable in GDB sources?  If so,
it should have the @code markup; @var is for names of formal
parameters and such likes: names that stand for something else, not
for themselves.

> +usually points to a function in the @code{opcodes} library
> +(@xref{,,opcodes}).

Does opcodes have a manual?  I cannot find it anywhere.  If there is
no docs for opcodes, I think we should remove the xref.

>  @var{info} is a structure defined in @code{opcodes}
> +used to pass information to the instruction decoding routine.

Maybe we should at least tell what is the name of that structure, so
that an interested reader could grep for it in opcodes' sources.


  reply	other threads:[~2001-09-05  3:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-21 16:26 Elena Zannoni
2001-08-21 17:33 ` Andrew Cagney
2001-09-05 17:07   ` Elena Zannoni
     [not found] ` <3405-Wed22Aug2001084554+0300-eliz@is.elta.co.il>
     [not found]   ` <15236.12258.330506.371048@krustylu.cygnus.com>
     [not found]     ` <9003-Thu23Aug2001085323+0300-eliz@is.elta.co.il>
2001-09-04 21:00       ` Elena Zannoni
2001-09-05  3:12         ` Eli Zaretskii [this message]
2001-09-05 11:58           ` Elena Zannoni
2001-09-06  0:47             ` Eli Zaretskii
2001-09-06  5:02               ` Elena Zannoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SUN.3.91.1010905131249.13798C-100000@is \
    --to=eliz@is.elta.co.il \
    --cc=ezannoni@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox