From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eli Zaretskii To: Jiri Smid Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: x86_64 target files Date: Thu, 02 Aug 2001 08:39:00 -0000 Message-id: References: X-SW-Source: 2001-08/msg00035.html On 2 Aug 2001, Jiri Smid wrote: > This is the related new files for x86-64 target. What is x86-64, exactly? Some of the files seem to hint that it's an AMD CPU, but others just say x86-64. If this is a new target, I think it should be added to NEWS in the appropriate section. > * x86_64-linux-tdep.c: New file. > * x86_64-linux-nat.c: New file. These 2 file names clash after truncation to 8+3, so they should be added to config/djgpp/fnchange.lst, which see. > + int > + x86_64_insert_watchpoint (ptid_t ptid, CORE_ADDR addr, int len, int rw) > + { > + return x86_64_insert_aligned_watchpoint (ptid, addr, addr, len, rw); > + } > + > + static int > + x86_64_insert_aligned_watchpoint (ptid_t ptid, CORE_ADDR waddr, CORE_ADDR addr, > + int len, int rw) This and the rest of watchpoint support is based on the old code from i386v-nat.c. Isn't it much better to use the approach in i386-nat.c instead? Most of the ia32 targets now use code from i386-nat.c, and thus support watchpoint sharing, and have a few subtle bugs in the previous code solved. I think it makes sense to base this new target on the new code rather than on the old one.