From: Eli Zaretskii <eliz@is.elta.co.il>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [rfc] ui_out_is_mi_like_p(); Was: [patch] Add -i=mi0 as an interpreter
Date: Wed, 04 Jul 2001 23:53:00 -0000 [thread overview]
Message-ID: <Pine.SUN.3.91.1010705095443.15332M-100000@is> (raw)
In-Reply-To: <3B4399D4.1060302@cygnus.com>
On Wed, 4 Jul 2001, Andrew Cagney wrote:
> > Why can't this strncmp be done in one place and then saved in some
> > variable? If you do need to use strncmp all over the place, then I
> > can't say I care to see the magical constants "mi" and 2 every time
> > you do ;-)
>
> The attached patch replaces:
>
> > ! if (interpreter_p && strncmp (interpreter_p, "mi", 2) == 0)
> >
>
> with:
>
> if (ui_out_is_mi_like_p (uiout))
I'm happy now, thanks ;-)
> + /* HACK: Some code in core GDB is currently looks at the output
This sentence should be fixed.
prev parent reply other threads:[~2001-07-04 23:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-18 10:54 Andrew Cagney
2001-06-19 2:00 ` Eli Zaretskii
2001-06-19 12:47 ` Andrew Cagney
2001-07-04 14:03 ` [rfa/doc] Mention -i=mi0; Was: " Andrew Cagney
2001-07-04 23:52 ` Eli Zaretskii
2001-07-05 21:06 ` Andrew Cagney
2001-07-06 1:16 ` Eli Zaretskii
2001-07-04 15:34 ` [rfc] ui_out_is_mi_like_p(); " Andrew Cagney
2001-07-04 23:53 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SUN.3.91.1010705095443.15332M-100000@is \
--to=eliz@is.elta.co.il \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sourceware.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox