From: Eli Zaretskii <eliz@is.elta.co.il>
To: Jim Blandy <jimb@zwingli.cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: minor cleanup to dwarf2read.c
Date: Wed, 04 Jul 2001 02:10:00 -0000 [thread overview]
Message-ID: <Pine.SUN.3.91.1010704120651.4589B-100000@is> (raw)
In-Reply-To: <npy9q5nllr.fsf@zwingli.cygnus.com>
On 4 Jul 2001, Jim Blandy wrote:
> If you have:
>
> foo_buf = malloc (sizeof (*foo_buf) * foo_length);
>
> for (i = 0; i < foo_length; i++)
> ...
>
> you don't put any scary comments around the for statement about the
> termination conditions, do you?
I meant something like this:
/* The while loop below was originally this:
while ((unsigned int) (info_ptr - dwarf_info_buffer)
((info_ptr - dwarf_info_buffer) % 4) < dwarf_info_size)
This seems to be trying to round info_ptr up to the next
four-byte boundary, but that's not what it actually did. If we
discover the problem the old code was really trying to address,
we can fix it properly. */
next prev parent reply other threads:[~2001-07-04 2:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-03 15:29 Jim Blandy
2001-07-03 23:57 ` Eli Zaretskii
2001-07-04 1:28 ` Jim Blandy
2001-07-04 2:10 ` Eli Zaretskii [this message]
2001-07-04 8:33 ` Jim Blandy
2001-07-04 9:30 ` Andrew Cagney
2001-07-04 9:11 Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SUN.3.91.1010704120651.4589B-100000@is \
--to=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@zwingli.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox