Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@is.elta.co.il>
To: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: Make gdbserver use async I/O on Linux
Date: Wed, 06 Jun 2001 23:34:00 -0000	[thread overview]
Message-ID: <Pine.SUN.3.91.1010607093547.28343J-100000@is> (raw)
In-Reply-To: <20010606140322.A29266@nevyn.them.org>

On Wed, 6 Jun 2001, Daniel Jacobowitz wrote:

> The only problem I can think of that this might cause is if F_SETOWN is less
> portable than FASYNC.

Exactly.  And that is why I'd suggest to make this change conditioned
on F_SETOWN being defined.

Please note that the original code took care to use the F* macros
only if they were defined:

>  #if defined(F_SETFL) && defined (FASYNC)
>    save_fcntl_flags = fcntl (remote_desc, F_GETFL, 0);
>    fcntl (remote_desc, F_SETFL, save_fcntl_flags | FASYNC);
> +  fcntl (remote_desc, F_SETOWN, getpid());
>    disable_async_io ();
>  #endif /* FASYNC */

This uses F_SETFL and FASYNC only if they are defined.  I suggest to
do the same with F_SETOWN.


  reply	other threads:[~2001-06-06 23:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-06 14:03 Daniel Jacobowitz
2001-06-06 23:34 ` Eli Zaretskii [this message]
2001-06-07 10:43   ` Daniel Jacobowitz
2001-06-07 11:38     ` Eli Zaretskii
2001-06-07 12:04       ` Daniel Jacobowitz
2001-06-08  0:37         ` Eli Zaretskii
2001-06-21 13:28 ` J.T. Conklin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SUN.3.91.1010607093547.28343J-100000@is \
    --to=eliz@is.elta.co.il \
    --cc=dmj+@andrew.cmu.edu \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox