From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eli Zaretskii <eliz@is.elta.co.il>
To: Christopher Faylor <cgf@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA?] Windows cleanup
Date: Thu, 31 May 2001 07:29:00 -0000
Message-id: <Pine.SUN.3.91.1010531172359.23879D-100000@is>
References: <20010530232225.A19889@redhat.com>
X-SW-Source: 2001-05/msg00504.html

On Wed, 30 May 2001, Christopher Faylor wrote:

> I think that all of these qualify as obvious fixes, given that I'm the
> Cygwin maintainer and _MSC_VER is no longer supported, however, I'd
> like someone to verify that I properly whacked the ifdefs since I can't
> really test things like "nindy-share".

The changes look good to me, except that:

> 	* utils.c (quit): Ditto.

This patch is not in what you posted.

> 	* defs.h: Ditto.

This one is also omitted.

> 	* m32-rom.c: Ditto.
> 	* p-exp.y: Ditto.
> 	* ser-e7kpc.c: Ditto.  Define WIN32_LEAN_AND_MEAN under _WIN32, for
> 	faster compilation.
> 	(get_ds_base): Remove _MSC_VER version of this function.

And these.

> 	* nindy-share/ttyflush.c: Ditto.
> 	* rdi-share/host.h: Ditto.

Ditto.

> Index: partial-stab.h
> ===================================================================
> RCS file: /cvs/uberbaum/gdb/partial-stab.h,v
> retrieving revision 1.7
> diff -c -2 -0 -p -r1.7 partial-stab.h
> *** partial-stab.h	2001/03/06 08:21:11	1.7
> --- partial-stab.h	2001/05/30 21:34:59
> *************** switch (CUR_SYMBOL_TYPE)
> *** 583,626 ****

This patch is not relevant to _MSCVER or __CYGWIN__.

> - 
> - #if defined(_MSC_VER)		/* should test for wingdb instead? */
> - 
> - /*
> -  * Windows translates all keyboard and mouse events 
> -  * into a message which is appended to the message 
> -  * queue for the process.
> -  */
> - 
>   void
>   notice_quit (void)
>   {
> -   int k = win32pollquit ();
> -   if (k == 1)
> -     quit_flag = 1;
> -   else if (k == 2)
> -     immediate_quit = 1;
> - }
> - 
> - #else /* !defined(_MSC_VER) */
> - 
> - void
> - notice_quit (void)
> - {
>     /* Done by signals */
>   }
> - 
> - #endif /* !defined(_MSC_VER) */

With this patch (for utils.c), notice_quit becomes an empty function and 
so it should probably be nuked altogether.