Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@is.elta.co.il>
To: Daniel Berlin <dan@cgsoftware.com>
Cc: Jim Blandy <jimb@zwingli.cygnus.com>,
	David Taylor <taylor@candd.org>,
	gdb-patches@sources.redhat.com, Anthony Green <green@redhat.com>
Subject: Re: RFA: abstract C++ ABI dependencies
Date: Wed, 25 Apr 2001 00:24:00 -0000	[thread overview]
Message-ID: <Pine.SUN.3.91.1010425102012.22758V-100000@is> (raw)
In-Reply-To: <m2snix5uew.fsf@dynamic-addr-83-177.resnet.rochester.edu>

On 25 Apr 2001, Daniel Berlin wrote:

> and IMHO, saying 
> 
> #include <cp-abi.h> /* Include C++ ABI stuff */
> 
> is like saying
> 
> i++; /* Increment i */

That's not what I suggested to say in the comment.

> > In other words, if there were no reason to have an explanation, why would 
> > Jim feel he should provide one on the ChangeLog?
> 
> Because nobody else realized those macros were spread out across 2 (or
> was it 3) header files, and had nothing to do with what the header
> file purported to be, except me, because nobody had touched the hard
> core C++ ABI stuff in at least year or so, except me?

Just tell the above in the comment, or put there what Jim suggested to 
put in the ChangeLog:

 #include "cp-abi.h".  These files all use functions now declared there.
> 1. A message explaining why it was done, on the mailing list (done at
> some point in the past), so others understand.
> 2. A short reminder in the ChangeLog, saying why it was done.

I think the comments in the code should explain anything that isn't 
obvious from reading the code itself.  Mail messages and ChangeLog 
entries are not the right place for such information, IMHO.


  reply	other threads:[~2001-04-25  0:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-24 12:27 David Taylor
2001-04-24 15:33 ` Jim Blandy
2001-04-24 16:23   ` Daniel Berlin
2001-04-24 18:27     ` Jim Blandy
2001-04-24 23:21   ` Eli Zaretskii
2001-04-24 23:35     ` Daniel Berlin
2001-04-24 23:52       ` Eli Zaretskii
2001-04-25  0:07         ` Daniel Berlin
2001-04-25  0:24           ` Eli Zaretskii [this message]
2001-04-24 17:42 ` Jim Blandy
2001-04-25  5:04   ` Anthony Green
  -- strict thread matches above, loose matches on Subject: below --
2001-04-25  6:40 David Taylor
2001-04-26 17:23 ` Jim Blandy
2001-04-24 10:30 Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SUN.3.91.1010425102012.22758V-100000@is \
    --to=eliz@is.elta.co.il \
    --cc=dan@cgsoftware.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=green@redhat.com \
    --cc=jimb@zwingli.cygnus.com \
    --cc=taylor@candd.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox