From: Eli Zaretskii <eliz@is.elta.co.il>
To: Kevin Buettner <kevinb@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] ia64-linux-nat.c: Make HW watchpoint support work again
Date: Sun, 01 Apr 2001 00:46:00 -0000 [thread overview]
Message-ID: <Pine.SUN.3.91.1010401104335.15706Q-100000@is> (raw)
In-Reply-To: <1010331222947.ZM13805@ocotillo.lan>
On Sat, 31 Mar 2001, Kevin Buettner wrote:
> So, I conclude that it is easier (and safer) to just hard code this
> constant in GDB. If someone has a better suggestion, I'm willing
> to listen...
>
> * ia64-linux-nat.c (ia64_linux_stopped_by_watchpoint): Change
> TRAP_HWBKPT constant to match that in the kernel headers for
> Linux/IA-64.
>
> Index: ia64-linux-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/ia64-linux-nat.c,v
> retrieving revision 1.8
> diff -u -p -r1.8 ia64-linux-nat.c
> --- ia64-linux-nat.c 2001/03/01 01:39:21 1.8
> +++ ia64-linux-nat.c 2001/03/31 21:48:28
> @@ -630,7 +630,7 @@ ia64_linux_stopped_by_watchpoint (int pi
> errno = 0;
> ptrace (PTRACE_GETSIGINFO, tid, (PTRACE_ARG3_TYPE) 0, &siginfo);
>
> - if (errno != 0 || siginfo.si_code != 4 /* TRAP_HWBKPT */)
> + if (errno != 0 || siginfo.si_code != 0x30004 /* TRAP_HWBKPT */)
> return 0;
How about masking the high bits of si_code? Then it would work for
both cases, and will probably suffer less bitrot in the future.
prev parent reply other threads:[~2001-04-01 0:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-31 14:30 Kevin Buettner
2001-04-01 0:46 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SUN.3.91.1010401104335.15706Q-100000@is \
--to=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox