Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ben Harris <bjh21@cam.ac.uk>
To: <gdb-patches@sources.redhat.com>
Subject: [RFA] Fix stack backtraces on 26-bit ARM
Date: Thu, 08 Nov 2001 09:52:00 -0000	[thread overview]
Message-ID: <Pine.SOL.4.33.0111201810060.8688-100000@draco.cus.cam.ac.uk> (raw)

I've got an assignment signed, and commit access, so can someone approve
this now?

I'm trying to make GDB 5.0 work on NetBSD/arm26.  One problem I've run
into is that even with "set apcs32 0", stack backtraces include flags in
the program counter for all frames apart from the top one.  I think this
patch fixes the problem by using arm_addr_bits_remove() to clean up the
PC fetched from a stack frame.  I'm not in a position to check this still
works on arm32 and thumb.

ChangeLog entry:
2001-11-20  Ben Harris  <bjh21@netbsd.org>

	* arm-tdep.c (arm_frame_saved_pc): Use arm_addr_bits_remove to
	clean the PC.  Necessary for backtraces in 26-bit modes.

Patch:
*** arm-tdep.c  2000/07/26 00:32:33     1.1.1.1
--- arm-tdep.c  2001/10/20 16:40:16
*************** arm_frame_saved_pc (struct frame_info *f
*** 1019,1025 ****
  #endif
      {
 	CORE_ADDR pc = arm_find_callers_reg (fi, LR_REGNUM);
!	return IS_THUMB_ADDR (pc) ? UNMAKE_THUMB_ADDR (pc) : pc;
      }
  }

--- 1021,1027 ----
  #endif
      {
 	CORE_ADDR pc = arm_find_callers_reg (fi, LR_REGNUM);
!	return arm_addr_bits_remove(pc);
      }
  }

-- 
Ben Harris                                                   <bjh21@netbsd.org>
Portmaster, NetBSD/arm26               <URL:http://www.netbsd.org/Ports/arm26/>



             reply	other threads:[~2001-11-20 19:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-08  9:52 Ben Harris [this message]
2001-11-08 10:06 ` Fernando Nasser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SOL.4.33.0111201810060.8688-100000@draco.cus.cam.ac.uk \
    --to=bjh21@cam.ac.uk \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox