From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17554 invoked by alias); 4 Feb 2008 10:16:47 -0000 Received: (qmail 17544 invoked by uid 22791); 4 Feb 2008 10:16:47 -0000 X-Spam-Check-By: sourceware.org Received: from cerber.ds.pg.gda.pl (HELO cerber.ds.pg.gda.pl) (153.19.208.18) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 04 Feb 2008 10:16:13 +0000 Received: from localhost (unknown [127.0.0.17]) by cerber.ds.pg.gda.pl (Postfix) with ESMTP id 0F597400CD; Mon, 4 Feb 2008 11:16:08 +0100 (CET) Received: from cerber.ds.pg.gda.pl ([153.19.208.18]) by localhost (cerber.ds.pg.gda.pl [153.19.208.18]) (amavisd-new, port 10024) with ESMTP id lasd6PROIcdN; Mon, 4 Feb 2008 11:16:03 +0100 (CET) Received: from piorun.ds.pg.gda.pl (piorun.ds.pg.gda.pl [153.19.208.8]) by cerber.ds.pg.gda.pl (Postfix) with ESMTP id 7729840041; Mon, 4 Feb 2008 11:16:03 +0100 (CET) Received: from blysk.ds.pg.gda.pl (macro@blysk.ds.pg.gda.pl [153.19.208.6]) by piorun.ds.pg.gda.pl (8.13.8/8.13.8) with ESMTP id m14AG3Ma025863; Mon, 4 Feb 2008 11:16:03 +0100 Date: Mon, 04 Feb 2008 10:16:00 -0000 From: "Maciej W. Rozycki" To: Joel Brobecker cc: Pedro Alves , Jim Blandy , gdb-patches Subject: Re: arm_addr_bits_remove In-Reply-To: <20080124214849.GF3979@adacore.com> Message-ID: References: <47965D31.3040602@codesourcery.com> <8f2776cb0801221525w1d26661dgf6452f876197a591@mail.gmail.com> <479752C8.8030201@portugalmail.pt> <8f2776cb0801231121r3fe9aea0q6f3c3d6887fcb251@mail.gmail.com> <20080123192842.GA22477@caradoc.them.org> <8f2776cb0801231311o19c31781h8a4663c405bcd22b@mail.gmail.com> <479819E2.1030603@portugalmail.pt> <8f2776cb0801232227n64502d4akef4642b051e77772@mail.gmail.com> <4798871B.4080207@codesourcery.com> <20080124133844.GA15771@caradoc.them.org> <20080124214849.GF3979@adacore.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Status: Clean X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-02/txt/msg00065.txt.bz2 On Thu, 24 Jan 2008, Joel Brobecker wrote: > > > 2008-01-24 Pedro Alves > > > > > > * buildsym.c (record_line): Don't try to strip unused addr bits. > > > If you're daring enough, this is OK - this could affect any target > > defining gdbarch_addr_bits_remove so keep an eye out in case hppa, > > m88k, mips, or s390 break. Please wait another day before checking it > > in, in case someone else knows more about it. > > I just ran the testsuite on hppa and mips-irix, no regression. > It might not come as a surprise given that the patch is removing > something that handles what amounts to incorrect debugging info, > but it's better than nothing. In both case, we use GNU and the > system linker. For the record -- to ever hit this case on MIPS you would have to run the test suite in the 32-bit kernel mode, so IRIX certainly does not apply here. One of the embedded targets might fit, e.g. using newlib and the GNU sim. Still this would be a bug if it mattered these days as proper sign-extension of addresses is meant to be done for MIPS now. Maciej