From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13050 invoked by alias); 18 Apr 2007 10:37:57 -0000 Received: (qmail 13040 invoked by uid 22791); 18 Apr 2007 10:37:56 -0000 X-Spam-Check-By: sourceware.org Received: from pollux.ds.pg.gda.pl (HELO pollux.ds.pg.gda.pl) (153.19.208.7) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 18 Apr 2007 11:37:53 +0100 Received: from localhost (localhost [127.0.0.1]) by pollux.ds.pg.gda.pl (Postfix) with ESMTP id 9583DE1D2E; Wed, 18 Apr 2007 12:37:44 +0200 (CEST) Received: from pollux.ds.pg.gda.pl ([127.0.0.1]) by localhost (pollux.ds.pg.gda.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I5jcwhFXN2EW; Wed, 18 Apr 2007 12:37:44 +0200 (CEST) Received: from piorun.ds.pg.gda.pl (piorun.ds.pg.gda.pl [153.19.208.8]) by pollux.ds.pg.gda.pl (Postfix) with ESMTP id 27BB7E1C6E; Wed, 18 Apr 2007 12:37:44 +0200 (CEST) Received: from blysk.ds.pg.gda.pl (macro@blysk.ds.pg.gda.pl [153.19.208.6]) by piorun.ds.pg.gda.pl (8.13.8/8.13.8) with ESMTP id l3IAbp7d010714; Wed, 18 Apr 2007 12:37:51 +0200 Date: Wed, 18 Apr 2007 12:51:00 -0000 From: "Maciej W. Rozycki" To: gdb-patches@sources.redhat.com cc: Vladimir Prus , Eli Zaretskii , drow@false.org, insight@sourceware.org Subject: Re: [patch] fix insight (was: Re: Ping: frozen variable objects) In-Reply-To: <4625EB96.73C48E8C@dessent.net> Message-ID: References: <200703251351.43195.vladimir@codesourcery.com> <200704111843.43991.vladimir@codesourcery.com> <200704141353.51962.vladimir@codesourcery.com> <4625EB96.73C48E8C@dessent.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Status: Clean X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00279.txt.bz2 On Wed, 18 Apr 2007, Brian Dessent wrote: > This has unfortunately broken insight, which had one caller of > varobj_update lurking in gdbtk/generic/gdbtk-varobj.c that now fails due > to the extra paremeter. Fix attached. This is not enough as varobj_update() has to be wrapped these days -- please see: http://sources.redhat.com/ml/insight/2007-q2/msg00012.html The patch included there already contains a change like yours. Maciej