From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13728 invoked by alias); 23 Apr 2013 13:54:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13714 invoked by uid 89); 23 Apr 2013 13:54:59 -0000 X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 23 Apr 2013 13:54:59 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UUdgP-0003d8-I0 from joseph_myers@mentor.com for gdb-patches@sourceware.org; Tue, 23 Apr 2013 06:54:57 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 23 Apr 2013 06:54:57 -0700 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Tue, 23 Apr 2013 14:54:55 +0100 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1UUdgM-0005ay-OS; Tue, 23 Apr 2013 13:54:54 +0000 Date: Wed, 24 Apr 2013 00:00:00 -0000 From: "Joseph S. Myers" To: Sandra Loosemore CC: Subject: Re: [patch 3/4] Nios II gdbserver support In-Reply-To: <5175CC11.7060905@codesourcery.com> Message-ID: References: <5174820E.6090500@codesourcery.com> <5175CC11.7060905@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2013-04/txt/msg00708.txt.bz2 On Mon, 22 Apr 2013, Sandra Loosemore wrote: > > Copyright (C) 2008-2013 Free Software Foundation, Inc. > > > > (all on one line) and likewise for any other new files in this patch > > series. > > Hmmm, I thought the year range was only acceptable when there were actually > modifications to the file in all of those years? No, modifications to the package as a whole (presuming it had public version control, or a public release, for each year in question), not to the individual file. > > > +#ifndef PTRACE_GET_THREAD_AREA > > > +#define PTRACE_GET_THREAD_AREA 25 > > > +#endif > > > > The same comment I made on the AArch64 port applies here: for native code > > in new ports, as opposed to use of new definitions in existing ports, you > > should just be able to assume recent-enough headers (at least until the > > Linux kernel port goes upstream, at which point the first upstream release > > with the code can be the minimum version of kernel headers supported) > > rather than having such #if conditionals. > > I'm not sure what change you want here. If I remove that block of code, the > file fails to compile with the kernel headers currently being provided by > Altera, which do not define PTRACE_GET_THREAD_AREA. That sounds like the kernel headers need to be fixed before the kernel port goes upstream, at which point GDB can depend on the first kernel version to go upstream rather than allowing for old kernel header versions (which will be ABI-incompatible with the upstream version anyway because of not using the generic syscall ABI). -- Joseph S. Myers joseph@codesourcery.com