From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17669 invoked by alias); 3 Sep 2009 21:50:08 -0000 Received: (qmail 17660 invoked by uid 22791); 3 Sep 2009 21:50:07 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Sep 2009 21:50:03 +0000 Received: (qmail 13875 invoked from network); 3 Sep 2009 21:50:01 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 Sep 2009 21:50:01 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.69) (envelope-from ) id 1MjKBs-0007c2-1E for gdb-patches@sourceware.org; Thu, 03 Sep 2009 21:50:00 +0000 Date: Thu, 03 Sep 2009 21:50:00 -0000 From: "Joseph S. Myers" To: gdb-patches@sourceware.org Subject: Fix ending-run.exp bug with addresses containing "33" Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00095.txt.bz2 I saw a failure on gdb.base/ending-run.exp of the form: 33 } (gdb) next __libc_start_main (main=0x804862d
, argc=1, ubp_av=0xbf9ca144, init=0x80486c0 <__libc_csu_init>, fini=0x80486b0 <__libc_csu_fini>, rtld_fini=0xb7f0a330 <_dl_fini>, stack_end=0xbf9ca13c) at libc-start.c:252 252 exit (result); (gdb) FAIL: gdb.base/ending-run.exp: step out of main The problem here is the "33" in the address of _dl_fini matching a regular expression intended to match a line number, and so resulting in the error for seeing the closing brace twice; this patch restricts that regular expression to avoid this bogus match. OK to commit? 2009-09-03 Joseph Myers * gdb.base/ending-run.exp: Restrict regular expression matching line number to require closing brace following. Index: gdb.base/ending-run.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ending-run.exp,v retrieving revision 1.36 diff -u -r1.36 ending-run.exp --- gdb.base/ending-run.exp 5 Jul 2009 22:38:19 -0000 1.36 +++ gdb.base/ending-run.exp 3 Sep 2009 21:45:51 -0000 @@ -120,7 +120,7 @@ send_gdb "next\n" set nexted 0 gdb_expect { - -re "33.*$gdb_prompt $" { + -re "33\[ \t\]+\}.*$gdb_prompt $" { # sometimes we stop at the closing brace, if so, do another next if { $nexted } { fail "step out of main" -- Joseph S. Myers joseph@codesourcery.com