From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27018 invoked by alias); 26 Aug 2009 19:13:02 -0000 Received: (qmail 26997 invoked by uid 22791); 26 Aug 2009 19:13:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_32,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Aug 2009 19:12:54 +0000 Received: (qmail 20266 invoked from network); 26 Aug 2009 19:12:52 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Aug 2009 19:12:52 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.69) (envelope-from ) id 1MgNvO-0002sw-Tb; Wed, 26 Aug 2009 19:12:50 +0000 Date: Wed, 26 Aug 2009 19:22:00 -0000 From: "Joseph S. Myers" To: Vladimir Prus cc: gdb-patches@sources.redhat.com Subject: Re: Disable gdb.mi environment-pwd tests for remote-host testing In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00458.txt.bz2 On Wed, 19 Aug 2009, Vladimir Prus wrote: > Joseph S. Myers wrote: > > > When doing remote-host testing, it is generally necessary that any path > > that is available on the build system and used in testing (the source and > > object directories, in particular) is also available on the host system > > with the same contents (that is, a shared filesystem is used). In theory > > it is not needed, but most DejaGnu testsuites do not do all the copying > > between build and host systems that is required to work without a shared > > filesystem. > > > > Although the path must be available on both systems, the canonical form > > may not be the same on both systems (for example, the path on the host may > > be a symlink to a /net automount from the build system, or the host may > > have a different OS using different path conventions). mi-basics.exp and > > mi2-basics.exp contain tests of environment-pwd which are thus > > inappropriate in the remote-host case, since this command calls getcwd > > which may return a canonical path for the host, not the same as the path > > on the build system. This patch disables the problematic tests for the > > remote-host case. OK to commit? > > This patch is OK. However, please add a comment in the testcase explaining > why the test is not run for remote host testing -- some condensed form of > the above. I have committed the patch in this form. Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v retrieving revision 1.1942 diff -u -r1.1942 ChangeLog --- ChangeLog 24 Aug 2009 22:01:30 -0000 1.1942 +++ ChangeLog 26 Aug 2009 19:11:39 -0000 @@ -1,3 +1,9 @@ +2009-08-26 Joseph Myers + + * gdb.mi/mi-basics.exp (test_cwd_specification): Do not test + environment-pwd for remote host. + * gdb.mi/mi2-basics.exp (test_cwd_specification): Likewise. + 2009-08-24 Keith Seitz * gdb.cp/cpcompletion.exp (test_class_complete): New procedure. Index: gdb.mi/mi-basics.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-basics.exp,v retrieving revision 1.22 diff -u -r1.22 mi-basics.exp --- gdb.mi/mi-basics.exp 9 Jun 2009 17:12:42 -0000 1.22 +++ gdb.mi/mi-basics.exp 26 Aug 2009 19:11:39 -0000 @@ -184,9 +184,13 @@ "205\\\^done" \ "environment-cd arg operation" - mi_gdb_test "206-environment-pwd" \ + # The canonical name of the working directory may differ on a + # remote host from that on the build system. + if ![is_remote host] { + mi_gdb_test "206-environment-pwd" \ "206\\\^done,cwd=\"${escapedobjdir}\"" \ "environment-pwd operation" + } } proc test_path_specification {} { Index: gdb.mi/mi2-basics.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-basics.exp,v retrieving revision 1.14 diff -u -r1.14 mi2-basics.exp --- gdb.mi/mi2-basics.exp 9 Jun 2009 17:12:43 -0000 1.14 +++ gdb.mi/mi2-basics.exp 26 Aug 2009 19:11:39 -0000 @@ -186,9 +186,13 @@ "205\\\^done" \ "environment-cd arg operation" - mi_gdb_test "206-environment-pwd" \ + # The canonical name of the working directory may differ on a + # remote host from that on the build system. + if ![is_remote host] { + mi_gdb_test "206-environment-pwd" \ "206\\\^done,cwd=\"${escapedobjdir}\"" \ "environment-pwd operation" + } } proc test_path_specification {} { -- Joseph S. Myers joseph@codesourcery.com