From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix cross-endian DFP for GDB
Date: Fri, 27 Jun 2008 20:45:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.0806271953120.1747@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20080627175141.GA9226@caradoc.them.org>
On Fri, 27 Jun 2008, Daniel Jacobowitz wrote:
> On Fri, Jun 27, 2008 at 05:40:45PM +0000, Joseph S. Myers wrote:
> > 2008-06-27 Joseph Myers <joseph@codesourcery.com>
> >
> > * dfp.c (decimal_convert): Call match_endianness before and after
> > conversion.
>
> Does promote_decimal have the same problem?
Both callers of promote_decimal call match_endianness beforehand. Thus
the promote_decimal interface is that it uses host endianness.
> I'm wondering why the calls can't go in decimal_to_number /
> decimal_from_number... (resp. decimal_to_string).
I imagine almost any choice of which set of functions use host endianness
and which use target endianness would work. Given that which use which
endianness isn't documented, and nor is an underlying design, I kept the
existing interface for what is passed to/from each function and did the
minimal change to make it work.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2008-06-27 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 17:57 Joseph S. Myers
2008-06-27 18:18 ` Daniel Jacobowitz
2008-06-27 20:45 ` Joseph S. Myers [this message]
2008-06-27 20:47 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806271953120.1747@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox