Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Wu Zhou <woodzltc@cn.ibm.com>
To: ezannoni@redhat.com
Cc: gdb-patches@sources.redhat.com, drow@false.org, manjo@austin.ibm.com
Subject: [Patch Ping]: Dont skip DW_TAG_member in load_partial_dies
Date: Thu, 22 Dec 2005 16:10:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.0512221248230.16314@localhost.localdomain> (raw)

Hi Elena,

I am now taking over some of Manoj's work on GDB.  He ever sent a patch to 
not skip DW_TAG_member in load_partial_dies.  The url is:

 http://sourceware.org/ml/gdb-patches/2005-02/msg00152.html

What is the status of this patch?  Do you have chance to review this?  

I also noticed that Daniel also posted a patch in 
http://sourceware.org/ml/gdb-patches/2005-04/msg00066.html, which also 
include this one.  That patch involve a little more situation.  But  this 
patch (attached below) is just one line one.  So I am thinking of that it 
might be easier to review this one, right?  Very happy to know what you 
are thinking of this patch.  Thanks a lot!

2005-02-15  Manoj Iyer  <manjo@austin.ibm.com>

	* dwarf2read.c (load_partial_dies): Save DIE with tag
	DW_TAG_member, generated by XLC when compiling C++ application.

diff -Naur ./old/src/gdb/dwarf2read.c ./new/src/gdb/dwarf2read.c
--- ./old/src/gdb/dwarf2read.c  2005-02-15 11:13:05.000000000 -0600
+++ ./new/src/gdb/dwarf2read.c  2005-02-22 10:24:08.000000000 -0600
@@ -5167,7 +5167,8 @@
          && abbrev->tag != DW_TAG_enumerator
          && abbrev->tag != DW_TAG_subprogram
          && abbrev->tag != DW_TAG_variable
-         && abbrev->tag != DW_TAG_namespace)
+         && abbrev->tag != DW_TAG_namespace
+         && abbrev->tag != DW_TAG_member)
        {
          /* Otherwise we skip to the next sibling, if any.  */
          info_ptr = skip_one_die (info_ptr + bytes_read, abbrev, cu);

Regards
- Wu Zhou


                 reply	other threads:[~2005-12-22  4:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0512221248230.16314@localhost.localdomain \
    --to=woodzltc@cn.ibm.com \
    --cc=drow@false.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=manjo@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox