From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20290 invoked by alias); 1 Aug 2005 04:44:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20281 invoked by uid 22791); 1 Aug 2005 04:44:29 -0000 Received: from ausmtp02.au.ibm.com (HELO ausmtp02.au.ibm.com) (202.81.18.187) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 01 Aug 2005 04:44:29 +0000 Received: from sd0208e0.au.ibm.com (d23rh904.au.ibm.com [202.81.18.202]) by ausmtp02.au.ibm.com (8.12.10/8.12.10) with ESMTP id j714dTIV039714 for ; Mon, 1 Aug 2005 14:39:31 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.250.243]) by sd0208e0.au.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j714lEJe179682 for ; Mon, 1 Aug 2005 14:47:16 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.12.11/8.13.3) with ESMTP id j714iHFg028347 for ; Mon, 1 Aug 2005 14:44:17 +1000 Received: from [9.181.134.203] ([9.181.134.203]) by d23av02.au.ibm.com (8.12.11/8.12.11) with ESMTP id j714iFf6028316; Mon, 1 Aug 2005 14:44:16 +1000 Date: Mon, 01 Aug 2005 04:44:00 -0000 From: Wu Zhou X-X-Sender: woodzltc@localhost.localdomain To: Daniel Jacobowitz cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] New testcase to evaluate Fortran substring expression In-Reply-To: <20050801021253.GH30901@nevyn.them.org> Message-ID: References: <20050703185733.GI13811@nevyn.them.org> <20050714234612.GA21620@nevyn.them.org> <20050801021253.GH30901@nevyn.them.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-08/txt/msg00012.txt.bz2 On Sun, 31 Jul 2005, Daniel Jacobowitz wrote: > This is looks very good! Two comments for you: > > - The magic (and undocumented) constants are not a good idea. Rather > than being clever with abs(), how about using an enum saying what > sort of range it is? What about adding the following enumeration definition to f-lang.h and keeping the use of abs to get the number of arguments following the F90 subrange expression: /* This enumeration type is to identify the sort of F90 subrange expression. If only the low bound is by default, set it to -1; if both bounds are by default, set it to 0; if only the high bound is by default, set it to 1; if no bound is by default, set it to 2. The absolute value of the value is also the number of arguments following this expression */ enum f90_range_type { LOW_BOUND_DEFAULT=-1, BOTH_BOUND_DEFAULT, HIGH_BOUND_DEFAULT, NONE_BOUND_DEFAULT }; If use other values, it might looks ugly to me to set the nargs based on the type value respectively. What is your point on this? > > - You have a bunch of lines which are too long in eval.c; could you > fix that, please? Sorry, I am not very sure what is the maximum limit of a line in the sources and comments. Maybe it is 72? or 80, or any other number? Maybe I can choose to use the smaller one? Regards - Wu Zhou