From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5899 invoked by alias); 26 May 2005 05:02:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5882 invoked by uid 22791); 26 May 2005 05:02:01 -0000 Received: from ausmtp02.au.ibm.com (HELO ausmtp02.au.ibm.com) (202.81.18.187) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 26 May 2005 05:02:01 +0000 Received: from sd0208e0.au.ibm.com (d23rh904.au.ibm.com [202.81.18.202]) by ausmtp02.au.ibm.com (8.12.10/8.12.10) with ESMTP id j4Q4vO2F265242; Thu, 26 May 2005 14:57:25 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.250.237]) by sd0208e0.au.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j4Q54P9Q132340; Thu, 26 May 2005 15:04:29 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.12.11/8.13.3) with ESMTP id j4Q51Xbh000362; Thu, 26 May 2005 15:01:33 +1000 Received: from plinuxt18.cn.ibm.com (plinuxt18.cn.ibm.com [9.181.140.28]) by d23av04.au.ibm.com (8.12.11/8.12.11) with ESMTP id j4Q51VLD000316; Thu, 26 May 2005 15:01:32 +1000 Date: Thu, 26 May 2005 06:37:00 -0000 From: Wu Zhou To: Eli Zaretskii cc: gdb@sources.redhat.com, gdb-patches@sources.redhat.com Subject: Re: about the usage of sprintf in gdb, specifically in gdb/remote.c In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SW-Source: 2005-05/txt/msg00555.txt.bz2 On Thu, 26 May 2005, Eli Zaretskii wrote: > > But I need to design a scenario to verify that. It seems that most target don't implement "to_extra_thread_info" (ok, at least in i386 and ppc), gdbserver will return NULL to "qThreadExtraInfo". So I can't verify this yet. > That's my point exactly: you don't need to go to such lengths. If it > isn't 100% obvious that no overflow is possible, we should remove > sprintf in favor of safer functions. Maybe you are right. I will post a patch in a while. Cheers - Wu Zhou